[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Severity|minor |enhancement --- Comment #9 from Julian Maurice --- Switching severity to 'enhancement' as the patch does not fix any bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Jonathan Druart changed: What|Removed |Added Attachment #45465|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 45637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45637&action=edit Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the authorities Z39.50 search results page so that MARC previews are displayed in Bootstrap modals. This patch also modifies the authorities toolbar include file to make the Z39.50 search popup size match that in cataloging. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Authorities. 2. Click the "New from Z39.50" button to open the search window. 3. Perform any search which will return multiple results. 4. Test the visible "MARC" link for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" link it displays. Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- (In reply to Frédéric Demians from comment #3) > Side note: Since there is this contextual menu to view/import biblio > records, why do we keep the 2 columns with links MARC/Import? I think the context menu is often 'not found' as it's still kind of an unusual element in Koha - I think as the columns are at the end of the table, it doesn'thurt to keep them for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 --- Comment #5 from Owen Leonard --- (In reply to Jonathan Druart from comment #4) > There is no modal-footer with the close button, is it expected? Yes, I explain in the commit message: > Because the modal is triggered from a pop-up window, the modal has been > reformated to exclude the footer and reduce the size of the modal > header. I think this is an acceptable tradeoff between consistency and readability for these instances when the modal is displayed within a smaller pop-up window. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- There is no modal-footer with the close button, is it expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #3 from Frédéric Demians --- Side note: Since there is this contextual menu to view/import biblio records, why do we keep the 2 columns with links MARC/Import? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Frédéric Demians changed: What|Removed |Added Attachment #45463|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians --- Created attachment 45465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45465&action=edit Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the authorities Z39.50 search results page so that MARC previews are displayed in Bootstrap modals. This patch also modifies the authorities toolbar include file to make the Z39.50 search popup size match that in cataloging. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Authorities. 2. Click the "New from Z39.50" button to open the search window. 3. Perform any search which will return multiple results. 4. Test the visible "MARC" link for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" link it displays. Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Frédéric Demians changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 --- Comment #1 from Owen Leonard --- Created attachment 45463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45463&action=edit Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the authorities Z39.50 search results page so that MARC previews are displayed in Bootstrap modals. This patch also modifies the authorities toolbar include file to make the Z39.50 search popup size match that in cataloging. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Authorities. 2. Click the "New from Z39.50" button to open the search window. 3. Perform any search which will return multiple results. 4. Test the visible "MARC" link for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" link it displays. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
