[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Jonathan Druart changed: What|Removed |Added Blocks||25760 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 [Bug 25760] Holds Ratio report is not reporting on records with 1 hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 --- Comment #16 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Katrin Fischer changed: What|Removed |Added Attachment #92146|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 93671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93671=edit Bug 15422: Consider partial copies needed as whole numbers Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Katrin Fischer changed: What|Removed |Added Attachment #92145|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 93670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93670=edit Bug 15422: Correct calculation of holds ratio report See comment 1 for a detailed explanation of current calculations and needed calculations Also removes an unnecessary variable To test: 1 - Place 4 holds on a biblio with one item 2 - go to /cgi-bin/koha/circ/reserveratios.pl (Circulation->Holds ratios) 3 - Run with 'Hold ratio'=3, it says order 1, ok 4 - Run with HR=4, it says order 1, wrong 5 - Run with HR=2, it syas order 2, wrong 6 - Run with HR=.5, it syas order 4, wrong 7 - Apply patch 8 - Run with HR=3, order 1, OK 9 - Run with HR=4, item does not appear (0 to order), OK 10 - Run with HR=2, order 1, OK 11 - Run with HR=.5, order 7, OK Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 --- Comment #13 from Katrin Fischer --- Note: Needs strict mode turned off, the hold ratio report is broken with strict in general. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Nick Clemens changed: What|Removed |Added Attachment #82874|0 |1 is obsolete|| --- Comment #12 from Nick Clemens --- Created attachment 92146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92146=edit Bug 15422: Consider partial copies needed as whole numbers Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Nick Clemens changed: What|Removed |Added Attachment #82873|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 92145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92145=edit Bug 15422: Correct calculation of holds ratio report See comment 1 for a detailed explanation of current calculations and needed calculations Also removes an unnecessary variable To test: 1 - Place 4 holds on a biblio with one item 2 - go to /cgi-bin/koha/circ/reserveratios.pl (Circulation->Holds ratios) 3 - Run with 'Hold ratio'=3, it says order 1, ok 4 - Run with HR=4, it says order 1, wrong 5 - Run with HR=2, it syas order 2, wrong 6 - Run with HR=.5, it syas order 4, wrong 7 - Apply patch 8 - Run with HR=3, order 1, OK 9 - Run with HR=4, item does not appear (0 to order), OK 10 - Run with HR=2, order 1, OK 11 - Run with HR=.5, order 7, OK Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #10 from Katrin Fischer --- Hi Nick, I agree on fixing the bug first - can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15422: Correct calculation of holds ratio report Using index info to reconstruct a base tree... M circ/reserveratios.pl Falling back to patching base and 3-way merge... Auto-merging circ/reserveratios.pl CONFLICT (content): Merge conflict in circ/reserveratios.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 15422: Correct calculation of holds ratio report Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15422-Correct-calculation-of-holds-ratio-repor-0dn4_I.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 --- Comment #9 from Nick Clemens --- (In reply to Katrin Fischer from comment #7) > I am with Jonathan on this one... it kind of screems for tests as they are > practically written out in the bug and on the commit message. It will also > help us to confirm in the future that this is the desired behaviour. Filed bug 23360, testing this code is problematic because of strict mode. This bug has been known for 4 years, lets patch it now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Nick Clemens changed: What|Removed |Added Blocks||23360 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23360 [Bug 23360] Move reserveratios to a module and refactor to avoid problems with strict mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #8 from Nick Clemens --- I definitely agree. we should move this to a module and test it, however, this code has problems: 1 - It gets data that is not grouped so breaks under strict mode 2 - All our tests enforce strict mode 3 - It should be refactored or reworked to use DBIC and objects instead of straight SQL The fix here is relatively minor, the work you are asking for is more intense and will involve likely changing the report and its output and should be another report. Let's fix providing the wrong data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Katrin Fischer changed: What|Removed |Added Summary|Number of items to order on |Number of items to order on |holds ratio report will not |holds ratio report will not |fulfill the holds ratio.|fulfill the holds ratio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- I am with Jonathan on this one... it kind of screems for tests as they are practically written out in the bug and on the commit message. It will also help us to confirm in the future that this is the desired behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- I would say that this is an excellent candidate for tests. We should move the existing code, provide tests to highlight that the code is wrong, then fix it! Please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 --- Comment #5 from Owen Leonard --- Created attachment 82874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82874=edit Bug 15422: Consider partial copies needed as whole numbers Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Owen Leonard changed: What|Removed |Added Attachment #82718|0 |1 is obsolete|| Attachment #82842|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 82873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82873=edit Bug 15422: Correct calculation of holds ratio report See comment 1 for a detailed explanation of current calculations and needed calculations Also removes an unnecessary variable To test: 1 - Place 4 holds on a biblio with one item 2 - go to /cgi-bin/koha/circ/reserveratios.pl (Circulation->Holds ratios) 3 - Run with 'Hold ratio'=3, it says order 1, ok 4 - Run with HR=4, it says order 1, wrong 5 - Run with HR=2, it syas order 2, wrong 6 - Run with HR=.5, it syas order 4, wrong 7 - Apply patch 8 - Run with HR=3, order 1, OK 9 - Run with HR=4, item does not appear (0 to order), OK 10 - Run with HR=2, order 1, OK 11 - Run with HR=.5, order 7, OK Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21941 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 --- Comment #3 from Nick Clemens --- Created attachment 82842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82842=edit Bug 15422: Consider partial copies needed as whole numbers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 --- Comment #2 from Owen Leonard --- > 8 - Run with HR=3, order 1, OK I get "No items found" in this case. Is that a bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Nick Clemens changed: What|Removed |Added CC||ke...@bywatersolutions.com, ||n...@bywatersolutions.com Assignee|gmcha...@gmail.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 --- Comment #1 from Nick Clemens --- Created attachment 82718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82718=edit Bug 15422: Correct calculation of holds ratio report See comment 1 for a detailed explanation of current calculations and needed calculations Also removes an unnecessary variable To test: 1 - Place 4 holds on a biblio with one item 2 - go to /cgi-bin/koha/circ/reserveratios.pl (Circulation->Holds ratios) 3 - Run with 'Hold ratio'=3, it says order 1, ok 4 - Run with HR=4, it says order 1, wrong 5 - Run with HR=2, it syas order 2, wrong 6 - Run with HR=.5, it syas order 4, wrong 7 - Apply patch 8 - Run with HR=3, order 1, OK 9 - Run with HR=4, item does not appear (0 to order), OK 10 - Run with HR=2, order 1, OK 11 - Run with HR=.5, order 7, OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
