[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Jonathan Druart changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #10 from Jonathan Druart --- Moving this outside of the QA queue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 --- Comment #9 from Katrin Fischer --- There are still a lot of patches visible on splitter that also want to modify this file - will hold off this for a bit. http://splitter.koha-community.org/files - search for smart-rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Owen Leonard changed: What|Removed |Added Blocks||16300 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 [Bug 16300] Remove the use of "onclick" from circulation and fine rules template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Owen Leonard changed: What|Removed |Added Attachment #50364|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 50417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50417&action=edit [SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel Looks like refactoring :) No regressions, no koha-qa errors Signed-off-by: Kyle M Hall Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Jesse Weaver changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Jesse Weaver changed: What|Removed |Added Attachment #46453|0 |1 is obsolete|| --- Comment #7 from Jesse Weaver --- Created attachment 50364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50364&action=edit Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel Looks like refactoring :) No regressions, no koha-qa errors Signed-off-by: Kyle M Hall Putting back to Needs Signoff purely because the underlying template had moved a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Patch doesn't apply --- Comment #6 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- I looked it up with the splitter tool: bug 8367 - needs sign-off bug 15407 - needs sign-off bug 15354 - passed qa bug 9805 - failed qa bug 14695 - failed qa I'd like to wait a bit too - there is currently no new work dependent on the clean-up and it will make it harder for other patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Kyle M Hall changed: What|Removed |Added Attachment #46241|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 46453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46453&action=edit Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel Looks like refactoring :) No regressions, no koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- There are patches in the queue waiting for SO and QA. I would prefer to wait before pushing this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #46161|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 46241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46241&action=edit [SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel Looks like refactoring :) No regressions, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 --- Comment #1 from Jesse Weaver --- Created attachment 46161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46161&action=edit Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Jesse Weaver changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
