[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Nick Clemens  changed:

   What|Removed |Added

 Blocks||28742


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28742
[Bug 28742] OAI.xslt has hardcoded metadataPrefix = oai_dc
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16194

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||16174


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174
[Bug 16174] Warning in tt_valid.t due to bug 15527
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #28 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #46459|0   |1
is obsolete||
  Attachment #49414|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart  
---
Created attachment 49451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49451=edit
Bug 15527: Add a stylesheet for OAI-PMH to aid usability

This patch introduces an XSLT file grabbed from DSpace and a couple
css files.

To test:

- Point to your dev Koha's oai endpoint. For example:
  http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListMetadataFormats
=> FAIL: Look how ugly it is for humans.
- Apply this patch
- Reload
=> SUCCES: It is styled and provides really useful links to interact with
  the OAI server verbs.
- Sign off :-D

Sponsored-by: Universidad Empresarial Siglo 21

Signed-off-by: Frédéric Demians 
  Works as described. Nice looking.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #27 from Jonathan Druart  
---
Created attachment 49452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49452=edit
Bug 15527: (qa followup) Add DSpace license to the about page

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #25 from Tomás Cohen Arazi  ---
Created attachment 49414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49414=edit
Bug 15527: (qa followup) Add DSpace license to the about page

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #24 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #16)
> QA comments:
> 1/ Could you please add the DSpace license (linked to the xslt) to the about
> page?

This is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #23 from Kyle M Hall  ---
(In reply to Frédéric Demians from comment #22)
> Kyle, my patch was also about adding (In reply to Kyle M Hall from comment
> #21)
> > I think the issue at hand is that this patch revealed a new bug in testing
> > where the non-package version of Koha's apache conf no longer matches the
> > package version in behavior and functionality. While appreciated, I think
> > Frédéric's followup is not needed and we should instead fix the bug for
> > non-package installs of Koha. That should solve the issue and once that and
> > the license followup have been submitted this can move forward.
> 
> I agree with this plan...
> 
> Where is located the Apache conf file? Do you already know what is its
> difference with etc/koha-http.conf?
> 
> My followup patch was also introducing a way to specify a local XSLT in
> extended mode. See this:
> 
> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46460=diff
> 
> But it could be added later when this patch will be in master.

I agree. I think it would be good as a followup on a new bug report. I believe
Tomás is going to file the bug and patch for the issue at hand.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #22 from Frédéric Demians  ---
Kyle, my patch was also about adding (In reply to Kyle M Hall from comment #21)
> I think the issue at hand is that this patch revealed a new bug in testing
> where the non-package version of Koha's apache conf no longer matches the
> package version in behavior and functionality. While appreciated, I think
> Frédéric's followup is not needed and we should instead fix the bug for
> non-package installs of Koha. That should solve the issue and once that and
> the license followup have been submitted this can move forward.

I agree with this plan...

Where is located the Apache conf file? Do you already know what is its
difference with etc/koha-http.conf?

My followup patch was also introducing a way to specify a local XSLT in
extended mode. See this:

https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46460=diff

But it could be added later when this patch will be in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46464|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Failed QA   |Signed Off

--- Comment #21 from Kyle M Hall  ---
I think the issue at hand is that this patch revealed a new bug in testing
where the non-package version of Koha's apache conf no longer matches the
package version in behavior and functionality. While appreciated, I think
Frédéric's followup is not needed and we should instead fix the bug for
non-package installs of Koha. That should solve the issue and once that and the
license followup have been submitted this can move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #20 from Frédéric Demians  ---
What point(s) prevent this patch to return to 'signed-off' status?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #17 from Jonathan Druart  
---
3/ Should the new file be translatable?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #19 from Frédéric Demians  ---
(In reply to Jonathan Druart from comment #17)
> 3/ Should the new file be translatable?

In my opinion, humble as appropriate, no.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #18 from Frédéric Demians  ---
> 2/ Frédéric, why did you move the xslt file to the OPAC css dir? Why not
> koha-tmpl/opac-tmpl/bootstrap/en/xslt/?

See comment 8. The XSL file is accessed directly by the web browser by http.
Files in koha-tmpl/opac-tmpl/bootstrap/en/xslt/ can only be accessed by Koha
web scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #16 from Jonathan Druart  
---
QA comments:
1/ Could you please add the DSpace license (linked to the xslt) to the about
page?
2/ Frédéric, why did you move the xslt file to the OPAC css dir? Why not
koha-tmpl/opac-tmpl/bootstrap/en/xslt/?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #14 from Jonathan Druart  
---
Comment on attachment 46464
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46464
[SIGNED-OFF]Bug 15527: Custom stylesheet in extended mode

Review of attachment 46464:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15527=46464)
-

::: Koha/OAI/Server/Repository.pm
@@ +111,5 @@
>  
>  # Load configuration file if defined in OAI-PMH:ConfFile syspref
> +my $conf = C4::Context->preference("OAI-PMH:ConfFile");
> +if ( $conf ) {
> +$self->{ conf } = $conf = LoadFile( $conf );

What's the point of this change? I personally prefer the previous version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #15 from Frédéric Demians  ---
(In reply to Jonathan Druart from comment #14)
> Comment on attachment 46464 [details] [review]
> [SIGNED-OFF]Bug 15527: Custom stylesheet in extended mode
> 
> Review of attachment 46464 [details] [review]:
> -
> 
> ::: Koha/OAI/Server/Repository.pm
> @@ +111,5 @@
> >  
> >  # Load configuration file if defined in OAI-PMH:ConfFile syspref
> > +my $conf = C4::Context->preference("OAI-PMH:ConfFile");
> > +if ( $conf ) {
> > +$self->{ conf } = $conf = LoadFile( $conf );
> 
> What's the point of this change? I personally prefer the previous version.

The $conf variable is used above (line 148) in order to get the new extended
'xslt' parameter:

148 $response->xslt(
149 $conf && $conf->{xslt}
150   ? $conf->{xslt}
151   : "/opac-tmpl/bootstrap/css/OAI.xslt"
152 );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #12 from Héctor Eduardo Castro Avalos  
---

> 
> Tomás, I've signed-off your first patch, and obsoleted the 2 others. You
> should take a look at mine (2nd patch attached) and sign it whether it seems
> OK to you. Maybe a third eye (Hector) and sign-off would be welcome. Thanks
> for the good job.

For me looks very good I'll signed-off if you don't care Tomás.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #46460|0   |1
is obsolete||

--- Comment #13 from Héctor Eduardo Castro Avalos  
---
Created attachment 46464
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46464=edit
[SIGNED-OFF]Bug 15527: Custom stylesheet in extended mode

Add a parameter to YAML config file in order to specify a local XSLT
used style the XML returned by OAI Server. Some doc.

Move default XSLT from /opac-tmpl/xslt to
/opac-tmpl/bootstrap/css/OAI.xslt.

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #11 from Frédéric Demians  ---
(In reply to Frédéric Demians from comment #10)
> Created attachment 46460 [details] [review]
> Bug 15527 Custom stylesheet in extended mode
> 
> Add a parameter to YAML config file in order to specify a local XSLT
> used style the XML returned by OAI Server. Some doc.
> 
> Move default XSLT from /opac-tmpl/xslt to
> /opac-tmpl/bootstrap/css/OAI.xslt.

Tomás, I've signed-off your first patch, and obsoleted the 2 others. You should
take a look at mine (2nd patch attached) and sign it whether it seems OK to
you. Maybe a third eye (Hector) and sign-off would be welcome. Thanks for the
good job.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #5 from Frédéric Demians  ---
It doesn't work for me when your stylesheet is in opac-tmpl/xsl/. I have to put
it in opac-tmpl directly, and modify Repository.pm file to make it works. Could
you try on your side? I've seen in your screenshot you're working with
'localhost' as your server URL. It may come from there.

A remark: you introduce a new syspref OAI-PMH:CustomStylesheet. I think that
this kind of parameter belongs to the 'Extended Mode'. The YAML config file
could be used to link to a local stylesheet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #8 from Frédéric Demians  ---
(In reply to Tomás Cohen Arazi from comment #6)

> I'm using kohadevbox:ansible. I think the permissions (apache ones) on a
> regular dev/normal install have diverged from the packages. I'll take a look.

This part in apache conf is the culprit:


   Order deny,allow
   Deny from all


I will propose a patch fixing that, and using OAI server conf file to define
custom XSLT for web view.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #10 from Frédéric Demians  ---
Created attachment 46460
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46460=edit
Bug 15527 Custom stylesheet in extended mode

Add a parameter to YAML config file in order to specify a local XSLT
used style the XML returned by OAI Server. Some doc.

Move default XSLT from /opac-tmpl/xslt to
/opac-tmpl/bootstrap/css/OAI.xslt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #46434|0   |1
is obsolete||
  Attachment #46435|0   |1
is obsolete||
  Attachment #46438|0   |1
is obsolete||

--- Comment #9 from Frédéric Demians  ---
Created attachment 46459
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46459=edit
Bug 15527: Add a stylesheet for OAI-PMH to aid usability

This patch introduces an XSLT file grabbed from DSpace and a couple
css files.

To test:

- Point to your dev Koha's oai endpoint. For example:
  http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListMetadataFormats
=> FAIL: Look how ugly it is for humans.
- Apply this patch
- Reload
=> SUCCES: It is styled and provides really useful links to interact with
  the OAI server verbs.
- Sign off :-D

Sponsored-by: Universidad Empresarial Siglo 21

Signed-off-by: Frédéric Demians 
  Works as described. Nice looking.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #6 from Tomás Cohen Arazi  ---
(In reply to Frédéric Demians from comment #5)
> It doesn't work for me when your stylesheet is in opac-tmpl/xsl/. I have to
> put it in opac-tmpl directly, and modify Repository.pm file to make it
> works. Could you try on your side? I've seen in your screenshot you're
> working with 'localhost' as your server URL. It may come from there.

I'm using kohadevbox:ansible. I think the permissions (apache ones) on a
regular dev/normal install have diverged from the packages. I'll take a look.


> A remark: you introduce a new syspref OAI-PMH:CustomStylesheet. I think that
> this kind of parameter belongs to the 'Extended Mode'. The YAML config file
> could be used to link to a local stylesheet.

That's probably a good idea. I'll dig into it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 46430
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46430=edit
Proposed style

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 46435
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46435=edit
Bug 15527: (followup) Allow using custom stylesheets

This patch introduces a syspref to let users choose their own
XSLT stylesheets for the OAI-PMH front end.

Regards

Sponsored-by: Universidad Empresarial Siglo 21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 46434
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46434=edit
Bug 15527: Add a stylesheet for OAI-PMH to aid usability

This patch introduces an XSLT file grabbed from DSpace and a couple
css files.

To test:

- Point to your dev Koha's oai endpoint. For example:
  http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListMetadataFormats
=> FAIL: Look how ugly it is for humans.
- Apply this patch
- Reload
=> SUCCES: It is styled and provides really useful links to interact with
  the OAI server verbs.
- Sign off :-D

Sponsored-by: Universidad Empresarial Siglo 21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 46438
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46438=edit
Bug 15527: (followup) Avoid replacing spaces for non-breaking spaces

This causes the template not to wrap long lines correctly,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/