[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |In Discussion

--- Comment #7 from Marcel de Rooy  ---
Do we really want to replace verbose options in cmdline scripts by logger
calls?
The first comment speaks about debug prints, but you are removing the verbose
option too.
I would like to see some more consensus about doing so. Maybe ask the dev list?

In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Florent Mara  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #6 from Florent Mara  ---
Applied the following SQL to create a long overdue item and got the expected
log print out in stdout.

INSERT INTO biblio(frameworkcode, datecreated) values ('allo', '2016-05-17');
INSERT INTO biblioitems(biblionumber, volume) value ((SELECT biblionumber FROM
biblio WHERE frameworkcode = 'allo'), 'blah');
INSERT INTO items(biblionumber, biblioitemnumber, barcode) values (1, (SELECT
biblioitemnumber FROM biblioitems WHERE volume = 'blah'), 'barcode');
INSERT INTO items(biblionumber, biblioitemnumber, barcode) values (1, (SELECT
biblioitemnumber FROM biblioitems WHERE volume = 'blah'), 'latecode');
INSERT INTO borrowers(surname, address, city, branchcode, categorycode) values
('surname', 'address', 'city', 'CPL', 'B');


INSERT INTO issues (borrowernumber, itemnumber, date_due) values (
(SELECT borrowernumber FROM borrowers WHERE surname = 'surname'), 
(SELECT itemnumber FROM items WHERE barcode = 'barcode'), '2016-05-17'); 

INSERT INTO issues (borrowernumber, itemnumber, date_due) values (
(SELECT borrowernumber FROM borrowers WHERE surname = 'surname'), 
(SELECT itemnumber FROM items WHERE barcode = 'latecode'), '2015-07-17');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #46470|0   |1
is obsolete||

--- Comment #5 from Srdjan Jankovic  ---
Created attachment 51554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51554=edit
bug_15538: Koha::Logger in longoverdue.pl

* Removed --verbose option and replaved verbose prints with
  $logger->info()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Florent Mara  changed:

   What|Removed |Added

 CC||florent.m...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #4 from Florent Mara  ---
Failed to apply this patch. Appear to be due to Koha::Borrowers now being
superseded by Koha::Patrons. 

Applying: bug_15538: Koha::Logger in longoverdue.pl
Using index info to reconstruct a base tree...
M   misc/cronjobs/longoverdue.pl
Falling back to patching base and 3-way merge...
Auto-merging misc/cronjobs/longoverdue.pl
CONFLICT (content): Merge conflict in misc/cronjobs/longoverdue.pl
Failed to merge in the changes.
Patch failed at 0001 bug_15538: Koha::Logger in longoverdue.pl


Could you please provide a test plan to help validate this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

--- Comment #3 from Srdjan Jankovic  ---
(In reply to Frédéric Demians from comment #2)
> I can't make it work on master. Commit 347d12c41f9ebe may have broken
> Koha::Logger on master. For me, the logger is never instantiated. After
> modifying Koha::Logger to bypass conf file checking, I get a result in the
> OPAC log file.

Not sure why. I am supplying a conf file via LOG4PERL_CONF variable. What is
your situation?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #2 from Frédéric Demians  ---
I can't make it work on master. Commit 347d12c41f9ebe may have broken
Koha::Logger on master. For me, the logger is never instantiated. After
modifying Koha::Logger to bypass conf file checking, I get a result in the OPAC
log file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

--- Comment #1 from Srdjan Jankovic  ---
Created attachment 46470
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46470=edit
bug_15538: Koha::Logger in longoverdue.pl

* Removed --verbose option and replaved verbose prints with $logger->debug()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Srdjan Jankovic  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |srd...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/