[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #17 from Julian Maurice --- This bug does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jesse Weaver changed: What|Removed |Added CC||jwea...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #16 from Jesse Weaver --- Pushed to master, thanks for your work! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Katrin Fischer changed: What|Removed |Added Attachment #46697|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 46827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46827&action=edit [PASSED QA] Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #14 from Katrin Fischer --- Tricky! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #13 from Jonathan Druart --- (In reply to Katrin Fischer from comment #12) > Hm, dependencies are pushed to master, but patch doesn't apply for me: You must apply the last patch on bug 15295, not pushed to master yet. [SIGNED-OFF] Bug 15295: (follow-up) Koha::Libraries - Remove GetBranchesCount -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #12 from Katrin Fischer --- Hm, dependencies are pushed to master, but patch doesn't apply for me: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15568: Fix display default circ rules fatal: sha1 information is lacking or useless (admin/smart-rules.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What|Removed |Added Attachment #46685|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 46697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46697&action=edit [SIGNED-OFF] Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What|Removed |Added Blocks||15581 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 [Bug 15581] Add a circ rule to limit the auto renewals given a delay -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What|Removed |Added Depends on|14295 |15295 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14295 [Bug 14295] Add creation time, size and owner for uploaded files http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What|Removed |Added Depends on||14295 --- Comment #10 from Jonathan Druart --- Nick, I have moved the GetBranchesCount changes as a followup of bug 14295 (because there are 2 occurrences to fix). So I mark this fix as dependent on it and switch back to needs signoff. Sorry for the additional work. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14295 [Bug 14295] Add creation time, size and owner for uploaded files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What|Removed |Added Attachment #46664|0 |1 is obsolete|| Attachment #46665|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 46685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46685&action=edit Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #8 from Jonathan Druart --- I have submitted a patch on bug 14295 to remove the GetBranchesCount occurrences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com Attachment #46679|1 |0 is patch|| Attachment #46679|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #7 from Aleisha Amohia --- Sorry, I'm not really sure what I just did, but I was meant to be signing off on both patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #6 from Aleisha Amohia --- Created attachment 46679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46679&action=edit ^# Attachment to Bug 15568 - Circ rules are not displayed anymore [SIGNED-OFF] Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. Signed-off-by: Nick Clemens Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What|Removed |Added Attachment #46593|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 46664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46664&action=edit Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #5 from Nick Clemens --- Created attachment 46665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46665&action=edit Bug 15568 (Follow up) Replace call to C4::Branches::GetBranchesCount with Koha::Libraries->search->count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What|Removed |Added Attachment #46662|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Attachment #46593|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What|Removed |Added Attachment #46661|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 46662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46662&action=edit Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. This patch also replaces a call to the removed method C4::Branches::GetBranchesCoutn with a call to Koha::Libraries->search-count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What|Removed |Added Attachment #46593|0 |1 is obsolete|| --- Comment #2 from Nick Clemens --- Created attachment 46661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46661&action=edit Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. This patch also replaces a call to the removed method C4::Branches::GetBranchesCoutn with a call to Koha::Libraries->search-count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What|Removed |Added Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #1 from Jonathan Druart --- Created attachment 46593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46593&action=edit Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15568] Circ rules are not displayed anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
