[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16198


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198
[Bug 16198] Opac suggestions are broken if user is not logged in
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #23 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 Release. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15758


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758
[Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15407


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407
[Bug 15407] Move the patron categories related code to Koha::Patron::Categories
- part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|15758   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758
[Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47518|0   |1
is obsolete||
  Attachment #47519|0   |1
is obsolete||
  Attachment #47520|0   |1
is obsolete||
  Attachment #47521|0   |1
is obsolete||
  Attachment #47522|0   |1
is obsolete||
  Attachment #47523|0   |1
is obsolete||
  Attachment #47553|0   |1
is obsolete||
  Attachment #47701|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall  ---
Created attachment 47706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47706=edit
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1)

For consistency, the branchcodes method of Koha::LibraryCategory should be
named libraries.
At the moment, there is only one occurrence, in admin/branches.pl

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #21 from Kyle M Hall  ---
Created attachment 47712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47712=edit
Bug 15629: Fix tests - Koha::Library does not have ->categories but
->get_categories

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #17 from Kyle M Hall  ---
Created attachment 47708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47708=edit
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (3)

C4::Branch::GetBranchesInCategory is not used anymore and can be
removed.

Test plan:
  git grep GetBranchesInCategory
should not return any result.

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #18 from Kyle M Hall  ---
Created attachment 47709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47709=edit
Bug 15629: Koha::Libraries - Remove GetBranchDetail

C4::Branch::GetBranchDetail retrieved library infos, it could be easily
replaced with Koha::Libraries->find

When this change needs other big changes, the unblessed method is
called, to manipulate a hashref (as before) instead of a Koha::Library
object (for instance when $library is sent to GetPreparedLetter).

Test plan:
1/ Print a basket group, the library names should be correctly
displayed.
2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED
notice will be generated (focus on the library name)
3/ Edit a patron and change his/her library
4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and
have a look at the generated notices
5/ Same of overdues notices
6/ Set IndependentBranches and use a non superlibrarian user to place a
hold. The "pickup at" should be correctly filled.

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #16 from Kyle M Hall  ---
Created attachment 47707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47707=edit
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (2)

C4::Branch::GetBranchesInCategory can be replaced with
Koha::LibraryCategory->libraries

Test plan:
1/ Define some 1+ group of libraries with 1+ libraries each
2/ Go on the advanced search (OPAC and Staff) and select a group of
libraries
3/ The result should be consistent and only include record from these
libraries

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #20 from Kyle M Hall  ---
Created attachment 47711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47711=edit
Bug 15629: Koha::Libraries - Remove GetBranchInfo

C4::Branch::GetBranchInfo was only used once in opac/opac-suggestions.pl
The occurrence can easily be replaced by a call to Koha::Libraries->find

Test plan:
1/ Create a suggestion for library A
2/ Enable OPACViewOthersSuggestions
3/ Use a patron from library B to see the suggestions
4/ The "Suggested for" value should be correctly filled with the library
A name.

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #19 from Kyle M Hall  ---
Created attachment 47710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47710=edit
Bug 15629: Koha::Libraries - Remove ModBranch

This subroutine was only used in tests to add/update a library.

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #22 from Kyle M Hall  ---
Created attachment 47713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47713=edit
Bug 15629 [QA Followup]

* Use ->id instead of ->branchcode when possible to eliminate use of that
nomenclature
* Fix bad use of ->branchcode to ->{branchcode} for unblessed hashref  version
of Koha::Library

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #14 from Kyle M Hall  ---
Created attachment 47701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47701=edit
Bug 15629 [QA Followup]

* Use ->id instead of ->branchcode when possible to eliminate use of that
nomenclature
* Fix bad use of ->branchcode to ->{branchcode} for unblessed hashref  version
of Koha::Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #47522|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #13 from Jonathan Druart  
---
Created attachment 47553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47553=edit
Bug 15629: Fix tests - Koha::Library does not have ->categories but
->get_categories

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Owen Leonard  changed:

   What|Removed |Added

  Attachment #47001|0   |1
is obsolete||

--- Comment #11 from Owen Leonard  ---
Created attachment 47522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47522=edit
[SIGNED-OFF] Bug 15629: Koha::Libraries - Remove ModBranch

This subroutine was only used in tests to add/update a library.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Owen Leonard  changed:

   What|Removed |Added

  Attachment #46997|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 47518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47518=edit
[SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1)

For consistency, the branchcodes method of Koha::LibraryCategory should be
named libraries.
At the moment, there is only one occurrence, in admin/branches.pl

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Owen Leonard  changed:

   What|Removed |Added

  Attachment #47000|0   |1
is obsolete||

--- Comment #10 from Owen Leonard  ---
Created attachment 47521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47521=edit
[SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchDetail

C4::Branch::GetBranchDetail retrieved library infos, it could be easily
replaced with Koha::Libraries->find

When this change needs other big changes, the unblessed method is
called, to manipulate a hashref (as before) instead of a Koha::Library
object (for instance when $library is sent to GetPreparedLetter).

Test plan:
1/ Print a basket group, the library names should be correctly
displayed.
2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED
notice will be generated (focus on the library name)
3/ Edit a patron and change his/her library
4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and
have a look at the generated notices
5/ Same of overdues notices
6/ Set IndependentBranches and use a non superlibrarian user to place a
hold. The "pickup at" should be correctly filled.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Owen Leonard  changed:

   What|Removed |Added

  Attachment #46999|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 47520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47520=edit
[SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (3)

C4::Branch::GetBranchesInCategory is not used anymore and can be
removed.

Test plan:
  git grep GetBranchesInCategory
should not return any result.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Owen Leonard  changed:

   What|Removed |Added

  Attachment #46998|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Created attachment 47519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47519=edit
[SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (2)

C4::Branch::GetBranchesInCategory can be replaced with
Koha::LibraryCategory->libraries

Test plan:
1/ Define some 1+ group of libraries with 1+ libraries each
2/ Go on the advanced search (OPAC and Staff) and select a group of
libraries
3/ The result should be consistent and only include record from these
libraries

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Owen Leonard  changed:

   What|Removed |Added

  Attachment #47522|0   |1
is obsolete||

--- Comment #12 from Owen Leonard  ---
Created attachment 47523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47523=edit
[SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchInfo

C4::Branch::GetBranchInfo was only used once in opac/opac-suggestions.pl
The occurrence can easily be replaced by a call to Koha::Libraries->find

Test plan:
1/ Create a suggestion for library A
2/ Enable OPACViewOthersSuggestions
3/ Use a patron from library B to see the suggestions
4/ The "Suggested for" value should be correctly filled with the library
A name.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Owen Leonard  changed:

   What|Removed |Added

  Attachment #47002|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #2 from Jonathan Druart  
---
Created attachment 46998
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46998=edit
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (2)

C4::Branch::GetBranchesInCategory can be replaced with
Koha::LibraryCategory->libraries

Test plan:
1/ Define some 1+ group of libraries with 1+ libraries each
2/ Go on the advanced search (OPAC and Staff) and select a group of
libraries
3/ The result should be consistent and only include record from these
libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #5 from Jonathan Druart  
---
Created attachment 47001
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47001=edit
Bug 15629: Koha::Libraries - Remove ModBranch

This subroutine was only used in tests to add/update a library.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #4 from Jonathan Druart  
---
Created attachment 47000
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47000=edit
Bug 15629: Koha::Libraries - Remove GetBranchDetail

C4::Branch::GetBranchDetail retrieved library infos, it could be easily
replaced with Koha::Libraries->find

When this change needs other big changes, the unblessed method is
called, to manipulate a hashref (as before) instead of a Koha::Library
object (for instance when $library is sent to GetPreparedLetter).

Test plan:
1/ Print a basket group, the library names should be correctly
displayed.
2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED
notice will be generated (focus on the library name)
3/ Edit a patron and change his/her library
4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and
have a look at the generated notices
5/ Same of overdues notices
6/ Set IndependentBranches and use a non superlibrarian user to place a
hold. The "pickup at" should be correctly filled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #1 from Jonathan Druart  
---
Created attachment 46997
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46997=edit
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1)

For consistency, the branchcodes method of Koha::LibraryCategory should be
named libraries.
At the moment, there is only one occurrence, in admin/branches.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #6 from Jonathan Druart  
---
Created attachment 47002
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47002=edit
Bug 15629: Koha::Libraries - Remove GetBranchInfo

C4::Branch::GetBranchInfo was only used once in opac/opac-suggestions.pl
The occurrence can easily be replaced by a call to Koha::Libraries->find

Test plan:
1/ Create a suggestion for library A
2/ Enable OPACViewOthersSuggestions
3/ Use a patron from library B to see the suggestions
4/ The "Suggested for" value should be correctly filled with the library
A name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

--- Comment #3 from Jonathan Druart  
---
Created attachment 46999
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46999=edit
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (3)

C4::Branch::GetBranchesInCategory is not used anymore and can be
removed.

Test plan:
  git grep GetBranchesInCategory
should not return any result.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/