[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Nicole C. Engard changed: What|Removed |Added CC||a...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #15 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #14) > (In reply to David Cook from comment #13) > > > > +use Module::Pluggable search_path => ['Koha::Plugin'], except => > > > qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/; > > > > This seems suboptimal... since any plugin with additional packages would > > need an exception. > > Have the same feeling when I see these lines.. I agree. I'm sure there is a better solution! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- (In reply to David Cook from comment #13) > > +use Module::Pluggable search_path => ['Koha::Plugin'], except => > > qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/; > > This seems suboptimal... since any plugin with additional packages would > need an exception. Have the same feeling when I see these lines.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #13 from David Cook --- Comment on attachment 49788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49788 Bug 15630 - Make Edifact module pluggable Review of attachment 49788: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15630&attachment=49788) - ::: Koha/Plugins.pm @@ +20,4 @@ > use Modern::Perl; > > use Module::Load::Conditional qw(can_load); > +use Module::Pluggable search_path => ['Koha::Plugin'], except => > qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/; This seems suboptimal... since any plugin with additional packages would need an exception. Wouldn't it make more sense to use "only" to only find plugins like ^Koha::Plugin::Com::CompanyName::PluginName$. I suppose it might be too late for that now as there's any number of plugins that can be allowed so perhaps one does have to only use exceptions from now on... I'm thinking of making a plugin, but I'll probably just use a different namespace like Local::PluginName::Submodules... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #12 from Kyle M Hall --- (In reply to Jonathan Druart from comment #11) > This patch makes the t/db_dependent/TestBuilder.t tests fail: > > t/db_dependent/TestBuilder.t .. 3/41 DBD::mysql::st execute failed: Cannot > delete or update a parent row: a foreign key constraint fails > (`koha_empty`.`edifact_messages`, CONSTRAINT `emfk_basketno` FOREIGN KEY > (`basketno`) REFERENCES `aqbasket` (`basketno`)) [for Statement "DELETE FROM > `aqbasket` WHERE ( `basketno` = ? )" with ParamValues: 0='13'] at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834. > > the foreign keys don't not have a ON * CASCADE clause. Filed bug 16354 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Kyle M Hall changed: What|Removed |Added Blocks||16354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16354 [Bug 16354] TestBuilder.t fails due to key constraints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #11 from Jonathan Druart --- This patch makes the t/db_dependent/TestBuilder.t tests fail: t/db_dependent/TestBuilder.t .. 3/41 DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_empty`.`edifact_messages`, CONSTRAINT `emfk_basketno` FOREIGN KEY (`basketno`) REFERENCES `aqbasket` (`basketno`)) [for Statement "DELETE FROM `aqbasket` WHERE ( `basketno` = ? )" with ParamValues: 0='13'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834. the foreign keys don't not have a ON * CASCADE clause. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #10 from Brendan Gallagher --- *Manually added in the missing updatedatabase.pl for .plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > aqbooksellers.plugin has not been added to existing installations vendor_edi_accounts.plugin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- aqbooksellers.plugin has not been added to existing installations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! RM note - I am now running the dbix schema update for both this and bug 7736 at the same time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Nice enhancement, should make things much more extensible.. Go forth :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Martin Renvoize changed: What|Removed |Added Attachment #49271|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 49788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49788&action=edit Bug 15630 - Make Edifact module pluggable Koha's EDIFACT module works great for many European vendors, but does not work will for US vendors, which have a much different interpretation of 'standard'. In fact, each vendor may require different arrangements of values in EDIFACT messages. It would be impossible to encompass all these requirements within Koha's EDIFACT module itself. Instead, we should allow the module to be pluggable, so versions of the module can be developed for vendors that require EDIFACT messages that don't conform to the standard set by Koha's EDIFACT module. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable Koha plugins 4) Install the Edifact stub plugin available at https://github.com/bywatersolutions/koha-plugin-edifact-stub 5) Edit the EDI Vendor account, assign the plugin to a Vendor EDI account 6) Test EDI functionality ( ORDER, INVOICE ), there should be no errors or changes to the EDIFACT message input or output Signed-off-by: Jason DeShaw Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Kyle M Hall changed: What|Removed |Added Attachment #47026|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 49270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49270&action=edit Bug 15630 - Make Edifact module pluggable Koha's EDIFACT module works great for many European vendors, but does not work will for US vendors, which have a much different interpretation of 'standard'. In fact, each vendor may require different arrangements of values in EDIFACT messages. It would be impossible to encompass all these requirements within Koha's EDIFACT module itself. Instead, we should allow the module to be pluggable, so versions of the module can be developed for vendors that require EDIFACT messages that don't conform to the standard set by Koha's EDIFACT module. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable Koha plugins 4) Install the Edifact stub plugin available at https://github.com/bywatersolutions/koha-plugin-edifact-stub 5) Edit the EDI Vendor account, assign the plugin to a Vendor EDI account 6) Test EDI functionality ( ORDER, INVOICE ), there should be no errors or changes to the EDIFACT message input or output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Nicole C. Engard changed: What|Removed |Added Attachment #49270|0 |1 is obsolete|| --- Comment #4 from Nicole C. Engard --- Created attachment 49271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49271&action=edit Bug 15630 - Make Edifact module pluggable Koha's EDIFACT module works great for many European vendors, but does not work will for US vendors, which have a much different interpretation of 'standard'. In fact, each vendor may require different arrangements of values in EDIFACT messages. It would be impossible to encompass all these requirements within Koha's EDIFACT module itself. Instead, we should allow the module to be pluggable, so versions of the module can be developed for vendors that require EDIFACT messages that don't conform to the standard set by Koha's EDIFACT module. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable Koha plugins 4) Install the Edifact stub plugin available at https://github.com/bywatersolutions/koha-plugin-edifact-stub 5) Edit the EDI Vendor account, assign the plugin to a Vendor EDI account 6) Test EDI functionality ( ORDER, INVOICE ), there should be no errors or changes to the EDIFACT message input or output Signed-off-by: Jason DeShaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Kyle M Hall changed: What|Removed |Added Attachment #47025|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 47026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47026&action=edit Bug 15630 - Make Edifact module pluggable Koha's EDIFACT module works great for many European vendors, but does not work will for US vendors, which have a much different interpretation of 'standard'. In fact, each vendor may require different arrangements of values in EDIFACT messages. It would be impossible to encompass all these requirements within Koha's EDIFACT module itself. Instead, we should allow the module to be pluggable, so versions of the module can be developed for vendors that require EDIFACT messages that don't conform to the standard set by Koha's EDIFACT module. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable Koha plugins 4) Install the Edifact stub plugin available at https://github.com/bywatersolutions/koha-plugin-edifact-stub 5) Edit the EDI Vendor account, assign the plugin to a Vendor EDI account 6) Test EDI functionality ( ORDER, INVOICE ), there should be no errors or changes to the EDIFACT message input or output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #1 from Kyle M Hall --- Created attachment 47025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47025&action=edit Bug 15630 - Make Edifact module pluggable Koha's EDIFACT module works great for many European vendors, but does not work will for US vendors, which have a much different interpretation of 'standard'. In fact, each vendor may require different arrangements of values in EDIFACT messages. It would be impossible to encompass all these requirements within Koha's EDIFACT module itself. Instead, we should allow the module to be pluggable, so versions of the module can be developed for vendors that require EDIFACT messages that don't conform to the standard set by Koha's EDIFACT module. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable Koha plugins 4) Install the Edifact stub plugin available at https://github.com/bywatersolutions/koha-plugin-edifact-stub 5) Edit the EDI Vendor account, assign the plugin to a Vendor EDI account 6) Test EDI functionality ( ORDER, INVOICE ), there should be no errors or changes to the EDIFACT message input or output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com, ||nic...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Kyle M Hall changed: What|Removed |Added Depends on||7736 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15630] Make Edifact module pluggable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
