[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67039|0   |1
is obsolete||

--- Comment #26 from Alex Buckley  ---
Created attachment 67176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67176=edit
Bug 15752: QA followup - inform user that patron was automatically switched

Test plan:

1) Start checking out to some patron - there should be no message about
auto switching
2) read the another patrons card - note the patron is switched and there
is a message about it at top of the main page content

Followed test plan, patch worked as described. Passed QA test tool
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67038|0   |1
is obsolete||

--- Comment #25 from Alex Buckley  ---
Created attachment 67175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67175=edit
Bug 15752: QA followup - search for patrons only if param barcode is defined

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67037|0   |1
is obsolete||

--- Comment #24 from Alex Buckley  ---
Created attachment 67174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67174=edit
Bug 15752 - Automatically switch patron during circulation

With this syspref enabled scanning a patron barcode into the item
barcode field during circulation will redirect you to the patron's
circulation page.

This allows circulation with only a barcode scanner.

Testing:

- Enable the AutoSwitchPatron syspref
- Navigate to a patron's check out screen
- Enter a patron barcode into the "Enter item barcode" field

Result
- Browser should be redirected to the entered patron

Signed-off-by: Joel 

Followed test plan, patch works as described
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #23 from Josef Moravec  ---
(In reply to Alex Buckley from comment #19)
> Hi Josef
> 
> Sorry but failed in the running of QA test tools:
> 
>  OK   circ/circulation.pl
>OK   critic
>OK   forbidden patterns
>OK   git manipulation
>OK   pod
>OK   spelling
>OK   valid
> 
>  OK   installer/data/mysql/sysprefs.sql
>OK   git manipulation
>OK   semicolon
>OK   sysprefs_order
> 
>  FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>OK   forbidden patterns
>OK   git manipulation
>OK   spelling
>OK   tt_valid
>FAIL valid_template
> 
> 
> After that is fixed up I will be happy to test and signoff as the patches
> worked as described in the test plans

Did you have any conflicts applying the patches?

For me it passes the QA test tools...

Anyway, I rebased the patches on master and fixed commit message on 3rd patch
(wrong bug number). Could you try it again?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #22 from Josef Moravec  ---
Created attachment 67039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67039=edit
Bug 15752: QA followup - inform user that patron was automatically switched

Test plan:

1) Start checking out to some patron - there should be no message about
auto switching
2) read the another patrons card - note the patron is switched and there
is a message about it at top of the main page content

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #21 from Josef Moravec  ---
Created attachment 67038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67038=edit
Bug 15752: QA followup - search for patrons only if param barcode is defined

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Josef Moravec  changed:

   What|Removed |Added

  Attachment #66175|0   |1
is obsolete||
  Attachment #66176|0   |1
is obsolete||
  Attachment #66177|0   |1
is obsolete||

--- Comment #20 from Josef Moravec  ---
Created attachment 67037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67037=edit
Bug 15752 - Automatically switch patron during circulation

With this syspref enabled scanning a patron barcode into the item
barcode field during circulation will redirect you to the patron's
circulation page.

This allows circulation with only a barcode scanner.

Testing:

- Enable the AutoSwitchPatron syspref
- Navigate to a patron's check out screen
- Enter a patron barcode into the "Enter item barcode" field

Result
- Browser should be redirected to the entered patron

Signed-off-by: Joel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|Needs Signoff   |Failed QA

--- Comment #19 from Alex Buckley  ---
Hi Josef

Sorry but failed in the running of QA test tools:

 OK circ/circulation.pl
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   OK valid

 OK installer/data/mysql/sysprefs.sql
   OK git manipulation
   OK semicolon
   OK sysprefs_order

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   FAIL   valid_template


After that is fixed up I will be happy to test and signoff as the patches
worked as described in the test plans

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #17 from Josef Moravec  ---
Created attachment 66176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66176=edit
Bug 15752: QA followup - search for patrons only if param barcode is defined

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57015|0   |1
is obsolete||

--- Comment #16 from Josef Moravec  ---
Created attachment 66175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66175=edit
Bug 15752 - Automatically switch patron during circulation

With this syspref enabled scanning a patron barcode into the item
barcode field during circulation will redirect you to the patron's
circulation page.

This allows circulation with only a barcode scanner.

Testing:

- Enable the AutoSwitchPatron syspref
- Navigate to a patron's check out screen
- Enter a patron barcode into the "Enter item barcode" field

Result
- Browser should be redirected to the entered patron

Signed-off-by: Joel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #18 from Josef Moravec  ---
Created attachment 66177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66177=edit
Bug 17572: QA followup - inform user that patron was automatically switched

Test plan:

1) Start checking out to some patron - there should be no message about
auto switching
2) read the another patrons card - note the patron is switched and there
is a message about it at top of the main page content

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #15 from Jonathan Druart  
---
>From the Koha log file:

circulation.pl: CGI::param called in list context from package main line 83,
this can lead to vulnerabilities. See the warning in "Fetching the value or
values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.,
referer: http://pro.kohadev.vm/cgi-bin/koha/circ/circulation-home.pl

circulation.pl: Odd number of elements in anonymous hash at
/home/vagrant/kohaclone/circ/circulation.pl line 83., referer:
http://pro.kohadev.vm/cgi-bin/koha/circ/circulation-home.pl

The search should only be done if the barcode field has been filled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #14 from Jonathan Druart  
---
Should not we add a message box if the switch happened?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55953|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 57015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57015=edit
Bug 15752 - Automatically switch patron during circulation

With this syspref enabled scanning a patron barcode into the item
barcode field during circulation will redirect you to the patron's
circulation page.

This allows circulation with only a barcode scanner.

Testing:

- Enable the AutoSwitchPatron syspref
- Navigate to a patron's check out screen
- Enter a patron barcode into the "Enter item barcode" field

Result
- Browser should be redirected to the entered patron

Signed-off-by: Joel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55953|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Jonathan Druart  changed:

   What|Removed |Added

   Severity|new feature |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #55953|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com
 Status|Needs Signoff   |Signed Off

--- Comment #12 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Joel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Fred  changed:

   What|Removed |Added

 CC||mediatheque.di...@gmail.com

--- Comment #11 from Fred  ---
Hi,
For autoswitch, in my library we use this JavaScript code (thanks to S.D.):
/
$(document).ready(function ()
{
if (window.location.href.indexOf("cgi-bin/koha/circ/circulation.pl") > -1)
if ($("#circ_impossible ul li").html())
{
 var message = $("#circ_impossible ul li").html(); 
 var terme = message.split(' ');
 var cb= terme[9];
 var n= cb.length;}
if (n==5)
if (check_numerique(cb) == true)
{$("#patronsearch #findborrower").val(cb);
$("#patronsearch #autocsubmit").click();
}
else {return false;}
function check_numerique(input){
return !isNaN(input);
}

}


This present 1 or 2 seconds the usual yellow message : Barcode not found

we are satisfied with this solution for 1 year. Is it possible to make the same
timing in this patch ?

Thanks,
Fred

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #10 from Marc Véron  ---
(In reply to Katrin Fischer from comment #8)
> I think this could speed up things at the desk, but I have one worry: What
> happens when there is an overlap between item barcodes and patron
> cardnumbers? 
> 
> Maybe we should show a warning message in that case, asking if the number
> was one or the other before proceeding.

I think in the case of overlapping barcodes the feature should be turned off
anyway, as
the explanation for syspref AutoSwitchPatron says:

"This should not be enabled if you have overlapping patron and book barcodes."

If in the future a library with overlapping barcodes wants to have this
feature, they can ask for or provide an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #9 from Katrin Fischer  ---
Hm, if this is to avoid using the mouse to switch to the check-in field - have
you seen that there are keyboard shortcuts for this too? From the circulation
start page help:

- jump to the catalog search with Alt+Q
- jump to the checkout with Alt+U (this will not work for Mac user)
- jump to the checkin with Alt+R

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #8 from Katrin Fischer  ---
I think this could speed up things at the desk, but I have one worry: What
happens when there is an overlap between item barcodes and patron cardnumbers? 

Maybe we should show a warning message in that case, asking if the number was
one or the other before proceeding.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |c...@pennmanor.net
   |ity.org |

--- Comment #7 from Jonathan Druart  
---
I'd like to get feedback from others to know if it is a good behaviour to
implement before fixing it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #6 from Marc Véron  ---
Hi Jonathan,
With patch applied I can not open the checkout page e.g. from the link "My
checkouts" or the link "Check out" at the left hand of a patron detail page.

To make it work, I changed the following line:
if (C4::Context->preference("AutoSwitchPatron") ) {
to:
if (C4::Context->preference("AutoSwitchPatron") && $query->param('barcode') ) {

With this change, the patch behaves as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #47716|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 55953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55953=edit
Bug 15752 - Automatically switch patron during circulation

With this syspref enabled scanning a patron barcode into the item
barcode field during circulation will redirect you to the patron's
circulation page.

This allows circulation with only a barcode scanner.

Testing:

- Enable the AutoSwitchPatron syspref
- Navigate to a patron's check out screen
- Enter a patron barcode into the "Enter item barcode" field

Result
- Browser should be redirected to the entered patron

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Easy conflict fixed, atomic .pl moved to .sql

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron  ---
Patch does no longer apply.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Nick Clemens  ---
Hi Chad,

Patch works as expected but atomicupdate file should be a *.sql file instead of
a *.pl file :-)

Fix that and I can retest/signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Nicole C. Engard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch patron during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #1 from c...@pennmanor.net ---
Created attachment 47716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47716=edit
Bug 15752 - Automatically switch patron during circulation

With this syspref enabled scanning a patron barcode into the item
barcode field during circulation will redirect you to the patron's
circulation page.

This allows circulation with only a barcode scanner.

Testing:

- Enable the AutoSwitchPatron syspref
- Navigate to a patron's check out screen
- Enter a patron barcode into the "Enter item barcode" field

Result
- Browser should be redirected to the entered patron

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/