[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||22267


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22267
[Bug 22267] Warns in logs when adding and editing descriptions to batches
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #62 from Katrin Fischer  ---
*** Bug 5169 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #61 from Martin Renvoize  ---
Enhancement will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #60 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #59)
> Created attachment 81086 [details] [review]
> Bug 15766: Update tests
> 
> Signed-off-by: Jonathan Druart 

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #81084|0   |1
is obsolete||

--- Comment #59 from Jonathan Druart  
---
Created attachment 81086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81086=edit
Bug 15766: Update tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #58 from Nick Clemens  ---
Created attachment 81084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81084=edit
Bug 15766: Update tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #57 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #56 from Jonathan Druart  
---
Created attachment 81070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81070=edit
Bug 15766: Fix incorrect GROUP BY

'koha_kohadev.creator_batches.description' isn't in GROUP BY

Fix t/db_dependent/Creators/Lib.t if strict sql modes is on

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79845|0   |1
is obsolete||

--- Comment #54 from Katrin Fischer  ---
Created attachment 80450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80450=edit
Bug 15766: (follow-up) Correct merge errors

This patch corrects some problems applying this on current master and
removes an old merge conflict marker.

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79842|0   |1
is obsolete||

--- Comment #53 from Katrin Fischer  ---
Created attachment 80449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80449=edit
Bug 15766: (follow-up) Hide description field if the batch is empty

Because if it's empty, it hasn't actually been created yet. Hiding the
field prevents a lot of errors

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79846|0   |1
is obsolete||

--- Comment #55 from Katrin Fischer  ---
Created attachment 80451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80451=edit
Bug 15766: (follow-up) Fixing layout of description button

This patch moves the 'Save' button to the toolbar as suggested. The
description textbox and 'Save' button are hidden if the batch is new and
appears when items are added.

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79840|0   |1
is obsolete||

--- Comment #51 from Katrin Fischer  ---
Created attachment 80447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80447=edit
Bug 15766: (follow-up) Making 'Save description' link a button

For consistency's sake in response to Comment 17.

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79841|0   |1
is obsolete||

--- Comment #52 from Katrin Fischer  ---
Created attachment 80448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80448=edit
Bug 15766: (follow-up) Save description link as button on patroncard side

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79839|0   |1
is obsolete||

--- Comment #50 from Katrin Fischer  ---
Created attachment 80446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80446=edit
Bug 15766: Adding descriptions to patron card batches

This patch adds a 'description' column to the creator_batches table. The
description for a batch can be added and updated using ajax.

To test:
1) Apply patch and update database (you will have to restart memcached)
2) Go to Tools -> Patron card creator -> Manage batches
3) There should now be a Description column next to Batch ID. This
will be empty (as none of the batches have descriptions yet)
4) Click Edit for any batch
5) Notice new Batch description text field. Enter a description for
the batch in here and click Save description. Some text should show
saying the description was saved.
6) If you go back to the manage batches page, the description should
now show under the Description column.
7) Go to Tools -> Label Creator -> Manage labels
8) Repeat steps 3 to 6

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #49 from Katrin Fischer  ---
Not do disagree with our RM, but I think I liked the button better next to the
field as the behavior is a bit uncommon and it would serve as a visual reminder
that you have to save this separately. But NOT blocker!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Owen Leonard  changed:

   What|Removed |Added

  Attachment #79843|0   |1
is obsolete||
  Attachment #79844|0   |1
is obsolete||

--- Comment #47 from Owen Leonard  ---
Created attachment 79845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79845=edit
Bug 15766: (follow-up) Correct merge errors

This patch corrects some problems applying this on current master and
removes an old merge conflict marker.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #48 from Owen Leonard  ---
Created attachment 79846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79846=edit
Bug 15766: (follow-up) Fixing layout of description button

This patch moves the 'Save' button to the toolbar as suggested. The
description textbox and 'Save' button are hidden if the batch is new and
appears when items are added.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #46 from Owen Leonard  ---
Patches rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #45 from Owen Leonard  ---
Created attachment 79844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79844=edit
Bug 15766: (follow-up) Fixing layout of description button

This patch moves the 'Save' button to the toolbar as suggested. The
description textbox and 'Save' button are hidden if the batch is new and
appears when items are added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #44 from Owen Leonard  ---
Created attachment 79843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79843=edit
Bug 15766: (follow-up) Correct merge errors

This patch corrects some problems applying this on current master and
removes an old merge conflict marker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #43 from Owen Leonard  ---
Created attachment 79842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79842=edit
Bug 15766: (follow-up) Hide description field if the batch is empty

Because if it's empty, it hasn't actually been created yet. Hiding the
field prevents a lot of errors

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #42 from Owen Leonard  ---
Created attachment 79841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79841=edit
Bug 15766: (follow-up) Save description link as button on patroncard side

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #41 from Owen Leonard  ---
Created attachment 79840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79840=edit
Bug 15766: (follow-up) Making 'Save description' link a button

For consistency's sake in response to Comment 17.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Owen Leonard  changed:

   What|Removed |Added

  Attachment #75213|0   |1
is obsolete||
  Attachment #75214|0   |1
is obsolete||
  Attachment #75215|0   |1
is obsolete||
  Attachment #75216|0   |1
is obsolete||
  Attachment #75715|0   |1
is obsolete||
  Attachment #75843|0   |1
is obsolete||

--- Comment #40 from Owen Leonard  ---
Created attachment 79839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79839=edit
Bug 15766: Adding descriptions to patron card batches

This patch adds a 'description' column to the creator_batches table. The
description for a batch can be added and updated using ajax.

To test:
1) Apply patch and update database (you will have to restart memcached)
2) Go to Tools -> Patron card creator -> Manage batches
3) There should now be a Description column next to Batch ID. This
will be empty (as none of the batches have descriptions yet)
4) Click Edit for any batch
5) Notice new Batch description text field. Enter a description for
the batch in here and click Save description. Some text should show
saying the description was saved.
6) If you go back to the manage batches page, the description should
now show under the Description column.
7) Go to Tools -> Label Creator -> Manage labels
8) Repeat steps 3 to 6

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #39 from Aleisha Amohia  ---
Created attachment 75843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75843=edit
Bug 15766: [FOLLOW-UP] Fixing layout of description button

This patch moves the 'Save' button to the toolbar as suggested. The
description textbox and 'Save' button are hidden if the batch is new and
appears when items are added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #38 from Aleisha Amohia  ---
(In reply to Owen Leonard from comment #37)
> Although this was marked "Failed QA," it looks like it is ready for testing
> since there are no QA comments posted after the latest patches.

Hey Owen, I am currently working on Nick and Katrin's comments so will set to
Assigned until my follow-up patch is ready.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #37 from Owen Leonard  ---
Although this was marked "Failed QA," it looks like it is ready for testing
since there are no QA comments posted after the latest patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #36 from Owen Leonard  ---
Created attachment 75715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75715=edit
Bug 15766: (follow-up) Correct merge errors

This patch corrects some problems applying this on current master and
removes an old merge conflict marker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68362|0   |1
is obsolete||

--- Comment #35 from Aleisha Amohia  ---
Created attachment 75216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75216=edit
Bug 15766: [FOLLOW-UP] Hide description field if the batch is empty

because if it's empty, it hasn't actually been created yet. Hiding the
field prevents a lot of errors

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68361|0   |1
is obsolete||

--- Comment #34 from Aleisha Amohia  ---
Created attachment 75215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75215=edit
Bug 15766: [FOLLOW-UP] Save description link as button on patroncard side

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68359|0   |1
is obsolete||

--- Comment #32 from Aleisha Amohia  ---
Created attachment 75213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75213=edit
Bug 15766: Adding descriptions to patron card batches

This patch adds a 'description' column to the creator_batches table. The
description for a batch can be added and updated using ajax.

To test:
1) Apply patch and update database (you will have to restart memcached)
2) Go to Tools -> Patron card creator -> Manage batches
3) There should now be a Description column next to Batch ID. This
will be empty (as none of the batches have descriptions yet)
4) Click Edit for any batch
5) Notice new Batch description text field. Enter a description for
the batch in here and click Save description. Some text should show
saying the description was saved.
6) If you go back to the manage batches page, the description should
now show under the Description column.
7) Go to Tools -> Label Creator -> Manage labels
8) Repeat steps 3 to 6

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68360|0   |1
is obsolete||

--- Comment #33 from Aleisha Amohia  ---
Created attachment 75214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75214=edit
Bug 15766: [FOLLOW-UP] Making 'Save description' link a button

For consistency's sake in response to Comment 17.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #31 from Katrin Fischer  ---
Aleisha, can you please take a look at Nicks and my comments? Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com,
   ||oleon...@myacpl.org

--- Comment #30 from Nick Clemens  ---
I am not sure about this workflow either, I am the one responsible for batches
not existing until you add an item I think, so feel a bit responsible :-)

I would suggest 
1 - move the 'Save description' button into the toolbar with the other buttons
2 - disable it until an item is added with a tooltip 'Add an item to create the
batch and save description'
3 - Have the 'Add item' button also trigger an update of the description if it
has been changed

Would that make sense Aleisha?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #29 from Katrin Fischer  ---
Signing off, the errors I encountered are all fixed.

Usability of this still feels a bit awkward and could be improved in the
future. 2 things:

- Adding a description is only possible after adding the first items. This
might be irritating to some.
- When you enter a description but forget to save and then add items, the
description is emptied out. The separation of the forms could be visually more
clear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #68282|0   |1
is obsolete||

--- Comment #28 from Katrin Fischer  ---
Created attachment 68362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68362=edit
Bug 15766: [FOLLOW-UP] Hide description field if the batch is empty

because if it's empty, it hasn't actually been created yet. Hiding the
field prevents a lot of errors

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66515|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 68359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68359=edit
Bug 15766: Adding descriptions to patron card batches

This patch adds a 'description' column to the creator_batches table. The
description for a batch can be added and updated using ajax.

To test:
1) Apply patch and update database (you will have to restart memcached)
2) Go to Tools -> Patron card creator -> Manage batches
3) There should now be a Description column next to Batch ID. This
will be empty (as none of the batches have descriptions yet)
4) Click Edit for any batch
5) Notice new Batch description text field. Enter a description for
the batch in here and click Save description. Some text should show
saying the description was saved.
6) If you go back to the manage batches page, the description should
now show under the Description column.
7) Go to Tools -> Label Creator -> Manage labels
8) Repeat steps 3 to 6

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67862|0   |1
is obsolete||

--- Comment #27 from Katrin Fischer  ---
Created attachment 68361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68361=edit
Bug 15766: [FOLLOW-UP] Save description link as button on patroncard side

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67305|0   |1
is obsolete||

--- Comment #26 from Katrin Fischer  ---
Created attachment 68360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68360=edit
Bug 15766: [FOLLOW-UP] Making 'Save description' link a button

For consistency's sake in response to Comment 17.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #24 from Aleisha Amohia  ---
Created attachment 68282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68282=edit
Bug 15766: [FOLLOW-UP] Hide description field if the batch is empty

because if it's empty, it hasn't actually been created yet. Hiding the
field prevents a lot of errors

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #23 from Aleisha Amohia  ---
(In reply to Katrin Fischer from comment #22)
> Hi Aleisha,
> 
> I am sorry, but I am still having the same troubles:
> 
> - No feedback on pushing the button
> - Errors in the logs for patron card creator:
> 
> Can't use string ("-2") as a HASH ref while "strict refs" in use at
> /home/vagrant/kohaclone/svc/creator_batches line 65.
> DBD::mysql::st execute failed: called with 4 bind variables when 5 are
> needed [for Statement "INSERT INTO creator_batches (batch_id, description,
> item_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues:
> 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at
> /home/vagrant/kohaclone/C4/Creators/Batch.pm line 71.
> Database returned the following error on attempted INSERT: called with 4
> bind variables when 5 are needed at
> /home/vagrant/kohaclone/C4/Creators/Batch.pm line 73.
> 
> and label creator, when trying to add an item to a batch:
> 
> WARNING: An error was encountered and item(s) not added to batch 1. Please
> have your system administrator check the error log for details. 
> 
> Using kohadevbox, freshly reset database on master.

Oh I think I understand the issue - when you add a new batch, it doesn't get
given a true ID until you add an item, and my patch needs an ID to attach a
description to.

I will add a follow up that hides the description field and button unless the
batch has an ID.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #22 from Katrin Fischer  ---
Hi Aleisha,

I am sorry, but I am still having the same troubles:

- No feedback on pushing the button
- Errors in the logs for patron card creator:

Can't use string ("-2") as a HASH ref while "strict refs" in use at
/home/vagrant/kohaclone/svc/creator_batches line 65.
DBD::mysql::st execute failed: called with 4 bind variables when 5 are needed
[for Statement "INSERT INTO creator_batches (batch_id, description,
item_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues:
0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at
/home/vagrant/kohaclone/C4/Creators/Batch.pm line 71.
Database returned the following error on attempted INSERT: called with 4 bind
variables when 5 are needed at /home/vagrant/kohaclone/C4/Creators/Batch.pm
line 73.

and label creator, when trying to add an item to a batch:

WARNING: An error was encountered and item(s) not added to batch 1. Please have
your system administrator check the error log for details. 

Using kohadevbox, freshly reset database on master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #21 from Aleisha Amohia  ---
(In reply to Katrin Fischer from comment #19)
> There seems to be a bug in this patch set. I have run the database update
> and restart_all, but when I click on "Save description" there is no visual
> feedback and nothing happens.
> 
> Also internal server error when I try to save my patron card batch:
> DBD::mysql::st execute failed: called with 4 bind variables when 5 are
> needed [for Statement "INSERT INTO creator_batches (batch_id, description,
> borrower_number, branch_code, creator) VALUES (?,?,?,?,?);" with
> ParamValues: 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at
> /home/vagrant/kohaclone/C4/Creators/Batch.pm line 71.
> Database returned the following error on attempted INSERT: called with 4
> bind variables when 5 are needed at
> /home/vagrant/kohaclone/C4/Creators/Batch.pm line 73.
> Can't use string ("-2") as a HASH ref while "strict refs" in use at
> /home/vagrant/kohaclone/patroncards/edit-batch.pl line 124.

Hi Katrin,
Everything still works for me and I can't see this error when I test. Is
someone else please able to test and see if they can replicate this error?

On the other hand you did make me realise that I hadn't made the fix from
comment 18 on the patroncard side, so I've implemented that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #20 from Aleisha Amohia  ---
Created attachment 67862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67862=edit
Bug 15766: [FOLLOW-UP] Save description link as button on patroncard side

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #19 from Katrin Fischer  ---
There seems to be a bug in this patch set. I have run the database update and
restart_all, but when I click on "Save description" there is no visual feedback
and nothing happens.

Also internal server error when I try to save my patron card batch:
DBD::mysql::st execute failed: called with 4 bind variables when 5 are needed
[for Statement "INSERT INTO creator_batches (batch_id, description,
borrower_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues:
0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at
/home/vagrant/kohaclone/C4/Creators/Batch.pm line 71.
Database returned the following error on attempted INSERT: called with 4 bind
variables when 5 are needed at /home/vagrant/kohaclone/C4/Creators/Batch.pm
line 73.
Can't use string ("-2") as a HASH ref while "strict refs" in use at
/home/vagrant/kohaclone/patroncards/edit-batch.pl line 124.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #18 from Aleisha Amohia  ---
Created attachment 67305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67305=edit
Bug 15766: [FOLLOW-UP] Making 'Save description' link a button

For consistency's sake in response to Comment 17.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #17 from Marcel de Rooy  ---
Thx for updating your patch.
If I look at Manage Batches and click Edit, I can add a description and save it
by clicking on the link next to the text box. After that we have a text field
for borrowernumbers and a series of buttons.
This does not really look good. I am no design expert, but could you ask around
for some advice in that regard (maybe Owen) ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #63221|0   |1
is obsolete||
  Attachment #63222|0   |1
is obsolete||
  Attachment #63223|0   |1
is obsolete||

--- Comment #16 from Aleisha Amohia  ---
Created attachment 66515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66515=edit
Bug 15766: Adding descriptions to patron card batches

This patch adds a 'description' column to the creator_batches table. The
description for a batch can be added and updated using ajax.

To test:
1) Apply patch and update database (you will have to restart memcached)
2) Go to Tools -> Patron card creator -> Manage batches
3) There should now be a Description column next to Batch ID. This
will be empty (as none of the batches have descriptions yet)
4) Click Edit for any batch
5) Notice new Batch description text field. Enter a description for
the batch in here and click Save description. Some text should show
saying the description was saved.
6) If you go back to the manage batches page, the description should
now show under the Description column.
7) Go to Tools -> Label Creator -> Manage labels
8) Repeat steps 3 to 6

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||m.de.r...@rijksmuseum.nl

--- Comment #15 from Marcel de Rooy  ---
 FAIL   svc/patroncards
   FAIL   git manipulation
The file has been added and deleted in the same patchset

Please adjust your patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Marc Véron  changed:

   What|Removed |Added

  Attachment #61464|0   |1
is obsolete||

--- Comment #14 from Marc Véron  ---
Created attachment 63223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63223=edit
Bug 15766: Changing code to use svc/creator_batches so file can be used for
both modules

Sponsored-by: Catalyst IT

Signed-off-by: Eric Gosselin 

Tested on current master, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Marc Véron  changed:

   What|Removed |Added

  Attachment #61463|0   |1
is obsolete||

--- Comment #13 from Marc Véron  ---
Created attachment 63222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63222=edit
Bug 15766: Adding descriptions to label batches

Same fix, but for Label creator. Follow same test plan but in
Tools->Label creator.

Sponsored-by: Catalyst IT

Signed-off-by: Eric Gosselin 

Tested on current master, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Marc Véron  changed:

   What|Removed |Added

  Attachment #61462|0   |1
is obsolete||

--- Comment #12 from Marc Véron  ---
Created attachment 63221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63221=edit
Bug 15766: Adding descriptions to patron card batches

This patch adds a 'description' column to the creator_batches table. The
description for a batch can be added and updated using ajax.

To test:
1) Apply patch and update database (you will have to restart memcached)
2) Go to Tools -> Patron card creator -> Manage batches
3) There should now be a Description column next to Batch ID. This will
be empty (as none of the batches have descriptions yet)
4) Click Edit for any batch
5) Notice new Batch description text field. Enter a description for the
batch in here and click Save description. Some text should show saying
the description was saved.
6) If you go back to the manage batches page, the description should now
show under the Description column.

Sponsored-by: Catalyst IT

Signed-off-by: Eric Gosselin 

Tested on current master, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Marc Véron  changed:

   What|Removed |Added

Summary|A batch should be given a   |Give label and patron card
   |description.|batches a description
Version|3.22|master
 CC||ve...@veron.ch

--- Comment #11 from Marc Véron  ---
Still valid on current master. Applies cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/