[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to Master - Thanks! Should be in the May 2016 release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Owen Leonard changed: What|Removed |Added Attachment #48584|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 48690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48690&action=edit [PASSED QA] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion When deleting a currency, the confirmation and error dialogs should use Font Awesome icons. This patch makes this change. To test, apply the patch and go to Administration -> Currencies and exchange rates. - Click the "delete" link next to any currency. - Verify that the confirmation dialog is correctly styled. - Test the both cancel and confirm operations. - Verify that the deletion confirmation dialog is correctly styled. Bug 15962 prevents testing the error dialog which should appear if you try to delete a currency which is use (defined as a currency in a vendor record). To test this error you could manually enter a currency code into aqbooksellers.currency and then try to delete that currency. Signed-off-by: Nicole C Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||bren...@bywatersolutions.co ||m --- Comment #4 from Brendan Gallagher --- Needs some rebasing Owen - Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Katrin Fischer changed: What|Removed |Added Attachment #48563|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 48584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48584&action=edit [PASSED QA] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion When deleting a currency, the confirmation and error dialogs should use Font Awesome icons. This patch makes this change. To test, apply the patch and go to Administration -> Currencies and exchange rates. - Click the "delete" link next to any currency. - Verify that the confirmation dialog is correctly styled. - Test the both cancel and confirm operations. - Verify that the deletion confirmation dialog is correctly styled. Bug 15962 prevents testing the error dialog which should appear if you try to delete a currency which is use (defined as a currency in a vendor record). To test this error you could manually enter a currency code into aqbooksellers.currency and then try to delete that currency. Signed-off-by: Nicole C Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Nicole C. Engard changed: What|Removed |Added Attachment #48555|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 48563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48563&action=edit [SIGNED-OFF] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion When deleting a currency, the confirmation and error dialogs should use Font Awesome icons. This patch makes this change. To test, apply the patch and go to Administration -> Currencies and exchange rates. - Click the "delete" link next to any currency. - Verify that the confirmation dialog is correctly styled. - Test the both cancel and confirm operations. - Verify that the deletion confirmation dialog is correctly styled. Bug 15962 prevents testing the error dialog which should appear if you try to delete a currency which is use (defined as a currency in a vendor record). To test this error you could manually enter a currency code into aqbooksellers.currency and then try to delete that currency. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 --- Comment #1 from Owen Leonard --- Created attachment 48555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48555&action=edit Bug 15961 - Use Font Awesome icons for confirmation of currency deletion When deleting a currency, the confirmation and error dialogs should use Font Awesome icons. This patch makes this change. To test, apply the patch and go to Administration -> Currencies and exchange rates. - Click the "delete" link next to any currency. - Verify that the confirmation dialog is correctly styled. - Test the both cancel and confirm operations. - Verify that the deletion confirmation dialog is correctly styled. Bug 15962 prevents testing the error dialog which should appear if you try to delete a currency which is use (defined as a currency in a vendor record). To test this error you could manually enter a currency code into aqbooksellers.currency and then try to delete that currency. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
