[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #22 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #21 from Kyle M Hall  ---
Pushed to master for Koha 16.04!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #19 from Kyle M Hall  ---
Created attachment 51098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51098=edit
Bug 16170: [QA Follow-up] Adjust Items.t

Items.t inserts an item via biblioitem not correctly linked to biblio.
The new foreign key constraint does not allow that.
Actually, we should be choosing to either remove biblioitems from Koha or
remove biblionumber from items.

Note: This seems to be the only case where an item is added this way.

Test plan:
Run Items.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #20 from Kyle M Hall  ---
Created attachment 51099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51099=edit
Bug 16170: [QA Follow-up] Fix embeded typos

Just noticed this typo three times here.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #18 from Kyle M Hall  ---
Created attachment 51097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51097=edit
Bug 16170 - Corrected to make work more smoothly

Signed-off-by: Mark Tompsett 
Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #49723|0   |1
is obsolete||
  Attachment #49724|0   |1
is obsolete||
  Attachment #49771|0   |1
is obsolete||
  Attachment #49772|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall  ---
Created attachment 51096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51096=edit
Bug 16170: Pseudo foreign key in Items

While many of us would like to get rid of biblioitems one day, the current
scheme includes a biblioitemnumber and a biblionumber in Items.
(Which is not so great..)

But also note that biblionumber is NOT defined as a foreign key in Items,
although a belongs_to relation has been added to the DBIx scheme!
This inconsistency should be resolved. The "remove biblioitem table"
operation is a large one, but in the meantime we better make biblionumber
a regular FK not a 'pseudo' one.

Note: If in an (very) exceptional case biblionumbers are found in items,
that do not exist in biblio, this patch prints a warning at upgrade
time and does not add the constraint.

@RM: Please update the DBIx scheme accordingly.

Test plan:
[1] Run the upgrade. Check if the FK constraint has been added.
[2] Remove the FK constraint. Change the biblionumber of one item to an
unexisting record. Run the upgrade again. Notice the warning.

Signed-off-by: Marcel de Rooy 
Tested both cases: constraint added as well as warning printed.

Signed-off-by: Mark Tompsett 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #16 from Kyle M Hall  ---
> Kyle: You most probably did not. If I do, these test pass with me. Note that
> Holds.t does not pass (in current master). And a fix is in PQA for
> ILSDI_Services.t.
> See comment 12, giving you an q-a-d alternative too for running
> update_dbix_class_files.pl (for testing only).

Indeed, that was my issue!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #15 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #14)
> (In reply to Kyle M Hall from comment #13)
> > Looks like numerous unit tests will now fail with the new key constraint
> > such as t/db_dependent/Barcodes.t and t/db_dependent/Accounts.t.
> > 
> > I did not wait for the full run of unit tests to complete.
> 
> Did you run the dbix schema adjust script?

Kyle: You most probably did not. If I do, these test pass with me. Note that
Holds.t does not pass (in current master). And a fix is in PQA for
ILSDI_Services.t.
See comment 12, giving you an q-a-d alternative too for running
update_dbix_class_files.pl (for testing only).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #14 from Marcel de Rooy  ---
(In reply to Kyle M Hall from comment #13)
> Looks like numerous unit tests will now fail with the new key constraint
> such as t/db_dependent/Barcodes.t and t/db_dependent/Accounts.t.
> 
> I did not wait for the full run of unit tests to complete.

Did you run the dbix schema adjust script?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #13 from Kyle M Hall  ---
Looks like numerous unit tests will now fail with the new key constraint such
as t/db_dependent/Barcodes.t and t/db_dependent/Accounts.t.

I did not wait for the full run of unit tests to complete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #12 from Marcel de Rooy  ---
Remember to adjust DBIx (for testing you could just insert is_foreign_key => 1
for biblionumber in Items.pm

If you would run t/db_dependent/Barcodes_ValueBuilder.t, TestBuilder needs to
see that biblionumber is a foreign key.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #11 from Marcel de Rooy  ---
Created attachment 49772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49772=edit
Bug 16170: [QA Follow-up] Fix embeded typos

Just noticed this typo three times here.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #10 from Marcel de Rooy  ---
Created attachment 49771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49771=edit
Bug 16170: [QA Follow-up] Adjust Items.t

Items.t inserts an item via biblioitem not correctly linked to biblio.
The new foreign key constraint does not allow that.
Actually, we should be choosing to either remove biblioitems from Koha or
remove biblionumber from items.

Note: This seems to be the only case where an item is added this way.

Test plan:
Run Items.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #9 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #8)
> t/db_dependent/Items.t . 1/9 DBD::mysql::st
> execute failed: Cannot add or update a child row: a foreign key constraint
> fails (`koha_ut`.`items`, CONSTRAINT `items_ibfk_4` FOREIGN KEY
> (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON
> UPDATE CASCADE) [for Statement "INSERT INTO `items` ( `biblioitemnumber`,
> `itype`) VALUES ( ?, ? )" with ParamValues: 0='88', 1='ITEM_LEVEL'] at
> /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834.

Good catch, but what now?
This is a good example of our bad database design.
DBIx tries to insert records in items based on biblioitemnumber but ignores the
biblionumber one level up.
We can adjust this statement of course, but it is a workaround..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Jonathan Druart  
---
t/db_dependent/Items.t . 1/9 DBD::mysql::st
execute failed: Cannot add or update a child row: a foreign key constraint
fails (`koha_ut`.`items`, CONSTRAINT `items_ibfk_4` FOREIGN KEY
(`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON
UPDATE CASCADE) [for Statement "INSERT INTO `items` ( `biblioitemnumber`,
`itype`) VALUES ( ?, ? )" with ParamValues: 0='88', 1='ITEM_LEVEL'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #49707|0   |1
is obsolete||
  Attachment #49708|0   |1
is obsolete||

--- Comment #6 from Marcel de Rooy  ---
Created attachment 49723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49723=edit
Bug 16170: Pseudo foreign key in Items

While many of us would like to get rid of biblioitems one day, the current
scheme includes a biblioitemnumber and a biblionumber in Items.
(Which is not so great..)

But also note that biblionumber is NOT defined as a foreign key in Items,
although a belongs_to relation has been added to the DBIx scheme!
This inconsistency should be resolved. The "remove biblioitem table"
operation is a large one, but in the meantime we better make biblionumber
a regular FK not a 'pseudo' one.

Note: If in an (very) exceptional case biblionumbers are found in items,
that do not exist in biblio, this patch prints a warning at upgrade
time and does not add the constraint.

@RM: Please update the DBIx scheme accordingly.

Test plan:
[1] Run the upgrade. Check if the FK constraint has been added.
[2] Remove the FK constraint. Change the biblionumber of one item to an
unexisting record. Run the upgrade again. Notice the warning.

Signed-off-by: Marcel de Rooy 
Tested both cases: constraint added as well as warning printed.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #7 from Marcel de Rooy  ---
Created attachment 49724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49724=edit
Bug 16170 - Corrected to make work more smoothly

Signed-off-by: Mark Tompsett 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #5 from Marcel de Rooy  ---
Thanks, Marc.
I have renamed the file from 1_dbrev.perl to 16170_dbrev.sql (!) and did
not test again :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49706|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 49708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49708=edit
Bug 16170 - Corrected to make work more smoothly

Signed-off-by: Mark Tompsett 
NOTE: Should get a sign off by Marcel or someone else before
  switching to SIGNED OFF.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49681|0   |1
is obsolete||

--- Comment #3 from M. Tompsett  ---
Created attachment 49707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49707=edit
Bug 16170: Pseudo foreign key in Items

While many of us would like to get rid of biblioitems one day, the current
scheme includes a biblioitemnumber and a biblionumber in Items.
(Which is not so great..)

But also note that biblionumber is NOT defined as a foreign key in Items,
although a belongs_to relation has been added to the DBIx scheme!
This inconsistency should be resolved. The "remove biblioitem table"
operation is a large one, but in the meantime we better make biblionumber
a regular FK not a 'pseudo' one.

Note: If in an (very) exceptional case biblionumbers are found in items,
that do not exist in biblio, this patch prints a warning at upgrade
time and does not add the constraint.

@RM: Please update the DBIx scheme accordingly.

Test plan:
[1] Run the upgrade. Check if the FK constraint has been added.
[2] Remove the FK constraint. Change the biblionumber of one item to an
unexisting record. Run the upgrade again. Notice the warning.

Signed-off-by: Marcel de Rooy 
Tested both cases: constraint added as well as warning printed.

Signed-off-by: Mark Tompsett 
Tested with my patch too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #2 from M. Tompsett  ---
Created attachment 49706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49706=edit
Bug 16170 - Corrected to make work more smoothly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=13893
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=2685

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||5334


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
[Bug 5334] add explicit foreign key constraints
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

--- Comment #1 from Marcel de Rooy  ---
Created attachment 49681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49681=edit
Bug 16170: Pseudo foreign key in Items

While many of us would like to get rid of biblioitems one day, the current
scheme includes a biblioitemnumber and a biblionumber in Items.
(Which is not so great..)

But also note that biblionumber is NOT defined as a foreign key in Items,
although a belongs_to relation has been added to the DBIx scheme!
This inconsistency should be resolved. The "remove biblioitem table"
operation is a large one, but in the meantime we better make biblionumber
a regular FK not a 'pseudo' one.

Note: If in an (very) exceptional case biblionumbers are found in items,
that do not exist in biblio, this patch prints a warning at upgrade
time and does not add the constraint.

@RM: Please update the DBIx scheme accordingly.

Test plan:
[1] Run the upgrade. Check if the FK constraint has been added.
[2] Remove the FK constraint. Change the biblionumber of one item to an
unexisting record. Run the upgrade again. Notice the warning.

Signed-off-by: Marcel de Rooy 
Tested both cases: constraint added as well as warning printed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16170] Pseudo foreign key in Items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/