[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #18 from Kyle M Hall --- Pushed to master, should be in the May 2016 release! Kamsa hamnida Aleisha! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Katrin Fischer changed: What|Removed |Added Attachment #50781|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 50787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50787&action=edit [PASSED QA] Bug 16263: making authority tags and subfields actions buttons EDIT: Subfields icon, 'i' to eye To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Arslan Farooq Signed-off-by: Bernardo Gonzalez Kriegel Another sign, pretty eye. No errors. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #50773|0 |1 is obsolete|| --- Comment #16 from Bernardo Gonzalez Kriegel --- Created attachment 50781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50781&action=edit [SIGNED-OFF] Bug 16263: making authority tags and subfields actions buttons EDIT: Subfields icon, 'i' to eye To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Arslan Farooq Signed-off-by: Bernardo Gonzalez Kriegel Another sign, pretty eye. No errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Aleisha Amohia changed: What|Removed |Added Attachment #50705|0 |1 is obsolete|| --- Comment #15 from Aleisha Amohia --- Created attachment 50773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50773&action=edit Bug 16263: making authority tags and subfields actions buttons EDIT: Subfields icon, 'i' to eye To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Arslan Farooq -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer --- I am not sure about the "i" symbol for showing the subfields list - why not use the "eye" as we have in other places? Thanks for fixing 'subfields' - that was bugging me since forever! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 --- Comment #13 from Arslan Farooq --- Thanks Owen. I also tested on gitified Koha installation...using Vagrant. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Owen Leonard changed: What|Removed |Added Assignee|arslan...@gmail.com |aleishaamo...@hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #12 from Owen Leonard --- (In reply to Arslan Farooq from comment #11) >FAIL valid_template > Attempt to reload Koha/Template/Plugin/Koha.pm aborted. > Compilation failed in require at > /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206. I get this error all the time and I've always assumed that it's because I'm testing in a gitified package installation. What kind of test system are you working with? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Arslan Farooq changed: What|Removed |Added Attachment #50274|0 |1 is obsolete|| Attachment #50671|0 |1 is obsolete|| Assignee|aleishaamo...@hotmail.com |arslan...@gmail.com Status|Needs Signoff |Failed QA --- Comment #11 from Arslan Farooq --- Created attachment 50705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50705&action=edit Bug 16263: making authority tags and subfields actions buttons After applying patch, everything looked OK in staff client. But the QA tools are complaining about something: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt OK forbidden patterns SKIP spelling OK tt_valid FAIL valid_template Attempt to reload Koha/Template/Plugin/Koha.pm aborted. Compilation failed in require at /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206. OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel --- > > However the qa tools fails. It says: http://paste.koha-community.org/419 > No fails for me $ qa -c 1 testing 1 commit(s) (applied to 9648cd2 'Bug 12267 - Update DB Schema files') Processing files before patches |>| 2 / 2 (100.00%) Processing files after patches |>| 2 / 2 (100.00%) OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 --- Comment #9 from Arslan Farooq --- Hi, The patch works fine. Everything looks OK. However the qa tools fails. It says: http://paste.koha-community.org/419 Note: I made sure master branch was up to date. And tested the patch on a fresh checked out branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 --- Comment #7 from Aleisha Amohia --- (In reply to Owen Leonard from comment #6) > The latest patch removes "pull-right" from authtypes.tt but doesn't add it > to auth_tag_structure.tt. Sorry, I misunderstood. Making changes now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Aleisha Amohia changed: What|Removed |Added Attachment #50302|0 |1 is obsolete|| --- Comment #8 from Aleisha Amohia --- Created attachment 50671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50671&action=edit Bug 16263: making authority tags and subfields actions buttons To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- The latest patch removes "pull-right" from authtypes.tt but doesn't add it to auth_tag_structure.tt. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 --- Comment #5 from Aleisha Amohia --- (In reply to Arslan Farooq from comment #4) > We need to make > > to > > > at line 167 as Owen pointed out. I did make this change? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Arslan Farooq changed: What|Removed |Added CC||arslan...@gmail.com --- Comment #4 from Arslan Farooq --- We need to make http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Aleisha Amohia changed: What|Removed |Added Attachment #50248|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 50302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50302&action=edit Bug 16263: making authority tags and subfields actions buttons To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 --- Comment #2 from Owen Leonard --- Created attachment 50274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50274&action=edit Menu gets cut off if browser window isn't very wide Could you switch http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA Component|MARC Authority data support |System Administration CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 --- Comment #1 from Aleisha Amohia --- Created attachment 50248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50248&action=edit Bug 16263: making authority tags and subfields actions buttons To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Aleisha Amohia changed: What|Removed |Added Assignee|gmcha...@gmail.com |aleishaamo...@hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16263] Making authority tags and subfields actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16263 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
