[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

Julian Maurice  changed:

   What|Removed |Added

 Depends on||16058
 CC||julian.maur...@biblibre.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16058
[Bug 16058] Add a button to delete an individual news item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for the 16.05 release. Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

Owen Leonard  changed:

   What|Removed |Added

 Blocks||16386


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386
[Bug 16386] Replace the use of "onclick" from patron card creator templates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #50871|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 50887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50887=edit
[PASSED QA] Bug 16372 - Replace the use of "onclick" for deletion confirmation
in some templates

This patch removes the use of event attributes from several templates
where the attributes were used to handle deletion operations. I've
grouped these changes in one patch because each template had only small
changes to be made.

Unrelated change: Reformatted the "no news items" message which is
displayed if there are no news items.

To test, apply the patch and test deletion operations on the following
pages. Clicking "delete" should prompty you to confirm. Test both the
confirm and cancel actions.

- On the staff client home page, test deletion of a news item.
- On the patron lists page, test deletion of a patron list.
- In the patron card creator, choose Manage -> Images. Test the "Delete"
  button for a single image.
- On the news page, test deletion of a single news item.
- On the news page, test deletion of multiple items.

Signed-off-by: Arslan Farooq 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

--- Comment #3 from Arslan Farooq  ---
Did QA tools as well, and it passed. However, there was that Plugins.pm message
again "Compilation failed in require at
/usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206."

-
FAILkoha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
   OK forbidden patterns
   SKIP   spelling
   OK tt_valid
   FAIL   valid_template
Attempt to reload Koha/Template/Plugin/Koha.pm aborted.
Compilation failed in require at /usr/local/lib/perl/5.14.2/Template/Plugins.pm
line 206.



 OK koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt
   OK forbidden patterns
   SKIP   spelling
   OK tt_valid
   OK valid_template

 OK koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt
   OK forbidden patterns
   SKIP   spelling
   OK tt_valid
   OK valid_template

 OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt
   OK forbidden patterns
   SKIP   spelling
   OK tt_valid
   OK valid_template
-

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

Arslan Farooq  changed:

   What|Removed |Added

  Attachment #50832|0   |1
is obsolete||
   Assignee|oleon...@myacpl.org |arslan...@gmail.com
 Status|Needs Signoff   |Signed Off
 CC||arslan...@gmail.com

--- Comment #2 from Arslan Farooq  ---
Created attachment 50871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50871=edit
Bug 16372 - Replace the use of "onclick" for deletion confirmation in some
templates

This patch removes the use of event attributes from several templates
where the attributes were used to handle deletion operations. I've
grouped these changes in one patch because each template had only small
changes to be made.

Unrelated change: Reformatted the "no news items" message which is
displayed if there are no news items.

To test, apply the patch and test deletion operations on the following
pages. Clicking "delete" should prompty you to confirm. Test both the
confirm and cancel actions.

- On the staff client home page, test deletion of a news item.
- On the patron lists page, test deletion of a patron list.
- In the patron card creator, choose Manage -> Images. Test the "Delete"
  button for a single image.
- On the news page, test deletion of a single news item.
- On the news page, test deletion of multiple items.

-

All things were tested and everything worked OK.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

--- Comment #1 from Owen Leonard  ---
Created attachment 50832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50832=edit
Bug 16372 - Replace the use of "onclick" for deletion confirmation in some
templates

This patch removes the use of event attributes from several templates
where the attributes were used to handle deletion operations. I've
grouped these changes in one patch because each template had only small
changes to be made.

Unrelated change: Reformatted the "no news items" message which is
displayed if there are no news items.

To test, apply the patch and test deletion operations on the following
pages. Clicking "delete" should prompty you to confirm. Test both the
confirm and cancel actions.

- On the staff client home page, test deletion of a news item.
- On the patron lists page, test deletion of a patron list.
- In the patron card creator, choose Manage -> Images. Test the "Delete"
  button for a single image.
- On the news page, test deletion of a single news item.
- On the news page, test deletion of multiple items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/