[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17666

--- Comment #17 from Jonathan Druart  
---
This patchset breaks DB update on kohadevbox, see bug 17666

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Mirko Tietgen  changed:

   What|Removed |Added

   Keywords||nowheezy

--- Comment #16 from Mirko Tietgen  ---
(In reply to Jonathan Druart from comment #12)
> RM Note: The package version in wheezy is too old, the package version
>  in jessie is just fine and should be added to the community
>  repo if wheezy will be supported for the coming release.

Wheezy will not be supported by 16.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
  Attachment #56219|0   |1
is obsolete||

--- Comment #15 from Mirko Tietgen  ---
Comment on attachment 56219
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56219
Bug 16685 Path::Tiny Control file update (master)

Moving the control file patch to another bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

--- Comment #14 from Mirko Tietgen  ---
Created attachment 56219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56219=edit
Bug 16685 Path::Tiny Control file update (master)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #13 from Kyle M Hall  ---
Pushed to master for 16.11!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54729|0   |1
is obsolete||
  Attachment #54730|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 54758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54758=edit
Bug 16685 - Use eval instead of do for .perl atomicupdates

If we use eval instead of do for our .perl atomic update files, it will
allow developers to put in the exact code that should go into
updatedatabase.pl. The problem with do is that none of the variables
defined in updatadatabase.pl are available, whereas with eval they are.

Test Plan:
1) Apply this patch
2) Create a .perl file in atomicupdates with the following in it:
say "DBversion: $DBversion";
3) Run updatadatabase.pl
4) Note the output
5) Add a syntax error to your atomic update
6) Run updatedatabase.pl
7) Note the error is displayed

Signed-off-by: Aleisha Amohia 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

--- Comment #12 from Jonathan Druart  
---
Created attachment 54759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54759=edit
Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp

File::Slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
 in jessie is just fine and should be added to the community
 repo if wheezy will be supported for the coming release.

Signed-off-by: Aleisha Amohia 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #52901|0   |1
is obsolete||

--- Comment #9 from Aleisha Amohia  ---
Created attachment 54729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54729=edit
[SIGNED-OFF] Bug 16685 - Use eval instead of do for .perl atomicupdates

If we use eval instead of do for our .perl atomic update files, it will
allow developers to put in the exact code that should go into
updatedatabase.pl. The problem with do is that none of the variables
defined in updatadatabase.pl are available, whereas with eval they are.

Test Plan:
1) Apply this patch
2) Create a .perl file in atomicupdates with the following in it:
say "DBversion: $DBversion";
3) Run updatadatabase.pl
4) Note the output
5) Add a syntax error to your atomic update
6) Run updatedatabase.pl
7) Note the error is displayed

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #54541|0   |1
is obsolete||

--- Comment #10 from Aleisha Amohia  ---
Created attachment 54730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54730=edit
[SIGNED-OFF] Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of
File::Slurp

File::Slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
 in jessie is just fine and should be added to the community
 repo if wheezy will be supported for the coming release.

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #8 from M. Tompsett  ---
Rebased. Kitten saved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett  changed:

   What|Removed |Added

  Attachment #54540|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 54541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54541=edit
Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp

File::Slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
 in jessie is just fine and should be added to the community
 repo if wheezy will be supported for the coming release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett  changed:

   What|Removed |Added

  Attachment #52902|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 54540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54540=edit
Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp

File::Slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
 in jessie is just fine and should be added to the community
 repo if wheezy will be supported for the coming release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Nice one Kyle, can u please rebase? I'd put the new dep somewhere
alphabetically. Is it packaged already?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Kyle M Hall  changed:

   What|Removed |Added

   Keywords||dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52132|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 52901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52901=edit
Bug 16685 - Use eval instead of do for .perl atomicupdates

If we use eval instead of do for our .perl atomic update files, it will
allow developers to put in the exact code that should go into
updatedatabase.pl. The problem with do is that none of the variables
defined in updatadatabase.pl are available, whereas with eval they are.

Test Plan:
1) Apply this patch
2) Create a .perl file in atomicupdates with the following in it:
say "DBversion: $DBversion";
3) Run updatadatabase.pl
4) Note the output
5) Add a syntax error to your atomic update
6) Run updatedatabase.pl
7) Note the error is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

--- Comment #4 from Kyle M Hall  ---
Created attachment 52902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52902=edit
Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp

File::Slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
 in jessie is just fine and should be added to the community
 repo if wheezy will be supported for the coming release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Frédéric Demians  ---
I remember Jonathan saying that File::Slurp was 'bad'. It the same time, I can
see it in several place, and recently added with Edifact.

http://blogs.perl.org/users/leon_timmermans/2015/08/fileslurp-is-broken-and-wrong.html

Path::Tiny is generally regarded as a better alternative.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

--- Comment #1 from Kyle M Hall  ---
Created attachment 52132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52132=edit
Bug 16685 - Use eval instead of do for .perl atomicupdates

If we use eval instead of do for our .perl atomic update files, it will
allow developers to put in the exact code that should go into
updatedatabase.pl. The problem with do is that none of the variables
defined in updatadatabase.pl are available, whereas with eval they are.

Test Plan:
1) Apply this patch
2) Create a .perl file in atomicupdates with the following in it:
say "DBversion: $DBversion";
3) Run updatadatabase.pl
4) Note the output
5) Add a syntax error to your atomic update
6) Run updatedatabase.pl
7) Note the error is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/