[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Jacek!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52390|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 52397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52397=edit
Bug 16734: getLanguages() in opac-search.pl should be called only if needed

There is no need to always call getLanguages() in opac/opac-search.pl
(especially not if it's an actual search), it's output is used only
in opac-advsearch.tt template. This patch moves it into
'if ( ... $template_type eq 'advsearch' )' block.

Speed gain is rather moderate (40 - 80 msec, if the mysql server
is no too busy, and the results are already in query cache),
but it eliminates a lot of small DBI calls, making a further
profiling of OPAC searches a bit easier.

Test plan: just ensure that language selection is still available
on OPAC advanced search page, and that it still works like intended.

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

Marc Véron  changed:

   What|Removed |Added

  Attachment #52374|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 52390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52390=edit
Bug 16734: getLanguages() in opac-search.pl should be called only if needed

There is no need to always call getLanguages() in opac/opac-search.pl
(especially not if it's an actual search), it's output is used only
in opac-advsearch.tt template. This patch moves it into
'if ( ... $template_type eq 'advsearch' )' block.

Speed gain is rather moderate (40 - 80 msec, if the mysql server
is no too busy, and the results are already in query cache),
but it eliminates a lot of small DBI calls, making a further
profiling of OPAC searches a bit easier.

Test plan: just ensure that language selection is still available
on OPAC advanced search page, and that it still works like intended.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

Jacek Ablewicz  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12017
   Assignee|gmcha...@gmail.com  |a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

Jacek Ablewicz  changed:

   What|Removed |Added

 Blocks||15262


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262
[Bug 15262] Run Koha Run. Koha search should be fast again.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

--- Comment #1 from Jacek Ablewicz  ---
Created attachment 52374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52374=edit
Bug 16734: getLanguages() in opac-search.pl should be called only if needed

There is no need to always call getLanguages() in opac/opac-search.pl
(especially not if it's an actual search), it's output is used only
in opac-advsearch.tt template. This patch moves it into
'if ( ... $template_type eq 'advsearch' )' block.

Speed gain is rather moderate (40 - 80 msec, if the mysql server
is no too busy, and the results are already in query cache),
but it eliminates a lot of small DBI calls, making a further
profiling of OPAC searches a bit easier.

Test plan: just ensure that language selection is still available
on OPAC advanced search page, and that it still works like intended.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

Jacek Ablewicz  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/