[Koha-bugs] [Bug 16759] Make OPAC holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Jonathan Druart changed: What|Removed |Added Blocks||35319 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35319 [Bug 35319] Default sorting of the holdings table with OPACHoldingsDefaultSortField is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make OPAC holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|Make opac holdings table|Make OPAC holdings table |configurable|configurable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #23 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Nick Clemens changed: What|Removed |Added Attachment #68465|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #22 from Nick Clemens --- (In reply to Tomás Cohen Arazi from comment #20) > I've submitted this alternative followup, that's supposed to do the job, but > it isn't happening. I can't find a way to solve it yet. I post it so other > people can spot the problem with it. > It is supposed to replace the previous followup. It looks like the problem was the index, we were getting the index of 'th' in all tables - if we specify the index of "selector + ' th'" we get the correct value and columns are hidden. This should be a safe enough change it could be added to the intranet file too if we need to maintain consistency -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #21 from Nick Clemens --- Created attachment 68528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68528&action=edit Bug 16759: Followup Use index of elements in specific table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #20 from Tomás Cohen Arazi --- I've submitted this alternative followup, that's supposed to do the job, but it isn't happening. I can't find a way to solve it yet. I post it so other people can spot the problem with it. It is supposed to replace the previous followup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 68507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68507&action=edit Bug 16759: (Alternative followup) Handle otherholdings gracefuly Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #18 from Jonathan Druart --- (In reply to Nick Clemens from comment #17) > Created attachment 68465 [details] [review] > Bug 16759: (followup) Make it work with OpacSeparateHoldings There is something wrong in this patch: 1. columns_settings.inc of opac and intranet will differ 2. KohaTable will not return an array, that's weird, it should return a table I think a better way to do that is that add different ids to the table and instantiate two KohaTable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #17 from Nick Clemens --- Created attachment 68465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68465&action=edit Bug 16759: (followup) Make it work with OpacSeparateHoldings This patch fixes columns_settings.inc so it works for all objects when the selector returns more than one object. To test: - Have the first patch applied - Verify it works correctly - Enable OpacSeparateHoldings - Reload => FAIL: Notice the second holdings tab doesn't have the visualization rules applied. - Apply this patch - Reload => SUCCESS: Rules applied correctly! - Sign off :-D Edit: amended so it preserves the original semantic, returning the resulting table objects. Sponsored-by: Dover Signed-off-by: Owen Leonard Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Nick Clemens changed: What|Removed |Added Attachment #68344|0 |1 is obsolete|| Attachment #68346|0 |1 is obsolete|| --- Comment #16 from Nick Clemens --- Created attachment 68464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68464&action=edit Bug 16759: Make OPAC holdings table configurable This patch makes the holdings table in the OPAC biblio detail page configurable using the Columns configuration tools. This patch: - Moves the holdingst table from plain DataTable to KohaTable - Creates a sample yml colvis configuration for this table containing all the currently available columns To test: - Visit some record's detail page in the OPAC - Apply this patch - Reload => SUCCESS: The page shows the same information - On the staff interface, go to: Home > Administration > Columns settings => SUCCESS: There's a new OPAC section containing the configuration for holdingst. - Choose to hide some fields (both currently displayed and currently hidden). - Reload the OPAC detail page => SUCCESS: - Required fields are hidden - It doesn't explode because of trying to hide stuff that is not there to start with - Sign off :-D Sponsored-by: DOVER Signed-off-by: Owen Leonard Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #15 from Alex Buckley --- Hi I have taken a second look at these patches for Tomás, and they work well and pass the QA test tool so I have signed off on them as well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Alex Buckley changed: What|Removed |Added Attachment #68345|0 |1 is obsolete|| --- Comment #14 from Alex Buckley --- Created attachment 68346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68346&action=edit [SIGNED-OFF] Bug 16759: (followup) Make it work with OpacSeparateHoldings This patch fixes columns_settings.inc so it works for all objects when the selector returns more than one object. To test: - Have the first patch applied - Verify it works correctly - Enable OpacSeparateHoldings - Reload => FAIL: Notice the second holdings tab doesn't have the visualization rules applied. - Apply this patch - Reload => SUCCESS: Rules applied correctly! - Sign off :-D Edit: amended so it preserves the original semantic, returning the resulting table objects. Sponsored-by: Dover Signed-off-by: Owen Leonard Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Alex Buckley changed: What|Removed |Added Attachment #68343|0 |1 is obsolete|| --- Comment #13 from Alex Buckley --- Created attachment 68345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68345&action=edit Bug 16759: (followup) Make it work with OpacSeparateHoldings This patch fixes columns_settings.inc so it works for all objects when the selector returns more than one object. To test: - Have the first patch applied - Verify it works correctly - Enable OpacSeparateHoldings - Reload => FAIL: Notice the second holdings tab doesn't have the visualization rules applied. - Apply this patch - Reload => SUCCESS: Rules applied correctly! - Sign off :-D Edit: amended so it preserves the original semantic, returning the resulting table objects. Sponsored-by: Dover Signed-off-by: Owen Leonard Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Alex Buckley changed: What|Removed |Added Attachment #68342|0 |1 is obsolete|| --- Comment #12 from Alex Buckley --- Created attachment 68344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68344&action=edit [SIGNED-OFF] Bug 16759: Make OPAC holdings table configurable This patch makes the holdings table in the OPAC biblio detail page configurable using the Columns configuration tools. This patch: - Moves the holdingst table from plain DataTable to KohaTable - Creates a sample yml colvis configuration for this table containing all the currently available columns To test: - Visit some record's detail page in the OPAC - Apply this patch - Reload => SUCCESS: The page shows the same information - On the staff interface, go to: Home > Administration > Columns settings => SUCCESS: There's a new OPAC section containing the configuration for holdingst. - Choose to hide some fields (both currently displayed and currently hidden). - Reload the OPAC detail page => SUCCESS: - Required fields are hidden - It doesn't explode because of trying to hide stuff that is not there to start with - Sign off :-D Sponsored-by: DOVER Signed-off-by: Owen Leonard Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Attachment #65563|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Alex Buckley changed: What|Removed |Added Attachment #65564|0 |1 is obsolete|| --- Comment #11 from Alex Buckley --- Created attachment 68343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68343&action=edit [SIGNED-OFF] Bug 16759: (followup) Make it work with OpacSeparateHoldings This patch fixes columns_settings.inc so it works for all objects when the selector returns more than one object. To test: - Have the first patch applied - Verify it works correctly - Enable OpacSeparateHoldings - Reload => FAIL: Notice the second holdings tab doesn't have the visualization rules applied. - Apply this patch - Reload => SUCCESS: Rules applied correctly! - Sign off :-D Edit: amended so it preserves the original semantic, returning the resulting table objects. Sponsored-by: Dover Signed-off-by: Owen Leonard Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #10 from Alex Buckley --- Created attachment 68342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68342&action=edit Bug 16759: Make OPAC holdings table configurable This patch makes the holdings table in the OPAC biblio detail page configurable using the Columns configuration tools. This patch: - Moves the holdingst table from plain DataTable to KohaTable - Creates a sample yml colvis configuration for this table containing all the currently available columns To test: - Visit some record's detail page in the OPAC - Apply this patch - Reload => SUCCESS: The page shows the same information - On the staff interface, go to: Home > Administration > Columns settings => SUCCESS: There's a new OPAC section containing the configuration for holdingst. - Choose to hide some fields (both currently displayed and currently hidden). - Reload the OPAC detail page => SUCCESS: - Required fields are hidden - It doesn't explode because of trying to hide stuff that is not there to start with - Sign off :-D Sponsored-by: DOVER Signed-off-by: Owen Leonard Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #9 from Owen Leonard --- Created attachment 65564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65564&action=edit [SIGNED-OFF] Bug 16759: (followup) Make it work with OpacSeparateHoldings This patch fixes columns_settings.inc so it works for all objects when the selector returns more than one object. To test: - Have the first patch applied - Verify it works correctly - Enable OpacSeparateHoldings - Reload => FAIL: Notice the second holdings tab doesn't have the visualization rules applied. - Apply this patch - Reload => SUCCESS: Rules applied correctly! - Sign off :-D Edit: amended so it preserves the original semantic, returning the resulting table objects. Sponsored-by: Dover Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Owen Leonard changed: What|Removed |Added Attachment #65401|0 |1 is obsolete|| Attachment #65513|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 65563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65563&action=edit [SIGNED-OFF] Bug 16759: Make OPAC holdings table configurable This patch makes the holdings table in the OPAC biblio detail page configurable using the Columns configuration tools. This patch: - Moves the holdingst table from plain DataTable to KohaTable - Creates a sample yml colvis configuration for this table containing all the currently available columns To test: - Visit some record's detail page in the OPAC - Apply this patch - Reload => SUCCESS: The page shows the same information - On the staff interface, go to: Home > Administration > Columns settings => SUCCESS: There's a new OPAC section containing the configuration for holdingst. - Choose to hide some fields (both currently displayed and currently hidden). - Reload the OPAC detail page => SUCCESS: - Required fields are hidden - It doesn't explode because of trying to hide stuff that is not there to start with - Sign off :-D Sponsored-by: DOVER Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Tomás Cohen Arazi changed: What|Removed |Added Attachment #65512|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 65513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65513&action=edit Bug 16759: (followup) Make it work with OpacSeparateHoldings This patch fixes columns_settings.inc so it works for all objects when the selector returns more than one object. To test: - Have the first patch applied - Verify it works correctly - Enable OpacSeparateHoldings - Reload => FAIL: Notice the second holdings tab doesn't have the visualization rules applied. - Apply this patch - Reload => SUCCESS: Rules applied correctly! - Sign off :-D Edit: amended so it preserves the original semantic, returning the resulting table objects. Sponsored-by: Dover -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 65512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65512&action=edit Bug 16759: (followup) Make it work with OpacSeparateHoldings This patch fixes columns_settings.inc so it works for all objects when the selector returns more than one object. To test: - Have the first patch applied - Verify it works correctly - Enable OpacSeparateHoldings - Reload => FAIL: Notice the second holdings tab doesn't have the visualization rules applied. - Apply this patch - Reload => SUCCESS: Rules applied correctly! - Sign off :-D Sponsored-by: Dover -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- Turning on OpacSeparateHoldings and setting OpacSeparateHoldingsBranch breaks this for logged-in users. The second tab of holdings doesn't get its contents correctly filtered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Tomás Cohen Arazi changed: What|Removed |Added Blocks||19038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038 [Bug 19038] Remove OPACShowBarcode syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Owen Leonard from comment #3) > This patch works well for me and I'd be ready to sign off on it. That's great! > This feature may make it more desirable to have shelving location in a > separate location, but I don't have a strong opinion about it. I filed a separate bug for it to simplify testing. Please check bug 19028. > I think it would be nice to transition from the system preferences, but I > think it could be handled in separate follow-up bugs. > > I think that we should not use js-based column configuration to hide > anything which is sensitive information (OPACShowCheckoutName is the one > that comes to mind), and let no-js users see the full table. I agree, that was the main idea behind the approach. I'm about to add a followup for OPACShowBarcode. And am all ears for other sysprefs removal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Tomás Cohen Arazi changed: What|Removed |Added Blocks||19028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 [Bug 19028] Add 'shelving location' to holdings table in detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #3 from Owen Leonard --- This patch works well for me and I'd be ready to sign off on it. This feature may make it more desirable to have shelving location in a separate location, but I don't have a strong opinion about it. I think it would be nice to transition from the system preferences, but I think it could be handled in separate follow-up bugs. I think that we should not use js-based column configuration to hide anything which is sensitive information (OPACShowCheckoutName is the one that comes to mind), and let no-js users see the full table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Tomás Cohen Arazi changed: What|Removed |Added Depends on||17277 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277 [Bug 17277] Current Location column in Holdings table showing empty under OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #2 from Tomás Cohen Arazi --- I've attached this preliminary patch, that makes the holdings table in the OPAC detail page easily configurable using the Columns settings configuration page. YAY! A few remarks for testers and other devs taking a look: - The original request includes 'shelving location' column. The shelving location is already displayed below the home/holding library. I'm looking forward for opinions on this. - Some of the currently used sysprefs controlling what's displayed could be removed in favour of using this column configuration. For example ShowCourseReservesHeader, OPACShowBarcode and OpacLocationBranchToDisplay. I can implement that if required by QA. It would be a simple upgrade step setting the right options based on the sysprefs. - No-js, should we completely remove the columns at template level so non-js browsers can render it properly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 65401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65401&action=edit Bug 16759: Make OPAC holdings table configurable This patch makes the holdings table in the OPAC biblio detail page configurable using the Columns configuration tools. This patch: - Moves the holdingst table from plain DataTable to KohaTable - Creates a sample yml colvis configuration for this table containing all the currently available columns To test: - Visit some record's detail page in the OPAC - Apply this patch - Reload => SUCCESS: The page shows the same information - On the staff interface, go to: Home > Administration > Columns settings => SUCCESS: There's a new OPAC section containing the configuration for holdingst. - Choose to hide some fields (both currently displayed and currently hidden). - Reload the OPAC detail page => SUCCESS: - Required fields are hidden - It doesn't explode because of trying to hide stuff that is not there to start with - Sign off :-D Sponsored-by: DOVER -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] Make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Tomás Cohen Arazi changed: What|Removed |Added Summary|make opac holdings table|Make opac holdings table |configurable|configurable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Assignee|jwea...@bywatersolutions.co |tomasco...@gmail.com |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16759] make opac holdings table configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 Nicole C. Engard changed: What|Removed |Added CC||a...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
