[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|Pushed to Master|Pushed to Stable

--- Comment #17 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #16 from Kyle M Hall  ---
Pushed to master for 16.11,t hanks Hector!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

--- Comment #15 from Jonathan Druart  
---
Created attachment 53058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53058=edit
Bug 16794: Group the 2 action buttons into the same column

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53048|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart  
---
Created attachment 53057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53057=edit
Bug 16794: Revise layout for Admistration > Patron categories

Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links

To test
- Go to Administration -> Patron categories
 - Confirm that two button appear instead of links for "Edit" and "Delete"
 - Edit an existing category and confirm that works as expected
 - Delete a category and confirm that works properly.

Patch fix it according with QA comment 3
Fix copy and paste according with QA comment 6
Fix column "Default privacy" to be sorted again according with comment 8
Patch set squashed

Buttons appear now as requested in comment #3 (2 buttons, no action menu)

Re-tested, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #13 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #12)
> The 2 buttons should be grouped into the same column.

Nevermind, I will provide a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #12 from Jonathan Druart  
---
The 2 buttons should be grouped into the same column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Marc Véron  changed:

   What|Removed |Added

  Attachment #53003|0   |1
is obsolete||

--- Comment #11 from Marc Véron  ---
Created attachment 53048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53048=edit
Bug 16794: Revise layout for Admistration > Patron categories

Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links

To test
- Go to Administration -> Patron categories
 - Confirm that two button appear instead of links for "Edit" and "Delete"
 - Edit an existing category and confirm that works as expected
 - Delete a category and confirm that works properly.

Patch fix it according with QA comment 3
Fix copy and paste according with QA comment 6
Fix column "Default privacy" to be sorted again according with comment 8
Patch set squashed

Buttons appear now as requested in comment #3 (2 buttons, no action menu)

Re-tested, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #52703|0   |1
is obsolete||
  Attachment #52856|0   |1
is obsolete||
  Attachment #53002|0   |1
is obsolete||

--- Comment #10 from Héctor Eduardo Castro Avalos  
---
Created attachment 53003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53003=edit
Bug 16794: Revise layout for Admistration > Patron categories

Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links

To test
- Go to Administration -> Patron categories
 - Confirm that two button appear instead of links for "Edit" and "Delete"
 - Edit an existing category and confirm that works as expected
 - Delete a category and confirm that works properly.

Patch fix it according with QA comment 3
Fix copy and paste according with QA comment 6
Fix column "Default privacy" to be sorted again according with comment 8
Patch set squashed

Buttons appear now as requested in comment #3 (2 buttons, no action menu)
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

--- Comment #9 from Héctor Eduardo Castro Avalos  ---
Created attachment 53002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53002=edit
Bug 16794: (follow up)Make column "Default privacy" could be sorted again

Fix column "Default privacy" to be sorted again according with comment 8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

jmbroust  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||jean-manuel.broust@univ-lyo
   ||n2.fr

--- Comment #8 from jmbroust  ---
Column Default privacy can't be sorted anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

--- Comment #7 from Héctor Eduardo Castro Avalos  ---
Created attachment 52856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52856=edit
Bug 16794: (follow up) Change scope header to col only

Fix copy and paste according with QA comment 6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

--- Comment #6 from Owen Leonard  ---
Comment on attachment 52703
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52703
Bug 16794: Revise layout for Admistration > Patron categories

Review of attachment 52703:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=16794=52703)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
@@ +318,4 @@
>  [% END %]
>  Branches limitations
>  Default privacy
> + colspan="1" rowspan="1" class="sorting_disabled">Actions

This looks like a copy and paste from DataTables-generated markup. I don't
think we need anything more than 'Actions' in the
template.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Marc Véron  changed:

   What|Removed |Added

  Attachment #52697|0   |1
is obsolete||

--- Comment #5 from Marc Véron  ---
Created attachment 52703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52703=edit
Bug 16794: Revise layout for Admistration > Patron categories

Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links

To test
- Go to Administration -> Patron categories
 - Confirm that two button appear instead of links for "Edit" and "Delete"
 - Edit an existing category and confirm that works as expected
 - Delete a category and confirm that works properly.

Patch fix it according with QA comment 3

Buttons appear now as requested in comment #3 (2 buttons, no action menu)
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

Summary|Revise layout for   |Revise layout for
   |Admistration > Categories   |Admistration > Patron
   ||categories

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/