[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #12 from Katrin Fischer  ---
This patch has been pushed to 16.11.x, will be in 16.11.01!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Katrin Fischer  changed:

   What|Removed |Added

Summary|[String changes] Renewal|Renewal error message not
   |error message not specific  |specific enough on self
   |enough on self check.   |check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #57238|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 57670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57670=edit
[PASSED QA] Bug 16873: Improve renewal error messages on self check

When a patron is not allowed to renew from the self check module, the
only message displayed is "No renewals allowed".
It would be nicer to let him/her know that the renewal is not allowed
because it's a on-site checkout or automatic renewal.

To do so we can call CanBookBeRenewed instead of CanBookBeIssued and get
the renewal error.

Test plan:
0/ Switch off AllowSelfCheckReturns
1/ check out an item and tick "auto renewal"
2/ Go on the self check module
=> auto renewal message is displayed
3/ check out an item and tick "on-site checkout"
4/ Go on the self check module
=> on-site checkout message is displayed
5/ check out an item without ticking any checkboxes (regular checkout)
Renew it to reach the max renew allowed
6/ Go on the self check module
=> regular checkout message is displayed
7/ Switch on AllowSelfCheckReturns and repeat previous steps
=> "Return this item" button is displayed in addition of the renewal
error message

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56678|0   |1
is obsolete||

--- Comment #8 from Josef Moravec  ---
Created attachment 57238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57238=edit
[SIGNED-OFF] Bug 16873: Improve renewal error messages on self check

When a patron is not allowed to renew from the self check module, the
only message displayed is "No renewals allowed".
It would be nicer to let him/her know that the renewal is not allowed
because it's a on-site checkout or automatic renewal.

To do so we can call CanBookBeRenewed instead of CanBookBeIssued and get
the renewal error.

Test plan:
0/ Switch off AllowSelfCheckReturns
1/ check out an item and tick "auto renewal"
2/ Go on the self check module
=> auto renewal message is displayed
3/ check out an item and tick "on-site checkout"
4/ Go on the self check module
=> on-site checkout message is displayed
5/ check out an item without ticking any checkboxes (regular checkout)
Renew it to reach the max renew allowed
6/ Go on the self check module
=> regular checkout message is displayed
7/ Switch on AllowSelfCheckReturns and repeat previous steps
=> "Return this item" button is displayed in addition of the renewal
error message

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
There is a small conflict, please fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||josef.mora...@gmail.com

--- Comment #6 from Josef Moravec  ---
Everything works as described. 

I've rebased on the master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Josef Moravec  changed:

   What|Removed |Added

  Attachment #55503|0   |1
is obsolete||

--- Comment #5 from Josef Moravec  ---
Created attachment 56678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56678=edit
[SIGNED-OFF] Bug 16873: Improve renewal error messages on self check

When a patron is not allowed to renew from the self check module, the
only message displayed is "No renewals allowed".
It would be nicer to let him/her know that the renewal is not allowed
because it's a on-site checkout or automatic renewal.

To do so we can call CanBookBeRenewed instead of CanBookBeIssued and get
the renewal error.

Test plan:
0/ Switch off AllowSelfCheckReturns
1/ check out an item and tick "auto renewal"
2/ Go on the self check module
=> auto renewal message is displayed
3/ check out an item and tick "on-site checkout"
4/ Go on the self check module
=> on-site checkout message is displayed
5/ check out an item without ticking any checkboxes (regular checkout)
Renew it to reach the max renew allowed
6/ Go on the self check module
=> regular checkout message is displayed
7/ Switch on AllowSelfCheckReturns and repeat previous steps
=> "Return this item" button is displayed in addition of the renewal
error message

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

--- Comment #4 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #2)
> > 1/ check in an item and tick "auto renewal"
> > 3/ check in an item and tick "on-site checkout"
> > 5/ check in an item without ticking any checkboxes (regular checkout)
> 
> In these steps you mean 'check out' don't you?
> 
> When I test this I see the "This is a on-site checkout" message for my
> on-site checkout, but for the item which is set for auto-renewal I don't see
> the right message. I just see "No renewals allowed."
> 
> It looks like the template needs to check for 'auto_too_soon' as well as
> 'auto_renew'.

Yes and Yes :)
Thanks for testing!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54626|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 55503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55503=edit
Bug 16873: Improve renewal error messages on self check

When a patron is not allowed to renew from the self check module, the
only message displayed is "No renewals allowed".
It would be nicer to let him/her know that the renewal is not allowed
because it's a on-site checkout or automatic renewal.

To do so we can call CanBookBeRenewed instead of CanBookBeIssued and get
the renewal error.

Test plan:
0/ Switch off AllowSelfCheckReturns
1/ check out an item and tick "auto renewal"
2/ Go on the self check module
=> auto renewal message is displayed
3/ check out an item and tick "on-site checkout"
4/ Go on the self check module
=> on-site checkout message is displayed
5/ check out an item without ticking any checkboxes (regular checkout)
Renew it to reach the max renew allowed
6/ Go on the self check module
=> regular checkout message is displayed
7/ Switch on AllowSelfCheckReturns and repeat previous steps
=> "Return this item" button is displayed in addition of the renewal
error message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
> 1/ check in an item and tick "auto renewal"
> 3/ check in an item and tick "on-site checkout"
> 5/ check in an item without ticking any checkboxes (regular checkout)

In these steps you mean 'check out' don't you?

When I test this I see the "This is a on-site checkout" message for my on-site
checkout, but for the item which is set for auto-renewal I don't see the right
message. I just see "No renewals allowed."

It looks like the template needs to check for 'auto_too_soon' as well as
'auto_renew'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

--- Comment #1 from Jonathan Druart  
---
Created attachment 54626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54626=edit
Bug 16873: Improve renewal error messages on self check

When a patron is not allowed to renew from the self check module, the
only message displayed is "No renewals allowed".
It would be nicer to let him/her know that the renewal is not allowed
because it's a on-site checkout or automatic renewal.

To do so we can call CanBookBeRenewed instead of CanBookBeIssued and get
the renewal error.

Test plan:
0/ Switch off AllowSelfCheckReturns
1/ check in an item and tick "auto renewal"
2/ Go on the self check module
=> auto renewal message is displayed
3/ check in an item and tick "on-site checkout"
4/ Go on the self check module
=> on-site checkout message is displayed
5/ check in an item without ticking any checkboxes (regular checkout)
Renew it to reach the max renew allowed
6/ Go on the self check module
=> regular checkout message is displayed
7/ Switch on AllowSelfCheckReturns and repeat previous steps
=> "Return this item" button is displayed in addition of the renewal
error message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|minor   |normal
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873

Barton Chittenden  changed:

   What|Removed |Added

Summary|Rrenewal error message not  |Renewal error message not
   |specific enough on self |specific enough on self
   |check.  |check.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/