[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Stable|Pushed to Master

--- Comment #11 from Julian Maurice  ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17080


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080
[Bug 17080] Koha::Object->new should handle default values for NOT NULL columns
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Frédéric Demians  changed:

   What|Removed |Added

 Blocks||17034


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034
[Bug 17034] Creating a new patron fails due to DB error
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

--- Comment #10 from Frédéric Demians  ---
Reverted. Shouldn't be in 16.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||frede...@tamil.fr

--- Comment #9 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Kyle M Hall  ---
Pushed to master for 16.11!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #53405|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 53412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53412=edit
Bug 16917 - Error when importing patrons, Column 'checkprevcheckout' cannot be
null

Error:
DBIx::Class::Storage::DBI::_dbh_execute(): Column 'checkprevcheckout'
cannot be null at C4/Members.pm line 697

Test Plan:
1) Attempt to import a patron via csv
2) Note the error
3) Apply this patch
4) Repeat the import
5) No error!

NOTE: Given that all the other tests ran (comment #2), except
  those in comment #3, I resorted to following the test plan
  above using the attachment provided in comment #5. I
  believe the issues in comment #3 constitute other bugs
  which need fixing and are unrelated this bug. Applying the
  patch does resolve the error triggered, and the code is
  good.

Signed-off-by: Mark Tompsett 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

M. Tompsett  changed:

   What|Removed |Added

  Attachment #53378|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 53405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53405=edit
Bug 16917 - Error when importing patrons, Column 'checkprevcheckout' cannot be
null

Error:
DBIx::Class::Storage::DBI::_dbh_execute(): Column 'checkprevcheckout'
cannot be null at C4/Members.pm line 697

Test Plan:
1) Attempt to import a patron via csv
2) Note the error
3) Apply this patch
4) Repeat the import
5) No error!

NOTE: Given that all the other tests ran (comment #2), except
  those in comment #3, I resorted to following the test plan
  above using the attachment provided in comment #5. I
  believe the issues in comment #3 constitute other bugs
  which need fixing and are unrelated this bug. Applying the
  patch does resolve the error triggered, and the code is
  good.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

--- Comment #5 from Kyle M Hall  ---
Created attachment 53398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53398=edit
Test CSV File

This file caused the error for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

--- Comment #4 from M. Tompsett  ---
Please provide a sample patron CSV that triggers issue.
I attempted with checkprevcheckout deleted, and then set to 'null'.
I tried both new and overwrite.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

--- Comment #3 from M. Tompsett  ---
Tracing down failures:
t/db_dependent/Circulation.t
t/db_dependent/DecreaseLoanHighHolds.t
t/db_dependent/Reserves.t
These all fail on master too, so I'll fall back to the provided test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett  ---
I added a line:
 die "TRIGGER!" if !$new_member->{checkprevcheckout};
into C4::Members just above the change, and then ran prove t/db_dependent.

TRIGGERED: t/db_dependent/Budgets.t
TRIGGERED: t/db_dependent/Circulation.t
  RELATED: t/db_dependent/DecreaseLoanHighHolds.t
TRIGGERED: t/db_dependent/Holds.t
TRIGGERED: t/db_dependent/Letters.t
TRIGGERED: t/db_dependent/Members.t
TRIGGERED: t/db_dependent/Ratings.t
TRIGGERED: t/db_dependent/Reserves.t
TRIGGERED: t/db_dependent/Serials_2.t
TRIGGERED: t/db_dependent/Suggestions.t

So, now to remove that line of code and run these tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||16889


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889
[Bug 16889] Move the ::columns subroutines to Koha::Objects->columns
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

--- Comment #1 from Kyle M Hall  ---
Created attachment 53378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53378=edit
Bug 16917 - Error when importing patrons, Column 'checkprevcheckout' cannot be
null

Error:
DBIx::Class::Storage::DBI::_dbh_execute(): Column 'checkprevcheckout'
cannot be null at C4/Members.pm line 697

Test Plan:
1) Attempt to import a patron via csv
2) Note the error
3) Apply this patch
4) Repeat the import
5) No error!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |blocker

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16917] Error when importing patrons, Column 'checkprevcheckout' cannot be null

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16917

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||6906


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906
[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/