[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
  Component|Serials |Templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55199|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 55511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55511=edit
Bug 16967: Remove the use of "onclick" from serial frequency and numbering
management

This patch removes instance of "onclick" from the templates for serial
frequency and numbering management. Events are now defined in the
JavaScript.

To test, apply the patch and go to Serials -> Manage frequencies.

 - In the list of frequencies, click the "Delete" button for a frequency
   which is in use by at least one subscription. In the confirmation
   dialog, clicking the "Show subscriptions" link should display a list
   of titles.
 - Edit or create a frequency.
 - To test that the form submission validation is still working
   correctly, enter non-numeric data in the "issues per unit" field and
   submit the form. This should trigger an error.

In Serials -> Manage numbering patterns:

 - In the list of numbering patterns, click the "Delete" button for a
   pattern which is in use by at least one subscription. In the
   confirmation dialog, clicking the "Show subscriptions" link should
   display a list of titles.
 - Edit or create a numbering pattern.
 - Confirm that the "Test pattern" button works correctly.

Signed-off-by: Hector Castro 
Works as advertised

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
(In reply to Aliki Pavlidou from comment #2)

Hi Aliki


I will answer your question


> - Regarding creating a new numbering pattern, I was trying to create one
> yearly subscription that has 11 issues per year. Do you have any idea how
> could I set this pattern? For example 2015 was the 18th year of this journal
> publication, and July and August was merged into one issue.
> 

Name: 11 volums per year
Description: 11 volums per year

X   Y
Label   YearNo
Add  1  1
Every11 1
Setback 1   1
When..  11

Test prediction pattern
Frequency: 1/month
First issue publication date: 01/01/2015
Subscription length: issues 11


Beggins 20151
with
Inner
couter  1   1

You will get:
Number  Publication date
Year 2015, No. 101/01/2015
Year 2015, No. 201/02/2015
Year 2015, No. 301/03/2015
Year 2015, No. 401/04/2015
Year 2015, No. 501/05/2015
Year 2015, No. 601/06/2015
Year 2015, No. 701/07/2015
Year 2015, No. 801/08/2015
Year 2015, No. 901/09/2015
Year 2015, No. 10   01/10/2015
Year 2016, No. 11   01/11/2015

If this does not always happen, i.e., just one year and the another year came
with 12 issues
You just delete the number not published when you add a new subscription in the
"Prediction pattern"
learn more about this here:


Maybe this isn't the best place to ask, please use the mailing list at
 or the IRC


I hope this helps

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #53663|0   |1
is obsolete||

--- Comment #3 from Héctor Eduardo Castro Avalos  ---
Created attachment 55199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55199=edit
[SIGNED-OFF]Bug 16967: Remove the use of "onclick" from serial frequency and
numbering management

This patch removes instance of "onclick" from the templates for serial
frequency and numbering management. Events are now defined in the
JavaScript.

To test, apply the patch and go to Serials -> Manage frequencies.

 - In the list of frequencies, click the "Delete" button for a frequency
   which is in use by at least one subscription. In the confirmation
   dialog, clicking the "Show subscriptions" link should display a list
   of titles.
 - Edit or create a frequency.
 - To test that the form submission validation is still working
   correctly, enter non-numeric data in the "issues per unit" field and
   submit the form. This should trigger an error.

In Serials -> Manage numbering patterns:

 - In the list of numbering patterns, click the "Delete" button for a
   pattern which is in use by at least one subscription. In the
   confirmation dialog, clicking the "Show subscriptions" link should
   display a list of titles.
 - Edit or create a numbering pattern.
 - Confirm that the "Test pattern" button works correctly.

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

--- Comment #2 from Aliki Pavlidou  ---
Dear Owen,

I've tested 

-> Manage frequencies:

- Everything works just fine. When I've selected to "Delete" a frequency, there
was this message:
This frequency is still used by 2 subscription(s). Do you still want to delete
it?
The list of titles it was also there, after clicking the "Show subscriptions"
link.

- The form submission validation is still working correctly, as I've entered a
non-numeric data (the word: two) in the "issues per unit" field and after
submitting the form, I got back as a result this message:
Some fields are not valid. Issues per unit is required (must be a number
greater than 0).

-> Manage numbering patterns:

- Like before, I tried to "Delete" "Back up pattern1", and the following
message appeared:
This pattern is still used by 2 subscription(s). Do you still want to delete
it?
The list of titles it was also there, after clicking the "Show subscriptions"
link.

- Regarding creating a new numbering pattern, I was trying to create one yearly
subscription that has 11 issues per year. Do you have any idea how could I set
this pattern? For example 2015 was the 18th year of this journal publication,
and July and August was merged into one issue.

Kind regards
Aliki

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Aliki Pavlidou  changed:

   What|Removed |Added

 CC||pavlidoual...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

--- Comment #1 from Owen Leonard  ---
Created attachment 53663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53663=edit
Bug 16967 - Remove the use of "onclick" from serial frequency and numbering
management

This patch removes instance of "onclick" from the templates for serial
frequency and numbering management. Events are now defined in the
JavaScript.

To test, apply the patch and go to Serials -> Manage frequencies.

 - In the list of frequencies, click the "Delete" button for a frequency
   which is in use by at least one subscription. In the confirmation
   dialog, clicking the "Show subscriptions" link should display a list
   of titles.
 - Edit or create a frequency.
 - To test that the form submission validation is still working
   correctly, enter non-numeric data in the "issues per unit" field and
   submit the form. This should trigger an error.

In Serials -> Manage numbering patterns:

 - In the list of numbering patterns, click the "Delete" button for a
   pattern which is in use by at least one subscription. In the
   confirmation dialog, clicking the "Show subscriptions" link should
   display a list of titles.
 - Edit or create a numbering pattern.
 - Confirm that the "Test pattern" button works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/