[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Fridolin Somers changed: What|Removed |Added Blocks||36787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36787 [Bug 36787] staticfines.pl missing use Koha::DateUtils::output_pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Blocks||33937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33937 [Bug 33937] Incorrect export in C4::Members -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Blocks||29951 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951 [Bug 29951] Cannot add splitting rule to classification sources -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Tomás Cohen Arazi changed: What|Removed |Added Blocks||30939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30939 [Bug 30939] remove_unused_authorities.pl is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens changed: What|Removed |Added Blocks||31058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31058 [Bug 31058] Bug 17600 follow-up - fix import in auto_unsuspend_holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Blocks||30926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30926 [Bug 30926] Remove unnecessary use statements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Blocks||30402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402 [Bug 30402] Authority import hanging when replacing matched record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Blocks||30461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461 [Bug 30461] Batch authority tool is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 David Cook changed: What|Removed |Added Blocks||30426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 [Bug 30426] suggestion service missing Auth and Output imports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 [Bug 29865] Wrong includes in circ/returns.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #151 from Jonathan Druart --- (In reply to Jonathan Druart from comment #150) > Created attachment 127918 [details] [review] > Bug 17600: Fix opac/unapi Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #150 from Jonathan Druart --- Created attachment 127918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127918=edit Bug 17600: Fix opac/unapi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Text to go in the||We favored the use of release notes||EXPORT_OK over EXPORT, to ||prevent name clashes and ||make the import explicit. Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Blocks||29469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 [Bug 29469] Error when approving and rejecting tags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens changed: What|Removed |Added Blocks||29435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Joonas Kylmälä changed: What|Removed |Added Blocks||29429 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 [Bug 29429] Cannot close budgets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Blocks||29395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #149 from Jonathan Druart --- (In reply to Owen Leonard from comment #148) > Created attachment 127056 [details] [review] > Bug 17600: Fix imports for GetClassSources in guided_reports.pl > > This will fix the broken option to use cn_source as a runtime > parameter, e.g. <> Pushed to master, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Katrin Fischer changed: What|Removed |Added Resolution|FIXED |--- Status|CLOSED |REOPENED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Katrin Fischer changed: What|Removed |Added Blocks||29351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 [Bug 29351] Add missing cn_source parameter to reports parameter menu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #148 from Owen Leonard --- Created attachment 127056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127056=edit Bug 17600: Fix imports for GetClassSources in guided_reports.pl This will fix the broken option to use cn_source as a runtime parameter, e.g. <> -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #147 from Jonathan Druart --- Last patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #146 from Jonathan Druart --- Created attachment 126640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126640=edit Bug 17600: Fix imports for svc/letters/preview -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Blocks||29207 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 [Bug 29207] Restore Getopt::Long config to not ignore cases -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Peter Vashchuk changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29207 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29197 [Bug 29197] commit_file.pl missing import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_11_candidate,| |RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Attachment #125064|0 |1 is obsolete|| --- Comment #145 from Jonathan Druart --- Created attachment 125066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125066=edit Bug 17600: Fix overdrive_proxy and recordedbooks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens changed: What|Removed |Added Attachment #125063|0 |1 is obsolete|| --- Comment #144 from Nick Clemens --- Created attachment 125064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125064=edit Bug 17600: (follow-up) Fix overdrive_proxy recordedbooks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #143 from Nick Clemens --- Created attachment 125063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125063=edit Bug 17600: (follow-up) Fix overdrive proxy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #142 from Jonathan Druart --- (In reply to Jonathan Druart from comment #141) > Created attachment 125059 [details] [review] > Bug 17600: Remove wrong C4::Context imports Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #141 from Jonathan Druart --- Created attachment 125059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125059=edit Bug 17600: Remove wrong C4::Context imports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #140 from Jonathan Druart --- (In reply to Jonathan Druart from comment #139) > Created attachment 124866 [details] [review] > Bug 17600: Fix opac/svc/overdrive Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #139 from Jonathan Druart --- Created attachment 124866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124866=edit Bug 17600: Fix opac/svc/overdrive -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Blocks||28931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 [Bug 28931] use EXPORT_OK in Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #138 from Jonathan Druart --- (In reply to Jonathan Druart from comment #137) > Created attachment 123565 [details] [review] > Bug 17600: Fix missing imports from mappings.pl > > Signed-off-by: Jonathan Druart Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #137 from Jonathan Druart --- Created attachment 123565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123565=edit Bug 17600: Fix missing imports from mappings.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #136 from Jonathan Druart --- (In reply to Nick Clemens from comment #135) > Created attachment 123420 [details] [review] > Bug 17600: Add missing imports in authorities/ > > Signed-off-by: Nick Clemens Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens changed: What|Removed |Added Attachment #123419|0 |1 is obsolete|| --- Comment #135 from Nick Clemens --- Created attachment 123420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123420=edit Bug 17600: Add missing imports in authorities/ Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Attachment #123418|0 |1 is obsolete|| --- Comment #134 from Jonathan Druart --- Created attachment 123419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123419=edit Bug 17600: Add missing imports in authorities/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #133 from Jonathan Druart --- Created attachment 123418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123418=edit Bug 17600: Add missing imports in authorities/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #132 from Jonathan Druart --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #131 from Jonathan Druart --- Created attachment 123417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123417=edit Bug 17600: Fix GetTagsLabels imports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #130 from Jonathan Druart --- Patch pushed to master, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #129 from Nick Clemens --- Created attachment 123325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123325=edit Bug 17600: (follow-up) Fully qualify routine in cancel_expired_holds.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #128 from Jonathan Druart --- Last 2 patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #127 from Jonathan Druart --- Created attachment 123284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123284=edit Bug 17600: Fix missing C4::AuthoritiesMARC import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #126 from Nick Clemens --- Created attachment 123283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123283=edit Bug 17600: (follow-up) Import GetAuthority in rebuild_zebra -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #125 from Jonathan Druart --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #124 from Jonathan Druart --- Created attachment 123281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123281=edit Bug 17600: Fix POSIX imports it fixes xgettext and (maybe) friends [12:22:29] Error: Command failed: misc/translator/xgettext.pl --charset=UTF-8 -s -o /tmp/koha-Jaa9rf/Koha-marc-NORMARC.pot -f /tmp/koha-Jaa9rf/files /tmp/koha-Jaa9rf/Koha-marc-NORMARC.pot at misc/translator/xgettext.pl line 387. Use of uninitialized value in subroutine entry at misc/translator/xgettext.pl line 388. Argument ">:encoding(utf-8)" isn't numeric in subroutine entry at misc/translator/xgettext.pl line 388. Argument "/tmp/koha-Jaa9rf/Koha-marc-NORMARC.pot" isn't numeric in subroutine entry at misc/translator/xgettext.pl line 388. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #123 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #121) > Created attachment 123210 [details] [review] > Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES > > Signed-off-by: Marcel de Rooy Patch pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #122 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #117) > (In reply to Jonathan Druart from comment #116) > > Created attachment 123196 [details] [review] [review] > > Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES > > Can I get a review on that patch please, before I push it and continue to > mess up with things. > > I think this fixes a problem we had prior to this patch (to confirm!). Both > Locale::Messages and POSIX are exporting LC_MESSAGES. As we explicitly > imported LC_MESSAGES from Locale::Messages I guess it's what we wanted to > do, but POSIX exported it as well and it's the one we got (it's after > Locale::Messages in the use sequence). Looks good to me now. Have the impression that both constants return the same for me.. But when you look at Locale::Messages, this is the way it should be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Marcel de Rooy changed: What|Removed |Added Attachment #123196|0 |1 is obsolete|| --- Comment #121 from Marcel de Rooy --- Created attachment 123210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123210=edit Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens changed: What|Removed |Added Blocks||28763 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28763 [Bug 28763] Undefined subroutine XSLTParse4Display when viewing lists (bug 17600) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #120 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #117) > (In reply to Jonathan Druart from comment #116) > > Created attachment 123196 [details] [review] [review] > > Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES > > Can I get a review on that patch please, before I push it and continue to > mess up with things. > > I think this fixes a problem we had prior to this patch (to confirm!). Both > Locale::Messages and POSIX are exporting LC_MESSAGES. As we explicitly > imported LC_MESSAGES from Locale::Messages I guess it's what we wanted to > do, but POSIX exported it as well and it's the one we got (it's after > Locale::Messages in the use sequence). I will try. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #119 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #114) > (In reply to Katrin Fischer from comment #108) > > Just wondering about the implications of this as I did some easy rebases > > today. Should we ask for new use statements always having the methods used > > added with qw? Should there be a coding guideline/QA test? > > I've tried to explain in the commit message. > Basically you need to > 1. Use EXPORT_OK instead of EXPORT in modules > 2. either > use Module qw( method_1 method_2 ); > method_1(); > > or > use Module; > Module::method_1(); > Probably you still need to differentiate between Koha modules and external CPAN stuff? The use Module statement does still try to import names. If you do 'use Module ()' with empty list, you do NOT import anymore. Actually, you only 'require'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #118 from Jonathan Druart --- Created attachment 123200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123200=edit Bug 17600: Fix t/db_dependent/Members.t Was failing after "Bug 17600: Fix other occurrences in svc" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #117 from Jonathan Druart --- (In reply to Jonathan Druart from comment #116) > Created attachment 123196 [details] [review] > Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES Can I get a review on that patch please, before I push it and continue to mess up with things. I think this fixes a problem we had prior to this patch (to confirm!). Both Locale::Messages and POSIX are exporting LC_MESSAGES. As we explicitly imported LC_MESSAGES from Locale::Messages I guess it's what we wanted to do, but POSIX exported it as well and it's the one we got (it's after Locale::Messages in the use sequence). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #116 from Jonathan Druart --- Created attachment 123196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123196=edit Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #115 from Jonathan Druart --- (In reply to Jonathan Druart from comment #113) > (In reply to Jonathan Druart from comment #112) > > Created attachment 123195 [details] [review] [review] > > Bug 17600: Fix wrong import in Koha::I18N - LC_MESSAGES > > > > $ perl -wc Koha/I18N.pm > > Subroutine Koha::I18N::LC_MESSAGES redefined at Koha/I18N.pm line 36. > > Prototype mismatch: sub Koha::I18N::LC_MESSAGES: none vs () at Koha/I18N.pm > > line 36. > > Koha/I18N.pm syntax OK > > Patch pushed to master. This is totally wrong, we do want to import LC_MESSAGES from Locale::Messages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #114 from Jonathan Druart --- (In reply to Katrin Fischer from comment #108) > Just wondering about the implications of this as I did some easy rebases > today. Should we ask for new use statements always having the methods used > added with qw? Should there be a coding guideline/QA test? I've tried to explain in the commit message. Basically you need to 1. Use EXPORT_OK instead of EXPORT in modules 2. either use Module qw( method_1 method_2 ); method_1(); or use Module; Module::method_1(); Ideally we should pick one version and stick to that. But there is still a mix of both everywhere in the codebase. We don't really need a guideline because: - We must not add new modules to C4 - The EXPORT_OK should be there now, so you have to write the imports/calls correctly of the execution will explode. (In reply to Marcel de Rooy from comment #109) > [WARN] Prototype mismatch: sub Koha::I18N::LC_MESSAGES: none vs () at > /usr/share/koha/Koha/I18N.pm line 36. > > Locale::Messages exports a sub LC_MESSAGES without prototype. > And after we do 'use POSIX;' with a default import that probably includes > LC_MESSAGES from locale_h ? Last patch fixes that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #113 from Jonathan Druart --- (In reply to Jonathan Druart from comment #112) > Created attachment 123195 [details] [review] > Bug 17600: Fix wrong import in Koha::I18N - LC_MESSAGES > > $ perl -wc Koha/I18N.pm > Subroutine Koha::I18N::LC_MESSAGES redefined at Koha/I18N.pm line 36. > Prototype mismatch: sub Koha::I18N::LC_MESSAGES: none vs () at Koha/I18N.pm > line 36. > Koha/I18N.pm syntax OK Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #112 from Jonathan Druart --- Created attachment 123195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123195=edit Bug 17600: Fix wrong import in Koha::I18N - LC_MESSAGES $ perl -wc Koha/I18N.pm Subroutine Koha::I18N::LC_MESSAGES redefined at Koha/I18N.pm line 36. Prototype mismatch: sub Koha::I18N::LC_MESSAGES: none vs () at Koha/I18N.pm line 36. Koha/I18N.pm syntax OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #111 from Jonathan Druart --- (In reply to Jonathan Druart from comment #110) > Created attachment 123194 [details] [review] > Bug 17600: Fix other occurrences in svc Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #110 from Jonathan Druart --- Created attachment 123194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123194=edit Bug 17600: Fix other occurrences in svc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Blocks||28750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens changed: What|Removed |Added Blocks||28758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28758 [Bug 28758] Undefined subroutines in C4/ImportBatch.pm (bug 17600) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #109 from Marcel de Rooy --- [WARN] Prototype mismatch: sub Koha::I18N::LC_MESSAGES: none vs () at /usr/share/koha/Koha/I18N.pm line 36. Locale::Messages exports a sub LC_MESSAGES without prototype. And after we do 'use POSIX;' with a default import that probably includes LC_MESSAGES from locale_h ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #108 from Katrin Fischer --- Just wondering about the implications of this as I did some easy rebases today. Should we ask for new use statements always having the methods used added with qw? Should there be a coding guideline/QA test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens changed: What|Removed |Added Blocks||28731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens changed: What|Removed |Added Blocks||28722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28722 [Bug 28722] tools/batchMod.pl needs to import C4::Ath::haspermission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #107 from Jonathan Druart --- Follow-ups have been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #106 from Jonathan Druart --- Created attachment 122945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122945=edit Bug 17600: Fix batchMod.pl Undefined subroutine ::Compile::ROOT::kohadevbox_koha_tools_batchMod_2epl::haspermission called at /kohadevbox/koha/tools/batchMod.pl line 89 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|CLOSED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #105 from Jonathan Druart --- Created attachment 122884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122884=edit Bug 17600: Fix tests No idea why UpdateStats in C4::Circulation needs the fully qualified namespace! I kept getting Undefined subroutine ::Circulation::UpdateStats called at /kohadevbox/koha/C4/Circulation.pm line 1643. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master --- Comment #104 from Jonathan Druart --- Patch pushed to master for 21.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600
--- Comment #103 from Jonathan Druart ---
Created attachment 122869
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122869=edit
Bug 17600: Standardize our EXPORT_OK
On bug 17591 we discovered that there was something weird going on with
the way we export and use subroutines/modules.
This patch tries to standardize our EXPORT to use EXPORT_OK only.
That way we will need to explicitely define the subroutine we want to
use from a module.
This patch is a squashed version of:
Bug 17600: After export.pl
Bug 17600: After perlimport
Bug 17600: Manual changes
Bug 17600: Other manual changes after second perlimports run
Bug 17600: Fix tests
And a lot of other manual changes.
export.pl is a dirty script that can be found on bug 17600.
"perlimport" is:
git clone https://github.com/oalders/App-perlimports.git
cd App-perlimports/
cpanm --installdeps .
export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib"
find . \( -name "*.pl" -o -name "*.pm" \) -exec perl
App-perlimports/script/perlimports --inplace-edit --no-preserve-unused
--filename {} \;
The ideas of this patch are to:
* use EXPORT_OK instead of EXPORT
* perltidy the EXPORT_OK list
* remove '&' before the subroutine names
* remove some uneeded use statements
* explicitely import the subroutines we need within the controllers or
modules
Note that the private subroutines (starting with _) should not be
exported (and not used from outside of the module except from tests).
EXPORT vs EXPORT_OK (from
https://www.thegeekstuff.com/2010/06/perl-exporter-examples/)
"""
Export allows to export the functions and variables of modules to user’s
namespace using the standard import method. This way, we don’t need to create
the objects for the modules to access it’s members.
@EXPORT and @EXPORT_OK are the two main variables used during export operation.
@EXPORT contains list of symbols (subroutines and variables) of the module to
be exported into the caller namespace.
@EXPORT_OK does export of symbols on demand basis.
"""
If this patch caused a conflict with a patch you wrote prior to its
push:
* Make sure you are not reintroducing a "use" statement that has been
removed
* "$subroutine" is not exported by the C4::$MODULE module
means that you need to add the subroutine to the @EXPORT_OK list
* Bareword "$subroutine" not allowed while "strict subs"
means that you didn't imported the subroutine from the module:
- use $MODULE qw( $subroutine list );
You can also use the fully qualified namespace: C4::$MODULE::$subroutine
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #102 from Jonathan Druart --- Joubu> Asking again for the Xth times "Do we need bug 17600 (Standardize the EXPORT) or not?" ashimema> I like it ashimema> and have tested... Joubu> It's now or never, basically ashimema> I'd go for it ashimema> personally Joubu> I don't need stamps on it, only a "go for it" is enough :) Joubu> "I will push it at the beginning of July, regardless of its status, if there is no objection before." Joubu> this is what I actually sent to the QA team a couple of weeks ago Joubu> but I am feeling a bit ashamed to push such big changes with a NSO status Joubu> marcelr, kidclamp, khall, jajm, tcohen, you all agree with that, right? ^ marcelr> Joubu you promised it marcelr> wait and begin of July takes another year khall> go for it marcelr> we have 4 months for cleanup haha Joubu> Thanks, I didn't need more. A short "go" is better than silence ;) jajm> Joubu, go go go! Joubu> I will quote you all on the bug :D ashimema> go :) ashimema> I did do a chunk of testing so take my SO tcohen> Joubu add my stamp tcohen> I tested it in the early ages tcohen> and am sure we can fix whatever arises -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #101 from Jonathan Druart --- (In reply to Martin Renvoize from comment #100) > We have the compile test failing at the moment.. I'll try to find a moment > to dig further into this.. but I'm not sure when that will happen :( Fixed! Remote branch updated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #100 from Martin Renvoize --- We have the compile test failing at the moment.. I'll try to find a moment to dig further into this.. but I'm not sure when that will happen :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #99 from Martin Renvoize --- This remote branch is looking great to me.. it just 'feels cleaner' as a whole. I'm just running the test suit against it locally and playing around a bit to see if I spot any obvious issues now.. Thanks for all the hard work Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #98 from Jonathan Druart --- Please test the remote branch - https://gitlab.com/joubu/Koha/-/tree/bug_17600_new -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Attachment #122365|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Attachment #122364|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Attachment #122363|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Attachment #122362|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Attachment #122361|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Attachment #122360|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #97 from Jonathan Druart --- Created attachment 122365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122365=edit Bug 17600: Other manual changes after second perlimports run -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600
--- Comment #96 from Jonathan Druart ---
Created attachment 122364
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122364=edit
Bug 17600: after perlimports pm
Was missing the pm
find . \( -name "*.pl" -o -name "*.pm" \) -exec perl
App-perlimports/script/perlimports --inplace-edit --no-preserve-unused
--filename {} \;
TODO: Restore permissions
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #95 from Jonathan Druart --- Created attachment 122363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122363=edit Bug 17600: Manual changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600
--- Comment #94 from Jonathan Druart ---
Created attachment 122362
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122362=edit
Bug 17600: After perlimports
find . -name '*.pm' -o -name '*.pl' -exec perl
App-perlimports/script/perlimports --inplace-edit --no-preserve-unused
--filename {} \;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #93 from Jonathan Druart --- Created attachment 122361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122361=edit Bug 17600: After export.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Attachment #121309|0 |1 is obsolete|| Attachment #121310|0 |1 is obsolete|| Attachment #121311|0 |1 is obsolete|| Attachment #121312|0 |1 is obsolete|| Attachment #121313|0 |1 is obsolete|| Attachment #121314|0 |1 is obsolete|| --- Comment #92 from Jonathan Druart --- Created attachment 122360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122360=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_11_candidate, ||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #91 from Jonathan Druart --- Created attachment 121314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121314=edit Bug 17600: Other manual changes after second perlimports run -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
