[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||This feature integrates
  release notes||RecordedBooks functionality
   ||into the catalog, following
   ||the model of OverDrive.
   ||
   ||Searches on the opac will
   ||return a link to results in
   ||the RecordedBooks catalog
   ||if they are found. From
   ||that results pagea user
   ||that is signed in and has a
   ||valid email matching a
   ||RecordedBooks account will
   ||be able to checkout the
   ||books directly from the
   ||results, and download them
   ||via their account page on
   ||the opac. Users will also
   ||be able to place holds on
   ||unavailable items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #132 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #130 from Jonathan Druart  
---
Created attachment 79681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79681=edit
Bug 17602: (QA follow-up) Fix tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #128 from Jonathan Druart  
---
Created attachment 79679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79679=edit
Bug 17602: (follow-up) Adjust js paths to use version add spinner

Also included recompiled version of opac.css that we forgot.

Signed-off-by: Srdjan 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #131 from Jonathan Druart  
---
Created attachment 79682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79682=edit
Bug 17602: Move spinner location to include file

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #129 from Jonathan Druart  
---
Created attachment 79680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79680=edit
Bug 17602: Use Asset TT plugin and fix indentation

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #123 from Jonathan Druart  
---
Created attachment 79674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79674=edit
Bug 17602: Adapt test plan to make the tests pass

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #127 from Jonathan Druart  
---
Created attachment 79678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79678=edit
Bug 17602: Removed unused param to RecordedBooks API

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #126 from Jonathan Druart  
---
Created attachment 79677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79677=edit
Bug 17602: fix RecordedBooks results pagination

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #122 from Jonathan Druart  
---
Created attachment 79673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79673=edit
Bug 17602: Handle '60+' if there are more than 60 results

The service returns "60+" if there are more than 60 results.
Without this patch the "Found %s results in RecordedBooks collection"
line is removed.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #124 from Jonathan Druart  
---
Created attachment 79675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79675=edit
Bug 17602: Fix few minor QA issues

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #125 from Jonathan Druart  
---
Created attachment 79676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79676=edit
Bug 17602: Translations rework

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #118 from Jonathan Druart  
---
Created attachment 79669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79669=edit
Bug 17602: RecordedBooks Integration to Koha

This patch introduces the required sysprefs and
Koha::ExternalContent::RecordedBooks

Koha::ExternalContent::RecordedBooks - a wrapper around
WebService::ILS::RecordedBooks::PartnerPatron

RecordedBooks* sysprefs

Nothing functional to test with this patch yet.
But you can run the tests that come with it

 t/db_dependent/Koha_ExternalContent_RecordedBooks.t

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #120 from Jonathan Druart  
---
Created attachment 79671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79671=edit
Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #119 from Jonathan Druart  
---
Created attachment 79670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79670=edit
Bug 17602: OPAC integration of RecordedBooks

Add RecordedBooks to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
RecordedBooks)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #121 from Jonathan Druart  
---
Created attachment 79672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79672=edit
Bug 17602: Ease translation

Use String.format() to make translation easier

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #78602|0   |1
is obsolete||
  Attachment #78603|0   |1
is obsolete||
  Attachment #78604|0   |1
is obsolete||
  Attachment #78605|0   |1
is obsolete||
  Attachment #78606|0   |1
is obsolete||
  Attachment #78607|0   |1
is obsolete||
  Attachment #78608|0   |1
is obsolete||
  Attachment #78609|0   |1
is obsolete||
  Attachment #78610|0   |1
is obsolete||
  Attachment #78611|0   |1
is obsolete||
  Attachment #78612|0   |1
is obsolete||
  Attachment #78613|0   |1
is obsolete||
  Attachment #78614|0   |1
is obsolete||
  Attachment #78615|0   |1
is obsolete||
  Attachment #79247|0   |1
is obsolete||

--- Comment #117 from Jonathan Druart  
---
Created attachment 79668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79668=edit
Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than
die if user not logged in

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #116 from Nick Clemens  ---
Created attachment 79247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79247=edit
Bug 17602: Move spinner location to include file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #115 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #85)
> 1. Maybe add a ref to OneClickdigital in the pref?
>  "No system preferences matched your search for: OneClickdigital"
> (not blocking)

They are changing the name over to RecordedBooks, I think we should stick with
this
> 
> 2. Found 241+ results in the library's RecordedBooks collection
> "+" ?

This is a function of the values returned from the API, unfortunate but not in
our control

> 
> 3. /opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif
> must be using [% theme %]/[% interface %]

This stil needs to be fixed, these lines are in the js file so don't have
template variables
> 
> 4. In the checkout list there is a link .epub (below "downloads"), but it
> downloads a .acsm file (??) Is it expected?

Yes, due to DRM you must get your epub via the adobe app which  uses acsm
> 
> 5. expires.toLocaleString() does not work what you are expecting, the date
> is always displayed in the same format (do not depend on dateformat)

This is what exists in the code for overdrive currently I believe - fix on a
future bug?


> 
> 6. https://screenshots.firefox.com/C5OmithULkvMQtTe/catalogue.kohadev.org
> "Check out" and "Place hold" button are too close and not well styled (not
> blocking)

I will ask Owen for an eye

> 
> 7. Place hold, hit cgi-bin/koha/opac-user.pl, cancel the hold. The hold is
> still listed (not blocking)

Let's leave as improvement
> 
> 8. /cgi-bin/koha/opac-recordedbooks-search.pl?q=d
> click on an image,
> https://carnegiestoutia.oneclickdigital.com/#titles/9781470360603 => "Your
> connection is not secure", awesome...

This is a configuratio issue - testing link used *.oneclickdigital.com - should
now use *.rbdigital.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #114 from Nick Clemens  ---
Created attachment 78615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78615=edit
Bug 17602: (QA follow-up) Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #111 from Nick Clemens  ---
Created attachment 78612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78612=edit
Bug 17602: Removed unused param to RecordedBooks API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #107 from Nick Clemens  ---
Created attachment 78608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78608=edit
Bug 17602: Adapt test plan to make the tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #109 from Nick Clemens  ---
Created attachment 78610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78610=edit
Bug 17602: Translations rework

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #113 from Nick Clemens  ---
Created attachment 78614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78614=edit
Bug 17602: Use Asset TT plugin and fix indentation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #110 from Nick Clemens  ---
Created attachment 78611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78611=edit
Bug 17602: fix RecordedBooks results pagination

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #106 from Nick Clemens  ---
Created attachment 78607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78607=edit
Bug 17602: Handle '60+' if there are more than 60 results

The service returns "60+" if there are more than 60 results.
Without this patch the "Found %s results in RecordedBooks collection"
line is removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #108 from Nick Clemens  ---
Created attachment 78609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78609=edit
Bug 17602: Fix few minor QA issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #112 from Nick Clemens  ---
Created attachment 78613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78613=edit
Bug 17602: (follow-up) Adjust js paths to use version add spinner

Also included recompiled version of opac.css that we forgot.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #105 from Nick Clemens  ---
Created attachment 78606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78606=edit
Bug 17602: Ease translation

Use String.format() to make translation easier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

  Attachment #76180|0   |1
is obsolete||
  Attachment #76181|0   |1
is obsolete||
  Attachment #76182|0   |1
is obsolete||
  Attachment #76183|0   |1
is obsolete||
  Attachment #76184|0   |1
is obsolete||
  Attachment #76185|0   |1
is obsolete||
  Attachment #76186|0   |1
is obsolete||
  Attachment #76187|0   |1
is obsolete||
  Attachment #76188|0   |1
is obsolete||
  Attachment #76189|0   |1
is obsolete||
  Attachment #76190|0   |1
is obsolete||
  Attachment #76191|0   |1
is obsolete||
  Attachment #76192|0   |1
is obsolete||
  Attachment #76193|0   |1
is obsolete||

--- Comment #101 from Nick Clemens  ---
Created attachment 78602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78602=edit
Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than
die if user not logged in

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #102 from Nick Clemens  ---
Created attachment 78603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78603=edit
Bug 17602: RecordedBooks Integration to Koha

This patch introduces the required sysprefs and
Koha::ExternalContent::RecordedBooks

Koha::ExternalContent::RecordedBooks - a wrapper around
WebService::ILS::RecordedBooks::PartnerPatron

RecordedBooks* sysprefs

Nothing functional to test with this patch yet.
But you can run the tests that come with it

 t/db_dependent/Koha_ExternalContent_RecordedBooks.t

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #104 from Nick Clemens  ---
Created attachment 78605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78605=edit
Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #103 from Nick Clemens  ---
Created attachment 78604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78604=edit
Bug 17602: OPAC integration of RecordedBooks

Add RecordedBooks to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
RecordedBooks)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #100 from Jonathan Druart  
---
Please keep changes to opac.css in a separated patch to ease rebases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #96 from Jonathan Druart  
---
Created attachment 76190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76190=edit
Bug 17602: Removed unused param to RecordedBooks API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #98 from Jonathan Druart  
---
Created attachment 76192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76192=edit
Bug 17602: update compiled opac.css

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #99 from Jonathan Druart  
---
Created attachment 76193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76193=edit
Bug 17602: Use Asset TT plugin and fix indentation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #95 from Jonathan Druart  
---
Created attachment 76189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76189=edit
Bug 17602: fix RecordedBooks results pagination

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #97 from Jonathan Druart  
---
Created attachment 76191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76191=edit
Bug 17602: (follow-up) Adjust js paths to use version add spinner

Also included recompiled version of opac.css that we forgot.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #92 from Jonathan Druart  
---
Created attachment 76186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76186=edit
Bug 17602: Adapt test plan to make the tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #93 from Jonathan Druart  
---
Created attachment 76187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76187=edit
Bug 17602: Fix few minor QA issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #88 from Jonathan Druart  
---
Created attachment 76182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76182=edit
Bug 17602: OPAC integration of RecordedBooks

Add RecordedBooks to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
RecordedBooks)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #94 from Jonathan Druart  
---
Created attachment 76188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76188=edit
Bug 17602: Translations rework

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #89 from Jonathan Druart  
---
Created attachment 76183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76183=edit
Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #90 from Jonathan Druart  
---
Created attachment 76184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76184=edit
Bug 17602: Ease translation

Use String.format() to make translation easier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #73708|0   |1
is obsolete||
  Attachment #73709|0   |1
is obsolete||
  Attachment #73710|0   |1
is obsolete||
  Attachment #73711|0   |1
is obsolete||
  Attachment #73712|0   |1
is obsolete||
  Attachment #73713|0   |1
is obsolete||
  Attachment #73714|0   |1
is obsolete||
  Attachment #73715|0   |1
is obsolete||
  Attachment #73716|0   |1
is obsolete||
  Attachment #73717|0   |1
is obsolete||
  Attachment #73718|0   |1
is obsolete||
  Attachment #73725|0   |1
is obsolete||

--- Comment #86 from Jonathan Druart  
---
Created attachment 76180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76180=edit
Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than
die if user not logged in

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #91 from Jonathan Druart  
---
Created attachment 76185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76185=edit
Bug 17602: Handle '60+' if there are more than 60 results

The service returns "60+" if there are more than 60 results.
Without this patch the "Found %s results in RecordedBooks collection"
line is removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #87 from Jonathan Druart  
---
Created attachment 76181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76181=edit
Bug 17602: RecordedBooks Integration to Koha

This patch introduces the required sysprefs and
Koha::ExternalContent::RecordedBooks

Koha::ExternalContent::RecordedBooks - a wrapper around
WebService::ILS::RecordedBooks::PartnerPatron

RecordedBooks* sysprefs

Nothing functional to test with this patch yet.
But you can run the tests that come with it

 t/db_dependent/Koha_ExternalContent_RecordedBooks.t

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #85 from Jonathan Druart  
---
1. Maybe add a ref to OneClickdigital in the pref?
 "No system preferences matched your search for: OneClickdigital"
(not blocking)

2. Found 241+ results in the library's RecordedBooks collection
"+" ?

3. /opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif
must be using [% theme %]/[% interface %]

4. In the checkout list there is a link .epub (below "downloads"), but it
downloads a .acsm file (??) Is it expected?

5. expires.toLocaleString() does not work what you are expecting, the date is
always displayed in the same format (do not depend on dateformat)

6. https://screenshots.firefox.com/C5OmithULkvMQtTe/catalogue.kohadev.org
"Check out" and "Place hold" button are too close and not well styled (not
blocking)

7. Place hold, hit cgi-bin/koha/opac-user.pl, cancel the hold. The hold is
still listed (not blocking)

8. /cgi-bin/koha/opac-recordedbooks-search.pl?q=d
click on an image,
https://carnegiestoutia.oneclickdigital.com/#titles/9781470360603 => "Your
connection is not secure", awesome...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #73719|0   |1
is obsolete||

--- Comment #84 from Srdjan Jankovic  ---
Created attachment 73725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73725=edit
Bug 17602: (follow-up) Adjust js paths to use version add spinner

Also included recompiled version of opac.css that we forgot.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #82 from Nick Clemens  ---
Created attachment 73718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73718=edit
Bug 17602: Removed unused param to RecordedBooks API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #83 from Nick Clemens  ---
Created attachment 73719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73719=edit
Bug 17602: (follow-up) Adjust js paths to use version add spinner

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #80 from Nick Clemens  ---
Created attachment 73716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73716=edit
Bug 17602: Translations rework

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #79 from Nick Clemens  ---
Created attachment 73715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73715=edit
Bug 17602: Fix few minor QA issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #81 from Nick Clemens  ---
Created attachment 73717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73717=edit
Bug 17602: fix RecordedBooks results pagination

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #78 from Nick Clemens  ---
Created attachment 73714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73714=edit
Bug 17602: Adapt test plan to make the tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #77 from Nick Clemens  ---
Created attachment 73713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73713=edit
Bug 17602: Handle '60+' if there are more than 60 results

The service returns "60+" if there are more than 60 results.
Without this patch the "Found %s results in RecordedBooks collection"
line is removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #76 from Nick Clemens  ---
Created attachment 73712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73712=edit
Bug 17602: Ease translation

Use String.format() to make translation easier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #75 from Nick Clemens  ---
Created attachment 73711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73711=edit
Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #73 from Nick Clemens  ---
Created attachment 73709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73709=edit
Bug 17602: RecordedBooks Integration to Koha

This patch introduces the required sysprefs and
Koha::ExternalContent::RecordedBooks

Koha::ExternalContent::RecordedBooks - a wrapper around
WebService::ILS::RecordedBooks::PartnerPatron

RecordedBooks* sysprefs

Nothing functional to test with this patch yet.
But you can run the tests that come with it

 t/db_dependent/Koha_ExternalContent_RecordedBooks.t

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

  Attachment #69019|0   |1
is obsolete||
  Attachment #69020|0   |1
is obsolete||
  Attachment #69021|0   |1
is obsolete||
  Attachment #69022|0   |1
is obsolete||
  Attachment #69023|0   |1
is obsolete||
  Attachment #69024|0   |1
is obsolete||
  Attachment #69025|0   |1
is obsolete||
  Attachment #69026|0   |1
is obsolete||
  Attachment #69027|0   |1
is obsolete||
  Attachment #69357|0   |1
is obsolete||
  Attachment #69358|0   |1
is obsolete||
  Attachment #69359|0   |1
is obsolete||

--- Comment #72 from Nick Clemens  ---
Created attachment 73708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73708=edit
Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than
die if user not logged in

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #74 from Nick Clemens  ---
Created attachment 73710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73710=edit
Bug 17602: OPAC integration of RecordedBooks

Add RecordedBooks to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
RecordedBooks)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #71 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #64)
> (In reply to Srdjan Jankovic from comment #63)
> > (In reply to Jonathan Druart from comment #61)
> > > Some additional remarks:
> > > 1. At some point I got the following error:
> > > {"error":"Checkout item already exists"}Status: 200 OK
> > 
> > I have to let Nick decide on that one
> 
> Nick?
> 
I was not able to recreate the error, a spinner would be nice here to indicate
action is being performed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #70 from Srdjan Jankovic  ---
(In reply to Jonathan Druart from comment #64)

> > > 2. Strings from .js files are not translatable, `git grep MSG_` to know 
> > > how
> > > to make them translatable.
> > 
> > Done. Please let me know if it's not what you had in mind.
> 
> I am not sure to understand what you did, I already fixed the some
> translations (patch "Bug 17602: Ease translation") from .tt, you needed to
> fix the strings in .js files (.inc and .tt were ok)

This should be fine now.

> 
> > > 3. I see code related to pagination, but I do not see the previous/next
> > > buttons. I only see the OPACnumSearchResults first results.
> > 
> > Yes, at some stage the idea was to integrate all external searches into the
> > main results page, so I stopped short of implementing paging - will be
> > thrown away. Is it acceptable to leave as is?
> 
> I do not think we should integrate code that is not used.

Actually that was a bug. Fixed.

> 
> > > And a question:
> > > Koha/ExternalContent/RecordedBooks.pm
> > >  76 user_agent_params => { agent => $class->agent_string }
> > > Where is this used?
> > 
> > It is a param for WebService::ILS. Cannot remember any more, possibly was a
> > requirement for a provider that even did not get implemented.
> 
> So we remove?

Removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #68 from Srdjan Jankovic  ---
Created attachment 69358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69358=edit
Bug 17602: fix RecordedBooks results pagination

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #69 from Srdjan Jankovic  ---
Created attachment 69359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69359=edit
Bug 17602: Removed unused param to RecordedBooks API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #69101|0   |1
is obsolete||

--- Comment #67 from Srdjan Jankovic  ---
Created attachment 69357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69357=edit
Bug 17602: Translations rework

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #66 from Tomás Cohen Arazi  ---
(In reply to Srdjan Jankovic from comment #65)
> (In reply to Jonathan Druart from comment #64)
> 
> > I am not sure to understand what you did, I already fixed the some
> > translations (patch "Bug 17602: Ease translation") from .tt, you needed to
> > fix the strings in .js files (.inc and .tt were ok)
> 
> Right. Ok, before I do that. how do we handle messages that are the same in
> both OPAC and intranet?

I suggest you just duplicate them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #65 from Srdjan Jankovic  ---
(In reply to Jonathan Druart from comment #64)

> I am not sure to understand what you did, I already fixed the some
> translations (patch "Bug 17602: Ease translation") from .tt, you needed to
> fix the strings in .js files (.inc and .tt were ok)

Right. Ok, before I do that. how do we handle messages that are the same in
both OPAC and intranet?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #64 from Jonathan Druart  
---
(In reply to Srdjan Jankovic from comment #63)
> (In reply to Jonathan Druart from comment #61)
> > Some additional remarks:
> > 1. At some point I got the following error:
> > {"error":"Checkout item already exists"}Status: 200 OK
> 
> I have to let Nick decide on that one

Nick?

> > 2. Strings from .js files are not translatable, `git grep MSG_` to know how
> > to make them translatable.
> 
> Done. Please let me know if it's not what you had in mind.

I am not sure to understand what you did, I already fixed the some translations
(patch "Bug 17602: Ease translation") from .tt, you needed to fix the strings
in .js files (.inc and .tt were ok)

> > 3. I see code related to pagination, but I do not see the previous/next
> > buttons. I only see the OPACnumSearchResults first results.
> 
> Yes, at some stage the idea was to integrate all external searches into the
> main results page, so I stopped short of implementing paging - will be
> thrown away. Is it acceptable to leave as is?

I do not think we should integrate code that is not used.

> > And a question:
> > Koha/ExternalContent/RecordedBooks.pm
> >  76 user_agent_params => { agent => $class->agent_string }
> > Where is this used?
> 
> It is a param for WebService::ILS. Cannot remember any more, possibly was a
> requirement for a provider that even did not get implemented.

So we remove?

Moving out the NSO queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #63 from Srdjan Jankovic  ---
(In reply to Jonathan Druart from comment #61)
> Some additional remarks:
> 1. At some point I got the following error:
> {"error":"Checkout item already exists"}Status: 200 OK

I have to let Nick decide on that one

> 2. Strings from .js files are not translatable, `git grep MSG_` to know how
> to make them translatable.

Done. Please let me know if it's not what you had in mind.

> 3. I see code related to pagination, but I do not see the previous/next
> buttons. I only see the OPACnumSearchResults first results.

Yes, at some stage the idea was to integrate all external searches into the
main results page, so I stopped short of implementing paging - will be thrown
away. Is it acceptable to leave as is?

> 
> And a question:
> Koha/ExternalContent/RecordedBooks.pm
>  76 user_agent_params => { agent => $class->agent_string }
> Where is this used?

It is a param for WebService::ILS. Cannot remember any more, possibly was a
requirement for a provider that even did not get implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #62 from Srdjan Jankovic  ---
Created attachment 69101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69101=edit
Bug 17602: Translations rework

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #61 from Jonathan Druart  
---
Some additional remarks:
1. At some point I got the following error:
{"error":"Checkout item already exists"}Status: 200 OK
Pragma: no-cache
X-frame-options: SAMEORIGIN
Cache-control: no-cache
Content-Type: application/json; charset=UTF-8

{"action":null,"is_identified":true,"error":"ARRAY(0xbb2fe50)"}

When I clicked several time on the "checkout" button.
I think we should hide them or add a spinner to tell the user something is
going on.

2. Strings from .js files are not translatable, `git grep MSG_` to know how to
make them translatable.

3. I see code related to pagination, but I do not see the previous/next
buttons. I only see the OPACnumSearchResults first results.

And a question:
Koha/ExternalContent/RecordedBooks.pm
 76 user_agent_params => { agent => $class->agent_string }
Where is this used?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #60 from Jonathan Druart  
---
Created attachment 69027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69027=edit
Bug 17602: Fix few minor QA issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #58 from Jonathan Druart  
---
Created attachment 69025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69025=edit
Bug 17602: Handle '60+' if there are more than 60 results

The service returns "60+" if there are more than 60 results.
Without this patch the "Found %s results in RecordedBooks collection"
line is removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #55 from Jonathan Druart  
---
Created attachment 69022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69022=edit
Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #67237|0   |1
is obsolete||
  Attachment #67238|0   |1
is obsolete||
  Attachment #67240|0   |1
is obsolete||
  Attachment #67859|0   |1
is obsolete||

--- Comment #52 from Jonathan Druart  
---
Created attachment 69019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69019=edit
Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than
die if user not logged in

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #59 from Jonathan Druart  
---
Created attachment 69026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69026=edit
Bug 17602: Adapt test plan to make the tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #56 from Jonathan Druart  
---
Created attachment 69023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69023=edit
Bug 17602: Update opac.css

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #57 from Jonathan Druart  
---
Created attachment 69024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69024=edit
Bug 17602: Ease translation

Use String.format() to make translation easier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #54 from Jonathan Druart  
---
Created attachment 69021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69021=edit
Bug 17602: OPAC integration of RecordedBooks

Add RecordedBooks to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
RecordedBooks)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #53 from Jonathan Druart  
---
Created attachment 69020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69020=edit
Bug 17602: RecordedBooks Integration to Koha

This patch introduces the required sysprefs and
Koha::ExternalContent::RecordedBooks

Koha::ExternalContent::RecordedBooks - a wrapper around
WebService::ILS::RecordedBooks::PartnerPatron

RecordedBooks* sysprefs

Nothing functional to test with this patch yet.
But you can run the tests that come with it

 t/db_dependent/Koha_ExternalContent_RecordedBooks.t

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #51 from Srdjan Jankovic  ---
(In reply to Jonathan Druart from comment #48)

> _("Found %s results in the library's RecordedBooks
> collection.").format(data.total)
> 
> But it was a not for myself.

Did not know how we store translatables. Want me to change it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #67860|0   |1
is obsolete||

--- Comment #50 from Srdjan Jankovic  ---
Comment on attachment 67860
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67860
t/Koha_ExternalContent_OverDrive.t correction

Obsoleted by 18851

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #49 from Jonathan Druart  
---
(In reply to Srdjan Jankovic from comment #43)
> Created attachment 67860 [details] [review]
> t/Koha_ExternalContent_OverDrive.t correction

Why this change?
See commit c1185533c61e8266f9d89136e8e0debddf71d497
Bug 18851: Make OverDrive.T pass if dbms is not running

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #48 from Jonathan Druart  
---
(In reply to Srdjan Jankovic from comment #47)
> (In reply to Jonathan Druart from comment #46)
> > Quick note: use String.format() when needed.
> 
> Money or somewhere else?

Hum? Money?
I am talking about that kind of generated strings:
$( '#recordedbooks-status' ).html( '' + _("Found") + ' ' + data.total +
' ' + _("results in the library's RecordedBooks collection.") + '' );

should be

_("Found %s results in the library's RecordedBooks
collection.").format(data.total)

But it was a not for myself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #47 from Srdjan Jankovic  ---
(In reply to Jonathan Druart from comment #46)
> Quick note: use String.format() when needed.

Money or somewhere else?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #46 from Jonathan Druart  
---
Quick note: use String.format() when needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #45 from Srdjan Jankovic  ---
I've added a patch with some limited value. And another seemingly unrelated,
which you may choose to apply or drop depending on the policies/feelings.

My position is that as is any proper automated testing would be difficult and
expensive in terms of effort. Considering it is a niche area, I doubt it is
worth it. If it is any comfort you can take my word that automated tests for
WebService::ILS are passing.
It is unfortunate that I started this work at the time when api was not
established. The right thing would be to move svc code to api/v1, at which
point it would be much easier and make sense to do Mojo tests. But again, would
it be worth the effort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #44 from Chris Cormack  ---
(In reply to Jonathan Druart from comment #41)
> (In reply to Tomás Cohen Arazi from comment #39)
> > Regarding the whole patchset, I'd say tests coverage is not good enough. And
> > having the tests require valid credentials for the proprietary external
> > system seems too much. There are two options IMHO:
> > 
> > - If the provider does have a sandbox/testbed infrastructure, use it
> > - If it doesn't, keep the tests (which skip if credentials are missing) but
> > add new db-independent tests with mocked behaviour for WebService::ILS.
> > Auth_with_ldap.t can be a good source of examples for completely mocking the
> > tests.
> 
> Chris, Srdjan, any ideas how we could improve that?
> Can someone share the test credentials with me?

We have no contractual relationship, or any clients who use it. It is probably
best to talk to Bywater or someone who have clients that might have a test
account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #43 from Srdjan Jankovic  ---
Created attachment 67860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67860=edit
t/Koha_ExternalContent_OverDrive.t correction

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #42 from Srdjan Jankovic  ---
Created attachment 67859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67859=edit
Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #41 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #39)
> Regarding the whole patchset, I'd say tests coverage is not good enough. And
> having the tests require valid credentials for the proprietary external
> system seems too much. There are two options IMHO:
> 
> - If the provider does have a sandbox/testbed infrastructure, use it
> - If it doesn't, keep the tests (which skip if credentials are missing) but
> add new db-independent tests with mocked behaviour for WebService::ILS.
> Auth_with_ldap.t can be a good source of examples for completely mocking the
> tests.

Chris, Srdjan, any ideas how we could improve that?
Can someone share the test credentials with me?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/