[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Katrin Fischer changed: What|Removed |Added Status|Pushed to Master|RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |FIXED --- Comment #7 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Marcel de Rooy changed: What|Removed |Added Attachment #57970|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 58625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58625&action=edit Bug 17629: Koha::Biblio - Remove ModBiblioframework There is only one call to C4::Biblio::ModBiblioframework, it's called just before C4::Biblio::ModBiblio in cataloguing/addbiblio.pl At first glance this call does not seems useful: all the subroutines called from ModBiblio send the frameworkcode in parameter. I'd go to remove it, but I'd like to get confirmation by others. No test plan here, you need a good pair of eyes and deep into the C4::Biblio code. Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Framework is updated in at least two other subs, the framework is passed in to the subs and not pulled from the record so I don't see any problem with not updating it first. Editing a record works, updating framework works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Nick Clemens changed: What|Removed |Added Attachment #57955|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 57970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57970&action=edit Bug 17629: Koha::Biblio - Remove ModBiblioframework There is only one call to C4::Biblio::ModBiblioframework, it's called just before C4::Biblio::ModBiblio in cataloguing/addbiblio.pl At first glance this call does not seems useful: all the subroutines called from ModBiblio send the frameworkcode in parameter. I'd go to remove it, but I'd like to get confirmation by others. No test plan here, you need a good pair of eyes and deep into the C4::Biblio code. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Jonathan Druart changed: What|Removed |Added Attachment #57487|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 57955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57955&action=edit Bug 17629: Koha::Biblio - Remove ModBiblioframework There is only one call to C4::Biblio::ModBiblioframework, it's called just before C4::Biblio::ModBiblio in cataloguing/addbiblio.pl At first glance this call does not seems useful: all the subroutines called from ModBiblio send the frameworkcode in parameter. I'd go to remove it, but I'd like to get confirmation by others. No test plan here, you need a good pair of eyes and deep into the C4::Biblio code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 --- Comment #1 from Jonathan Druart --- Created attachment 57487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57487&action=edit Bug 17629: Koha::Biblio - Remove ModBiblioframework There is only one call to C4::Biblio::ModBiblioframework, it's called just before C4::Biblio::ModBiblio in cataloguing/addbiblio.pl At first glance this call does not seems useful: all the subroutines called from ModBiblio send the frameworkcode in parameter. I'd go to remove it, but I'd like to get confirmation by others. No test plan here, you need a good pair of eyes and deep into the C4::Biblio code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
