[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 --- Comment #8 from Kyle M Hall --- Followup pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 57560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57560&action=edit Bug 17633: (QA followup) remove debugging leftover Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan, Tomas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 57510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57510&action=edit Bug 17633: (QA followup) Remove unneeded warnings Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Tomás Cohen Arazi changed: What|Removed |Added Attachment #57508|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 57509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57509&action=edit Bug 17633: Do not call set_preference from tests If memcached is running, the pref's value will be set in cache, what we do not want. t/db_dependent/Context.t and t/db_dependent/sysprefs.t are exceptions for obvious reasons. Test plan: Make sure all these tests still pass Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Josef Moravec changed: What|Removed |Added Attachment #57507|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 57508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57508&action=edit [SIGNED-OFF] Bug 17633: Do not call set_preference from tests If memcached is running, the pref's value will be set in cache, what we do not want. t/db_dependent/Context.t and t/db_dependent/sysprefs.t are exceptions for obvious reasons. Test plan: Make sure all these tests still pass Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 --- Comment #2 from Jonathan Druart --- Generated with perl -p -i -e "s/C4::Context->set_preference\((.*),(.*)\);/t::lib::Mocks::mock_preference(\1,\2);/" t/**/*.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17599 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17633] Tests should not call set_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17633 --- Comment #1 from Jonathan Druart --- Created attachment 57507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57507&action=edit Bug 17633: Do not call set_preference from tests If memcached is running, the pref's value will be set in cache, what we do not want. t/db_dependent/Context.t and t/db_dependent/sysprefs.t are exceptions for obvious reasons. Test plan: Make sure all these tests still pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
