[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Sara Brown changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31454 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #216 from Fridolin Somers --- Up ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #215 from Séverine Queune --- I still have an error trace, this time when I save the subscription. With the patch applies, the option to set 'regular irregularities' for daily (text + checkbox) are not displayed anymore. It didn't happen the first time I test the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #214 from Arthur Suzuki --- Created attachment 132779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132779=edit Bug 17656: (follow-up) Update DBIC + fix missing C4::Serials functions needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #213 from Séverine Queune --- Created attachment 132692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132692=edit Error trace when renew a subscription -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #212 from Séverine Queune --- I've got an error trace on cgi-bin/koha/serials/subscription-renew.pl?mode=popup=1 when I try to renew the subscription. See the full error in text document attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #211 from Arthur Suzuki --- Created attachment 132448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132448=edit Bug 17656: (follow-up) Fix typo for QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #210 from Arthur Suzuki --- Created attachment 132447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132447=edit Bug 17656: fix issue_number call in showprediction.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #209 from Arthur Suzuki --- Created attachment 132418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132418=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #208 from Arthur Suzuki --- Created attachment 132417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132417=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #207 from Arthur Suzuki --- Created attachment 132416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132416=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #206 from Arthur Suzuki --- Created attachment 132415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132415=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #205 from Arthur Suzuki --- Created attachment 132413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132413=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki changed: What|Removed |Added Attachment #128498|0 |1 is obsolete|| Attachment #128499|0 |1 is obsolete|| Attachment #128500|0 |1 is obsolete|| Attachment #128501|0 |1 is obsolete|| Attachment #128502|0 |1 is obsolete|| Attachment #128503|0 |1 is obsolete|| Attachment #128504|0 |1 is obsolete|| --- Comment #204 from Arthur Suzuki --- Created attachment 132412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132412=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud Signed-off-by: David Nind Rebased - 2021-03-04 - Alex Arnaud Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com Status|Needs Signoff |Patch doesn't apply --- Comment #203 from Arthur Suzuki --- Patch doesn't apply : root@kohadevbox:koha(bz17656)$ git bz apply 17656 Bug 17656 - Irregularities in serial prediction pattern are planned only for current subscription 128498 - Bug 17656: Keep irregularities during subscription renewals 128499 - Bug 17656: (follow-up) Add missing filters 128500 - Bug 17656: [DO NOT PUSH] provide schema file 128501 - Bug 17656: [DO NOT PUSH] provide css file 128502 - Bug 17656: QA warnings fixes 128503 - Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions 128504 - Bug 17656: More meaningful messages in prediction pattern table Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17656: Keep irregularities during subscription renewals Using index info to reconstruct a base tree... M C4/Serials.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt M koha-tmpl/intranet-tmpl/prog/js/subscription-add.js M serials/subscription-add.pl Falling back to patching base and 3-way merge... Auto-merging serials/subscription-add.pl Auto-merging koha-tmpl/intranet-tmpl/prog/js/subscription-add.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/subscription-add.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Serials.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 17656: Keep irregularities during subscription renewals hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17656-Keep-irregularities-during-subscription--JneHV9.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #202 from Thibaud Guillot --- Patchs rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||thibaud.guil...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #128496|0 |1 is obsolete|| --- Comment #201 from Thibaud Guillot --- Created attachment 128504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128504=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #128495|0 |1 is obsolete|| --- Comment #200 from Thibaud Guillot --- Created attachment 128503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128503=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #128494|0 |1 is obsolete|| --- Comment #199 from Thibaud Guillot --- Created attachment 128502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128502=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #128493|0 |1 is obsolete|| --- Comment #198 from Thibaud Guillot --- Created attachment 128501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128501=edit Bug 17656: [DO NOT PUSH] provide css file Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #128492|0 |1 is obsolete|| --- Comment #197 from Thibaud Guillot --- Created attachment 128500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128500=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #128491|0 |1 is obsolete|| --- Comment #196 from Thibaud Guillot --- Created attachment 128499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128499=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #128489|0 |1 is obsolete|| --- Comment #195 from Thibaud Guillot --- Created attachment 128498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128498=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud Signed-off-by: David Nind Rebased - 2021-03-04 - Alex Arnaud Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #121302|0 |1 is obsolete|| --- Comment #194 from Thibaud Guillot --- Created attachment 128496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128496=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #121301|0 |1 is obsolete|| --- Comment #193 from Thibaud Guillot --- Created attachment 128495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128495=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #121300|0 |1 is obsolete|| --- Comment #192 from Thibaud Guillot --- Created attachment 128494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128494=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #121299|0 |1 is obsolete|| --- Comment #191 from Thibaud Guillot --- Created attachment 128493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128493=edit Bug 17656: [DO NOT PUSH] provide css file Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #121298|0 |1 is obsolete|| --- Comment #190 from Thibaud Guillot --- Created attachment 128492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128492=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #121297|0 |1 is obsolete|| --- Comment #189 from Thibaud Guillot --- Created attachment 128491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128491=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot changed: What|Removed |Added Attachment #121296|0 |1 is obsolete|| --- Comment #188 from Thibaud Guillot --- Created attachment 128489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128489=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud Signed-off-by: David Nind Rebased - 2021-03-04 - Alex Arnaud Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Patch doesn't apply --- Comment #187 from Nick Clemens --- Doesn't apply, please remove unused function in comment 186 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind changed: What|Removed |Added Text to go in the||This fixes an issue where release notes||irregularities are lost ||when renewing a ||subscription. Now when ||renewing a subscription ||irregularities are kept for ||daily, weekly and monthly ||serials (1 unit per issue ||only). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #186 from Joonas Kylmälä --- Adds unused function _get_sub_length which should be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #185 from Victor Grousset/tuxayo --- For some reason not all commits had the signed off mark. I confirm having tested with all applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121198|0 |1 is obsolete|| --- Comment #184 from Victor Grousset/tuxayo --- Created attachment 121302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121302=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121197|0 |1 is obsolete|| --- Comment #183 from Victor Grousset/tuxayo --- Created attachment 121301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121301=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121196|0 |1 is obsolete|| --- Comment #182 from Victor Grousset/tuxayo --- Created attachment 121300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121300=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121195|0 |1 is obsolete|| --- Comment #181 from Victor Grousset/tuxayo --- Created attachment 121299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121299=edit Bug 17656: [DO NOT PUSH] provide css file Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121194|0 |1 is obsolete|| --- Comment #180 from Victor Grousset/tuxayo --- Created attachment 121298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121298=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121193|0 |1 is obsolete|| --- Comment #179 from Victor Grousset/tuxayo --- Created attachment 121297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121297=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121192|0 |1 is obsolete|| --- Comment #178 from Victor Grousset/tuxayo --- Created attachment 121296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121296=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud Signed-off-by: David Nind Rebased - 2021-03-04 - Alex Arnaud Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #177 from Victor Grousset/tuxayo --- It works :) Thanks for the fix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121088|0 |1 is obsolete|| --- Comment #176 from Victor Grousset/tuxayo --- Created attachment 121198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121198=edit Bug 17656: More meaningful messages in prediction pattern table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121087|0 |1 is obsolete|| --- Comment #175 from Victor Grousset/tuxayo --- Created attachment 121197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121197=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121086|0 |1 is obsolete|| --- Comment #174 from Victor Grousset/tuxayo --- Created attachment 121196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121196=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121085|0 |1 is obsolete|| --- Comment #173 from Victor Grousset/tuxayo --- Created attachment 121195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121195=edit Bug 17656: [DO NOT PUSH] provide css file Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121084|0 |1 is obsolete|| --- Comment #172 from Victor Grousset/tuxayo --- Created attachment 121194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121194=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121083|0 |1 is obsolete|| --- Comment #171 from Victor Grousset/tuxayo --- Created attachment 121193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121193=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121082|0 |1 is obsolete|| --- Comment #170 from Victor Grousset/tuxayo --- Created attachment 121192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121192=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud Signed-off-by: David Nind Rebased - 2021-03-04 - Alex Arnaud Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #169 from Alex Arnaud --- (In reply to Victor Grousset/tuxayo from comment #161) > > The method Koha::Subscriptions->startdate is not covered by tests! > Victor, it's ok now. I squashed the fix in "use Koha::Subscription->startdate instead of Koha::Subscriptions" patch. It's the same problem in other place. Patches rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #120863|0 |1 is obsolete|| --- Comment #168 from Alex Arnaud --- Created attachment 121088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121088=edit Bug 17656: More meaningful messages in prediction pattern table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #119106|0 |1 is obsolete|| --- Comment #167 from Alex Arnaud --- Created attachment 121087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121087=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #118856|0 |1 is obsolete|| --- Comment #166 from Alex Arnaud --- Created attachment 121086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121086=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #117846|0 |1 is obsolete|| --- Comment #165 from Alex Arnaud --- Created attachment 121085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121085=edit Bug 17656: [DO NOT PUSH] provide css file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #117791|0 |1 is obsolete|| --- Comment #164 from Alex Arnaud --- Created attachment 121084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121084=edit Bug 17656: [DO NOT PUSH] provide schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #117790|0 |1 is obsolete|| --- Comment #163 from Alex Arnaud --- Created attachment 121083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121083=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #117789|0 |1 is obsolete|| --- Comment #162 from Alex Arnaud --- Created attachment 121082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121082=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud Signed-off-by: David Nind Rebased - 2021-03-04 - Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||vic...@tuxayo.net --- Comment #161 from Victor Grousset/tuxayo --- (In reply to Koha Team University Lyon 3 from comment #160) > Hope this patch will be in master soon, what's the english for "je croise > les doigt" ? fingers crossed ? yes ^^" Too bad I hit an issue when testing however :o (In reply to Koha Team University Lyon 3 from comment #151) > The method Koha::Subscriptions->startdate is not covered by tests! same! details - rebuilt schema files[1] - new subscription - record 146 from sample data - first publication date: 05/02/2021 - Frequency 1/day - start date 05/02/2021 - numbering pattern number - Subscription length: 7 - not published: 05/04/2021 & 05/05/2021 - save The method Koha::Subscriptions->startdate is not covered by tests! [1] dbic command from koha-testing-docker mysql -h db -ppassword -uroot -e 'DROP DATABASE IF EXISTS dbic; CREATE DATABASE dbic' cd '/kohadevbox/koha' mysql -h db -ppassword -uroot dbic < installer/data/mysql/kohastructure.sql misc/devel/update_dbix_class_files.pl --db_name dbic --db_host db --db_user root --db_passwd password Did I do something wrong? Reverted to "need signoff" so it's not in the signoff queue. Which would cause someone from QA to look at it, pass it and don't look a it later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Koha Team University Lyon 3 changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #160 from Koha Team University Lyon 3 --- Hey Alex, Great ! That's perfect. Hope this patch will be in master soon, what's the english for "je croise les doigt" ? fingers crossed ? Olivier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #159 from Alex Arnaud --- (In reply to Koha Team University Lyon 3 from comment #157) > Please check the issues that are NOT published (irregularities) > and below : > Choice the weeks in the year where the issues are not published > > May be, in this case, the second is redundant. I would suggest to suppress > the second and make the first like this : > Please check in the dropdown list, the issues that are NOT published > (irregularities) > > and last thing : the "Weeks(s)not_published" form is jumping when we check a > checkbox. Could you add a "return false" to "Check_permanent_irregularities" > function to prevent this ? > > Olivier Olivier, Please test my proposal for meaningful messages. Also, fixed the jump on top of the page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #158 from Alex Arnaud --- Created attachment 120863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120863=edit Bug 17656: More meaningful messages in prediction pattern table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #157 from Koha Team University Lyon 3 --- Oh ! stupid ! I did'nt get it !. I think I only checked the flat list below. I redo the test checking the irregularities in the choice list and you are right it-s OK : this time irregularities are kept. I will sign off but I have 2 last suggestions : I think all the same, the display for weeks type is little ambiguous : The presence of 2 wordings very close can be troubling Please check the issues that are NOT published (irregularities) and below : Choice the weeks in the year where the issues are not published May be, in this case, the second is redundant. I would suggest to suppress the second and make the first like this : Please check in the dropdown list, the issues that are NOT published (irregularities) and last thing : the "Weeks(s)not_published" form is jumping when we check a checkbox. Could you add a "return false" to "Check_permanent_irregularities" function to prevent this ? Olivier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #156 from Alex Arnaud --- (In reply to Koha Team University Lyon 3 from comment #154) > > I checked 8 and 15 feb 2021 > They are recorded ok > I multireceived 50 issues and click on Renew button but no weeks are no more > checked on the form. > > Olivier Olivier, Did you check the weeks in the list above the prediction table ? Doing so works for me. If you check weeks inside the prediction table (column "Not published"), they are not saved as permanent irregularities but as irregularities. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #155 from Katrin Fischer --- Thx for all the testing going on here! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #154 from Koha Team University Lyon 3 --- Hello, I testes this time on Ptfx Sandbox. no more message "Renewal cancelled". Sorry, I think this was template problem on my instance. It's OK now for startdate error message. Everything works as expected as for daily and monthly frequencies. Exceptions are kept. date are skipped when receiving as well. But unfortunately weekly frequency does not work. Irregularities are not retained : my parameters : first issue publ. date 01/01/2021 startdate 01/01/2021 issues 52 enddate 31/12/2021 I checked 8 and 15 feb 2021 They are recorded ok I multireceived 50 issues and click on Renew button but no weeks are no more checked on the form. Olivier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #153 from Alex Arnaud --- Created attachment 119106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119106=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #152 from Koha Team University Lyon 3 --- Some more details : I tried a daily frequency with the following data : 05/04/2021 to 11/04/2021 (french notation = 5 april 2021 to 11 april 2021) first issue 05/04/2021 subs start : idem issues 7 subs end : 11/04/2021 wednesday and thursday are checked as irregulars multireceiving 5 items renewing : wednesday and thursday are still checked. That's OK but when I submit the form, the following message is displayed : "Renewing is cancelled, contact the administrator" Going back to Editing subscription, in Test pattern it's said : End date is not consistent with subscription length. Indeed end date is remained on 11/04/2021 I decided to delete enddate and let it making itself but when saving I get again the error message "The method Koha::Subscriptions->startdate is not covered by tests!" Olivier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #151 from Koha Team University Lyon 3 --- Hello Alex, Sorry but when I record a subscription after adding irregularities via Test prediction pattern and I click on Save Subscription button, I get this error : The method Koha::Subscriptions->startdate is not covered by tests! I tried to create a new subs and that time it was OK. But when I create another sub for testing another type of frequency I got this error again. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #117852|0 |1 is obsolete|| --- Comment #150 from PTFS Europe Sandboxes --- Created attachment 118856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118856=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #117851|0 |1 is obsolete|| --- Comment #149 from Alex Arnaud --- Created attachment 117852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117852=edit Bug 17656: QA warnings fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #148 from Alex Arnaud --- Created attachment 117851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117851=edit Bug 17656: QA warnings fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #117792|0 |1 is obsolete|| --- Comment #147 from Alex Arnaud --- Created attachment 117846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117846=edit Bug 17656: [DO NOT PUSH] provide css file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #146 from Katrin Fischer --- I am sorry, but there are quite some QA fails here :( It looks like the first could be a rebase issue? FAIL C4/Serials.pm FAIL valid Constant subroutine C4::Serials::MISSING_LOST redefined Constant subroutine C4::Serials::MISSING_NEVER_RECIEVED redefined Constant subroutine C4::Serials::STOPPED redefined Constant subroutine C4::Serials::DELETED redefined Constant subroutine C4::Serials::MISSING_DAMAGED redefined Constant subroutine C4::Serials::EXPECTED redefined Constant subroutine C4::Serials::LATE redefined Constant subroutine C4::Serials::MISSING_SOLD_OUT redefined Constant subroutine C4::Serials::ARRIVED redefined Constant subroutine C4::Serials::NOT_ISSUED redefined Constant subroutine C4::Serials::CLAIMED redefined Constant subroutine C4::Serials::MISSING redefined FAIL t/Serials/IssueNumber.t OK critic FAIL file permissions File must have the exec flag FAIL t/db_dependent/Koha/Subscription/GuessEnddate.t OK critic FAIL file permissions File must have the exec flag FAIL t/db_dependent/Koha/Subscription/Irregularities.t OK critic FAIL file permissions File must have the exec flag FAIL t/db_dependent/Serials/SubscriptionIrregularity.t OK critic FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer changed: What|Removed |Added Keywords||Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #145 from Katrin Fischer --- CSS is already conflicting - I will leave this patch off for testing running yarn build locally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #144 from Alex Arnaud --- Patches rebased and squashed. @Marcel, I took your QA remarks into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #143 from Alex Arnaud --- Created attachment 117792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117792=edit Bug 17656: [DO NOT PUSH] provide css file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #142 from Alex Arnaud --- Created attachment 117791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117791=edit Bug 17656: [DO NOT PUSH] provide schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #141 from Alex Arnaud --- Created attachment 117790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117790=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What|Removed |Added Attachment #103657|0 |1 is obsolete|| Attachment #103658|0 |1 is obsolete|| Attachment #103659|0 |1 is obsolete|| Attachment #103660|0 |1 is obsolete|| Attachment #103661|0 |1 is obsolete|| Attachment #103662|0 |1 is obsolete|| Attachment #103663|0 |1 is obsolete|| Attachment #103664|0 |1 is obsolete|| Attachment #103665|0 |1 is obsolete|| --- Comment #140 from Alex Arnaud --- Created attachment 117789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117789=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud Signed-off-by: David Nind Rebased - 2021-03-04 - Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26054 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #139 from Marcel de Rooy --- Since we already got into string freeze, I leave it for now. Please resubmit your work in some squashed way. Perhaps divide the module changes, tests, script and template changes, and db revisions over separate patches. Thanks ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
--- Comment #138 from Marcel de Rooy ---
+my $subscription_o =
Koha::Subscriptions->find($subscription->{subscriptionid});
+my @irreg = $subscription_o->irregularities;
+is($irreg[0], 2, 'First element of irregularities is 2');
+is($irreg[1], 4, 'Second element of irregularities is 4');
+is($irreg[2], 7, 'Third element of irregularities is 7');
+
+my @permanent_irreg = $subscription_o->permanent_irregularities;
+is($permanent_irreg[0], 1, 'First element of permanent_irregularities is 1');
+is($permanent_irreg[1], 2, 'Second element of permanent_irregularities is 2');
Do we really need this?
You add a separate script here to test if split /;/ works ?
I appreciate your willingness to test, but I have the impression that we should
focus here on complex exceptions with various frequencies, different months,
leap years, etc. Think of various date peculiarities.
Elaborating on that, t/db_dependent/Koha/Subscription/Irregularities.t contains
a lot of code, but actually only one test.
+ is($irregularities, '10;11', 'Irregularities have been updated');
Since this looks like the most important test, I would really expect more
testing here. Maybe you should think of some intelligent mocks here to reduce a
lot of building calls?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
--- Comment #137 from Marcel de Rooy ---
You add a routine to DateUtils called issue_number:
+my $week_number = issue_number('2017-01-01', 'week');
What you actually want is a day-of-week, week number or month.
The name is confusing. I do not expect an issue_number in DateUtils.
The POD is wrong since you expect a dt and raise an exception on a string.
+ return Day_of_Week(split /-/, $date->ymd);
Please consider using a DateTime function here:
$dt->day_of_week()
$dt->wday() and $dt->dow().
$dt->local_day_of_week()
Actually $dt->dow is shorter than issue_number($dt, 'week')
+ return $date->month;
In this case it is more work to call issue_number($dt, 'month') than to say
$dt->month.
+my $dow = issue_number( dt_from_string($date), $frequency->unit );
This is a bit confusing. If we do not know the unit, how could we save it into
dow (day of week) ? Rename ?
I recommend to remove issue_number from DateUtils. We could move it to Serials?
It is a thin wrapper to three DateTime methods. If you want to keep it in
DateUtils, we should come up with a convincing name.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
--- Comment #136 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #135)
> +=head2 GessEnddate
> +
> +my $enddate = GessEnddate($startdate_iso $frequencyid, $numberlength,
> $weeklength, $monthlength);
> +
> +=cut
> +
> +sub GuessEnddate {
>
> The routine name should obviously be the same in POD and code.
Seeing a correction now. Reason for some squashing ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
--- Comment #135 from Marcel de Rooy ---
+=head2 GessEnddate
+
+my $enddate = GessEnddate($startdate_iso $frequencyid, $numberlength,
$weeklength, $monthlength);
+
+=cut
+
+sub GuessEnddate {
The routine name should obviously be the same in POD and code.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #134 from Marcel de Rooy --- Same remark for this: -librarian => $auser, -branchcode=> $branchcode, -aqbooksellerid=> $aqbooksellerid, -cost => $cost, -aqbudgetid=> $aqbudgetid, -biblionumber => $biblionumber, -startdate => $startdate, -periodicity => $periodicity, -numberlength => $numberlength, -weeklength=> $weeklength, -monthlength => $monthlength, -lastvalue1=> $lastvalue1, -innerloop1=> $innerloop1, -lastvalue2=> $lastvalue2, -innerloop2=> $innerloop2, -lastvalue3=> $lastvalue3, -innerloop3=> $innerloop3, -status=> $status, -notes => $notes, -letter=> $letter, -firstacquidate=> $firstacquidate, -irregularity => $irregularity, -numberpattern => $numberpattern, -locale=> $locale, -callnumber=> $callnumber, -manualhistory => $manualhistory, -internalnotes => $internalnotes, -serialsadditems => $serialsadditems, -staffdisplaycount => $staffdisplaycount, -opacdisplaycount => $opacdisplaycount, -graceperiod => $graceperiod, -location => $location, -enddate => $enddate, -skip_serialseq=> $skip_serialseq, -itemtype => $itemtype, -previousitemtype => $previousitemtype, -mana_id => $mana_id, +librarian => $auser, +branchcode => $branchcode, +aqbooksellerid => $aqbooksellerid, +cost=> $cost, +aqbudgetid => $aqbudgetid, +biblionumber=> $biblionumber, +startdate => $startdate, +periodicity => $periodicity, +numberlength=> $numberlength, etc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #133 from Marcel de Rooy --- -$periodicity, $firstacquidate, $irregularity, $numberpattern, $locale, -$numberlength, $weeklength, $monthlength, $lastvalue1, $innerloop1, -$lastvalue2, $innerloop2, $lastvalue3, $innerloop3, $status, -$biblionumber, $callnumber, $notes, $letter, $manualhistory, -$internalnotes, $serialsadditems, $staffdisplaycount, $opacdisplaycount, -$graceperiod, $location, $enddate, $subscriptionid, $skip_serialseq, -$itemtype, $previousitemtype, $mana_id +$periodicity, $firstacquidate, $irregularity, $permanent_irregularity, +$numberpattern, $locale, $numberlength, $weeklength, $monthlength, +$lastvalue1, $innerloop1, $lastvalue2, $innerloop2, $lastvalue3, +$innerloop3, $status, $biblionumber, $callnumber, $notes, $letter, +$manualhistory, $internalnotes, $serialsadditems, $staffdisplaycount, +$opacdisplaycount, $graceperiod, $location, $enddate, $subscriptionid, +$skip_serialseq, $itemtype, $previousitemtype, $mana_id Doing things like this does not life make easier for QA. Do I now have to check if every parameter is still there? You could have added the permanent_irregularity without touching all the other lines. And you can still fix it too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #132 from Marcel de Rooy --- FAIL installer/data/mysql/atomicupdate/Bug_17656-add-permanent-irregularities.sql FAIL git manipulation The file has been added and deleted in the same patchset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
