[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2017-07-31 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #9 from Mason James  ---
Pushed to 16.05.x, for 16.05.15 release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2017-06-21 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #8 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.09.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2017-06-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
   Patch complexity|--- |Trivial patch
 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Fridolin SOMERS  ---
Pushed to 17.05.x, will be in 17.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2017-06-15 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #63771|0   |1
is obsolete||
 CC||k...@bywatersolutions.com
 Status|Signed Off  |Passed QA

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Created attachment 64326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64326=edit
Bug 17710 - C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch
should use same logic

C4::ImportBatch::GetBestRecordMatch uses SQL to sort by score descending
then candidate_match_id descending. With C4::Matcher::get_matches, I
implement the same sort but use Perl code to do it, since we're sorting
search results.

It's a simple change, but it's in a big block of code, so I don't have
unit tests.

Signed-off-by: Alex Buckley 

Signed-off-by: Kyle M Hall 

--- Comment #6 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2017-05-28 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2017-05-28 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

Alex Buckley  changed:

   What|Removed |Added

  Attachment #58859|0   |1
is obsolete||

--- Comment #4 from Alex Buckley  ---
Created attachment 63771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63771=edit
Bug 17710 - C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch
should use same logic

C4::ImportBatch::GetBestRecordMatch uses SQL to sort by score descending
then candidate_match_id descending. With C4::Matcher::get_matches, I
implement the same sort but use Perl code to do it, since we're sorting
search results.

It's a simple change, but it's in a big block of code, so I don't have
unit tests.

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2017-01-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

David Cook  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2017-01-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

--- Comment #3 from David Cook  ---
Created attachment 58859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58859=edit
Bug 17710 - C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch
should use same logic

C4::ImportBatch::GetBestRecordMatch uses SQL to sort by score descending
then candidate_match_id descending. With C4::Matcher::get_matches, I
implement the same sort but use Perl code to do it, since we're sorting
search results.

It's a simple change, but it's in a big block of code, so I don't have
unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2017-01-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2017-01-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

--- Comment #2 from David Cook  ---
I've written a patch, but not sure how to write the test plan for this one.

C4::ImportBatch::GetBestRecordMatch achieves its sort via SQL rather than Perl,
so it's not like a common function could be used between them. 

I suppose I could refactor the sorting as a little function, but that doesn't
really help with testing C4::Matcher::get_matches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2017-01-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

David Cook  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

2016-12-01 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

--- Comment #1 from David Cook  ---
So:

@results = sort { $b->{'score'} cmp $a->{'score'} } @results;

Would become:

@results = sort {
$b->{'score'} cmp $a->{'score'} or
$b->{'record_id'} cmp $a->{'record_id'}
} @results;

--

I've already tested this and it works a treat. I'll post a patch next week I
reckon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/