[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Katrin Fischer changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #9 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- This is definitely an improvement but a case worth mentioning: Change a bunch of the dropdowns and enter no other data, no warning on editing a new rule. I don't know if it would be feasible to tackle this, and the current patches offer huge improvement so marking PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Nick Clemens changed: What|Removed |Added Attachment #58652|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 58983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58983&action=edit Bug 17808: Fix behavior when editing a circ rule The original behavior is broken, see https://stackoverflow.com/questions/21410484/jquery-selector-to-find-out-count-of-non-empty-inputs Test plan: Edit a circ rule => Without this patch you get a useless message => With this patch, no message Edit a circ rule with content in inputs => With or without this patch you get a useful message Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Katrin Fischer changed: What|Removed |Added Attachment #58408|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 58652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58652&action=edit [SIGNED OFF] Bug 17808: Fix behavior when editing a circ rule The original behavior is broken, see https://stackoverflow.com/questions/21410484/jquery-selector-to-find-out-count-of-non-empty-inputs Test plan: Edit a circ rule => Without this patch you get a useless message => With this patch, no message Edit a circ rule with content in inputs => With or without this patch you get a useful message Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Katrin Fischer changed: What|Removed |Added Summary|String change, message |When editing circulation |showing for confirm edit|conditions, only ask for |rule|confirmation when there is ||already a rule selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
