[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What|Removed |Added CC||luke.hon...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #15 from M. Tompsett --- The first patch written by me needs signing off. The second patch written by me was signed off by Luke Honiss. The third patch written by Fridolin SOMERS was signed off by me. In short, I am setting this to needs sign off, because of the first patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #14 from M. Tompsett --- *** Bug 17837 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What|Removed |Added Attachment #58577|0 |1 is obsolete|| --- Comment #13 from M. Tompsett --- Created attachment 59262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59262&action=edit Bug 17809 - ER country twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #12 from M. Tompsett --- Created attachment 59261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59261&action=edit Bug 17809 correct authorisation values for fr-FR This corrects: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. Signed-off-by: Luke Honiss -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #11 from M. Tompsett --- Created attachment 59259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59259&action=edit Bug 17809: Add upgrade warning messages TEST PLAN - 0) backup db 1) drop db and recreate empty 2) run fr-FR web install 3) update systempreferences set Value='16.3' where variable='Version'; -- it is currently 16.4 as of this writing 4) run fr-FR web install -- bottom of red warnings should be the check messages. 5) perlcritic -1 installer/data/mysql/atomic_update/bug_17809_pretty_red.perl -- $VERSION message, which we don't care about -- maybe a message about return value of print ignored. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #10 from Jonathan Druart --- yep -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #9 from M. Tompsett --- (In reply to Jonathan Druart from comment #8) > Nope, I'd suggest just to display a warning message if (ER, Allemagne) > exists. So, don't correct it. Just give pretty red upgrade messages? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #8 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #7) > (In reply to Jonathan Druart from comment #6) > > Frido, I think it would be great to have a update DB entry to check if this > > value exists. > > If it does, I do not think we should remove it, but at least warn the > > administrator that there is something wrong and something should be fixed. > > If I create a db update, simply replace in COUNTRY authorized value the > description for "ER" into "Erythrée" if it is "Allemagne" ? Nope, I'd suggest just to display a warning message if (ER, Allemagne) exists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #7 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #6) > Frido, I think it would be great to have a update DB entry to check if this > value exists. > If it does, I do not think we should remove it, but at least warn the > administrator that there is something wrong and something should be fixed. If I create a db update, simply replace in COUNTRY authorized value the description for "ER" into "Erythrée" if it is "Allemagne" ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- Frido, I think it would be great to have a update DB entry to check if this value exists. If it does, I do not think we should remove it, but at least warn the administrator that there is something wrong and something should be fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #4 from M. Tompsett --- Going to sign off and put the issues raised in comment #2 into bug 17837. Comment #3 may not have any relevance, as the two french words clearly refer to different things and very well may be valid. I'll leave that to a native French speaker to determine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What|Removed |Added Attachment #58390|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 58577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58577&action=edit Bug 17809 - ER country twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What|Removed |Added Blocks||17837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17837 [Bug 17837] Correct some authorised values in fr-FR -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #3 from M. Tompsett --- And confirm qualif 370 values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #2 from M. Tompsett --- Looking closer, please check: CC, ER, GQ, and PK as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #1 from Fridolin SOMERS --- Created attachment 58390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58390&action=edit Bug 17809 - ER country twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS changed: What|Removed |Added Summary|ER country in fr-FR |ER country twice in fr-FR |database files |database files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
