[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11997

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|20.11.00, 20.05.01, |20.11.00, 20.05.01,
released in|19.11.07|19.11.07, 19.05.12
 Status|Pushed to oldstable |Pushed to oldoldstable

--- Comment #55 from Victor Grousset/tuxayo  ---
Backported to 19.05.x branch for 19.05.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 Version(s)|20.11.00, 20.05.01  |20.11.00, 20.05.01,
released in||19.11.07
 Status|Pushed to stable|Pushed to oldstable

--- Comment #54 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.01
released in||

--- Comment #53 from Lucas Gass  ---
backported to 20.05.x for 20.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||20.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #52 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||julian.maur...@biblibre.com

--- Comment #51 from Julian Maurice  ---
(In reply to David Cook from comment #47)
> (In reply to Jonathan Druart from comment #46)
> > I think the whole block could be:
> > 
> > $output .= encode("UTF-8", $record->as_usmarc()) // q{};
> > 
> > From Encode::encode POD:
> >   "If the $string is undef, then undef is returned."
> 
> Personally, I don't like putting method output directly into another
> function call, as it can make exception handling harder. 

I don't like it either, but it should be harmless in this particular case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Julian Maurice  changed:

   What|Removed |Added

 Attachment #105440|0   |1
is obsolete||

--- Comment #49 from Julian Maurice  ---
Created attachment 105568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105568=edit
Bug 17842: UTF-8 encode ISO2709 MARC download from cart

The cart was outputing ISO2709 MARC records with Latin-1
encoding. Records containing non-latin1 characters were
automatically re-encoded as UTF-8 by browsers, which led to
inconsistent character encodings for downloaded MARC files.

This patch explicitly encodes ISO2709 MARC characters from
the cart download as UTF-8 encoded bytes, which resolves the problem.

Test Plan:
0) Don't apply patch
1) Create bib record with only ASCII characters
2) Add a ü character to the title
3) Save bib record
4) Download bib record from cart (opac and staff client)
5) Using xxd or some other program, note that the ü is
represented by a FC byte (latin-1 encoded)
6) Apply the patch
7) Download bib record from cart (opac and staff client)
8) Using xxd or some other program, note that the ü is
represented by C3 BC bytes (utf-8 encoded)
9) Success

(Note that you could potentially use Notepad++ or some other
program to open the downloaded file and just note the encoding
that it finds. You could also try "chardetect" instead. Lots
of options for figuring out the encoding.)

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Julian Maurice  changed:

   What|Removed |Added

 Attachment #105481|0   |1
is obsolete||

--- Comment #50 from Julian Maurice  ---
Created attachment 105569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105569=edit
Bug 17842: Simplify the code

There is no need for all the conditions.
From Encode::encode POD:
  "If the $string is undef, then undef is returned."

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #48 from Jonathan Druart  
---
Created attachment 105481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105481=edit
Bug 17842: Simplify the code

There is no need for all the conditions.
From Encode::encode POD:
  "If the $string is undef, then undef is returned."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #47 from David Cook  ---
(In reply to Jonathan Druart from comment #46)
> I think the whole block could be:
> 
> $output .= encode("UTF-8", $record->as_usmarc()) // q{};
> 
> From Encode::encode POD:
>   "If the $string is undef, then undef is returned."

Personally, I don't like putting method output directly into another function
call, as it can make exception handling harder. 

But your suggestion does look more elegant and would be less code to maintain. 

I'd be happy with either.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #46 from Jonathan Druart  
---
I think the whole block could be:

$output .= encode("UTF-8", $record->as_usmarc()) // q{};

From Encode::encode POD:
  "If the $string is undef, then undef is returned."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Needs Signoff   |Signed Off

--- Comment #45 from Victor Grousset/tuxayo  ---
It works! :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #105346|0   |1
is obsolete||

--- Comment #44 from Victor Grousset/tuxayo  ---
Created attachment 105440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105440=edit
Bug 17842: UTF-8 encode ISO2709 MARC download from cart

The cart was outputing ISO2709 MARC records with Latin-1
encoding. Records containing non-latin1 characters were
automatically re-encoded as UTF-8 by browsers, which led to
inconsistent character encodings for downloaded MARC files.

This patch explicitly encodes ISO2709 MARC characters from
the cart download as UTF-8 encoded bytes, which resolves the problem.

Test Plan:
0) Don't apply patch
1) Create bib record with only ASCII characters
2) Add a ü character to the title
3) Save bib record
4) Download bib record from cart (opac and staff client)
5) Using xxd or some other program, note that the ü is
represented by a FC byte (latin-1 encoded)
6) Apply the patch
7) Download bib record from cart (opac and staff client)
8) Using xxd or some other program, note that the ü is
represented by C3 BC bytes (utf-8 encoded)
9) Success

(Note that you could potentially use Notepad++ or some other
program to open the downloaded file and just note the encoding
that it finds. You could also try "chardetect" instead. Lots
of options for figuring out the encoding.)

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

David Cook  changed:

   What|Removed |Added

 Attachment #105341|0   |1
is obsolete||

--- Comment #43 from David Cook  ---
Created attachment 105346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105346=edit
Bug 17842: UTF-8 encode ISO2709 MARC download from cart

The cart was outputing ISO2709 MARC records with Latin-1
encoding. Records containing non-latin1 characters were
automatically re-encoded as UTF-8 by browsers, which led to
inconsistent character encodings for downloaded MARC files.

This patch explicitly encodes ISO2709 MARC characters from
the cart download as UTF-8 encoded bytes, which resolves the problem.

Test Plan:
0) Don't apply patch
1) Create bib record with only ASCII characters
2) Add a ü character to the title
3) Save bib record
4) Download bib record from cart (opac and staff client)
5) Using xxd or some other program, note that the ü is
represented by a FC byte (latin-1 encoded)
6) Apply the patch
7) Download bib record from cart (opac and staff client)
8) Using xxd or some other program, note that the ü is
represented by C3 BC bytes (utf-8 encoded)
9) Success

(Note that you could potentially use Notepad++ or some other
program to open the downloaded file and just note the encoding
that it finds. You could also try "chardetect" instead. Lots
of options for figuring out the encoding.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #42 from David Cook  ---
Very silly coding error on my part, which would only happen if you were
exporting more than 1 record.

I'll have a revised patch in a minute.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #41 from David Cook  ---
koha-testing-docker

Test Plan:
0) Do not apply patch
1) Upload "Sample records correctly encoded" as UTF-8 MARC (with no items)
2) Add the records to the Staff Client cart
3) Select both records and "Download" > "iso2709"
4) Note that the exported file is ISO 8859-1/Latin-1 encoded

5) Apply the patch
6) restart_all
7) Reload the Staff client cart
8) Select both records and "Download" > "iso2709"

And yep... I reproduce Katrin's double encoding problem.

Interestingly, it only affects the 1st record in the cart and not the 2nd
record. The importance of the order becomes obvious when I reverse the order of
the records in the cart. It's not the content of the records that causes the
encoding problem, but rather their place in the sequence.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #40 from David Cook  ---
(In reply to David Cook from comment #39)
> I just uploaded "Sample records correctly encoded" into my 19.11 system
> (with the patch), and I was able to export it as UTF-8 (according to
> Notepad++ and the hex inspected using xxd).
> 
> So I can't reproduce the double-encoding issue.
> 
> I did my test in Chrome 81 on Windows 10. 
> 
> About to test on koha-testing-docker with the same test plan.

That was also using CGI rather than Plack.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #39 from David Cook  ---
I just uploaded "Sample records correctly encoded" into my 19.11 system (with
the patch), and I was able to export it as UTF-8 (according to Notepad++ and
the hex inspected using xxd).

So I can't reproduce the double-encoding issue.

I did my test in Chrome 81 on Windows 10. 

About to test on koha-testing-docker with the same test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #38 from David Cook  ---
So interesting. It looks like the UTF-8 encoded data has been re-encoded as
Latin-1. 

I'm guessing this is because of the browser, and I have an idea for something
that might help, although I want to try to reproduce your issue first...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #37 from Katrin Fischer  ---
Created attachment 105345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105345=edit
Sample records correctly encoded

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #36 from Katrin Fischer  ---
Created attachment 105344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105344=edit
New export file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #35 from Katrin Fischer  ---
The second record containing 'über' imports nicely, but I see different
encoding errors in the first one which also has 2 umlauts in 245 (öä). 

Before we have those black things with a question mark (whatever you call
them). Now I see: Ãber die Auflösung...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #34 from Katrin Fischer  ---
Thx David, and that finally also explains why Jonathan could never reproduce
the issue - he had added other characters that were outside of latin-1. It was
really bugging me that I seemed to be the only one being able to see this
'ghost bug'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

David Cook  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

David Cook  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
   |ity.org |

--- Comment #33 from David Cook  ---
I can't mark this as "Needs Signoff"...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #32 from David Cook  ---
Created attachment 105341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105341=edit
Bug 17842: UTF-8 encode ISO2709 MARC download from cart

The cart was outputing ISO2709 MARC records with Latin-1
encoding. Records containing non-latin1 characters were
automatically re-encoded as UTF-8 browsers, which led to
inconsistent character encodings for downloaded MARC files.

This patch explicitly encodes ISO2709 MARC characters from
the cart download as UTF-8 encoded bytes, which resolves the problem.

Test Plan:
0) Don't apply patch
1) Create bib record with only ASCII characters
2) Add a ü character to the title
3) Save bib record
4) Download bib record from cart (opac and staff client)
5) Using xxd or some other program, note that the ü is
represented by a FC byte (latin-1 encoded)
6) Apply the patch
7) Download bib record from cart (opac and staff client)
8) Using xxd or some other program, note that the ü is
represented by C3 BC bytes (utf-8 encoded)
9) Success

(Note that you could potentially use Notepad++ or some other
program to open the downloaded file and just note the encoding
that it finds. You could also try "chardetect" instead. Lots
of options for figuring out the encoding.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #31 from David Cook  ---
In the end, I was able to solve this by just UTF-8 encoding the output.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #30 from David Cook  ---
Using the following doesn't help either:

Content-Type: application/octet-stream; charset=utf-8

I notice the console is saying "Resource interpreted as Document but
transferred with MIME type application/octet-stream", so I think that's what's
doing it. 

More to come...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #29 from David Cook  ---
Ok I think the key is in the Content-Type.

When I download the cart, I'm seeing this in the response headers:

Content-transfer-encoding: binary
Content-Type: application/octet-stream; charset=ISO-8859-1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #28 from David Cook  ---
Plot twist: encoding the character output as UTF-8 doesn't seem to make a
difference. 

At least not when using Chrome, which I'm guessing is automatically transcoding
the output. I'm going to see what wget does...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #27 from David Cook  ---
(In reply to David Cook from comment #26)
> Now if I add ü after 我, I am guessing that whatever automatic character
> encoding is happening (perhaps on the browser end?) will encode ü as UTF-8
> instead of Latin-1

And that theory was correct. The byte sequence is: e6 8891 20c3 bc.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #26 from David Cook  ---
(In reply to David Cook from comment #25)
> Ha! If I use ü instead of 我, it outputs as Latin-1 and ü is a FC byte
> instead of the C3 BC bytes.

Using 我, I get the correct bytes: e6 88 91.

Now if I add ü after 我, I am guessing that whatever automatic character
encoding is happening (perhaps on the browser end?) will encode ü as UTF-8
instead of Latin-1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #25 from David Cook  ---
Ha! If I use ü instead of 我, it outputs as Latin-1 and ü is a FC byte instead
of the C3 BC bytes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #24 from David Cook  ---
(In reply to David Cook from comment #23)
> Ok it just looks like a bug to me.
> 
> opac/opac-downloadcart.pl doesn't instruct Perl how to output the bytes, and
> I think Perl defaults to N8CS/Latin-1.
> 
> With opac/opac-sendbasket.pl, we explicitly encode the characters as UTF8
> bytes.

That being said... I can't reproduce the problem. In 19.11, I added some
Chinese to a test record, and I was able to download it from Staff Client and
OPAC carts and Notepad++ says they're both UTF-8 and renders correctly...

I'll try with ü specifically...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #23 from David Cook  ---
Ok it just looks like a bug to me.

opac/opac-downloadcart.pl doesn't instruct Perl how to output the bytes, and I
think Perl defaults to N8CS/Latin-1.

With opac/opac-sendbasket.pl, we explicitly encode the characters as UTF8
bytes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #22 from David Cook  ---
(In reply to Katrin Fischer from comment #21)
> Hi David, it looks like you are correct. Using ISO 8859-1 encoding when
> staging the MARC imports correctly. So... why do we not export in UTF-8 for
> the cart? I think we do in other places as for example the MARC attached to
> the cart email works correctly.

That's a very good question. Which Koha version are you using? This is the
"Download" option in the cart? (OPAC or Staff Client?)

I'll take a quick look...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #21 from Katrin Fischer  ---
Hi David, it looks like you are correct. Using ISO 8859-1 encoding when staging
the MARC imports correctly. So... why do we not export in UTF-8 for the cart? I
think we do in other places as for example the MARC attached to the cart email
works correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #20 from David Cook  ---
Oh, Katrin, try importing it using /cgi-bin/koha/tools/stage-marc-import.pl
with a Character encoding of "ISO 8859-1". I bet it'll work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25600

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #19 from David Cook  ---
Given my bad experience the other day trying to import records converted from
GB2312 to UTF8 into Koha, I'm extra interested by this. Maybe it's a related
topic.

At a glance, those sample records look fine both in Latin1 and UTF8. 

MarcEdit can convert the ISO MARC into its MRK format, but I'm failing to
convert it from ISO MARC to MARCXML. 

When I try to read your sample records as UTF-8 using MARC::File::USMARC, I see
the following error:

UTF-8 "\xFC" does not map to Unicode

Using "xxd cart.iso2709", I see that the "fc" byte is the ü in über and für.
Ah, and FC is ü in Latin-1 encoding whereas in UTF-8 it's C3 BC. 

So it sounds like Koha is exporting as Latin-1 but trying to import as UTF-8
and that's where it's falling over? 

Needs more investigating, but that's the problem with your sample records I'd
say.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Katrin Fischer  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Ever confirmed|1   |0
 Resolution|WORKSFORME  |---

--- Comment #17 from Katrin Fischer  ---
I'd really like to get behind this issue. I just retested on our Koha 18.11.16
and we still have the issue. :(

Our test installation is publicly accessible, but I don't want to post the link
here. Joubu, maybe I could talk you through it?

For matching I just seleted the file and changed none of the other settings
(encoding defaults to UTF-8).

We do have one local change on that file as we did chose not to export items:

my $record = GetMarcBiblio({
biblionumber => $biblio,
- embed_items  => 1,
+ embed_items  => 0,

But that should not make a difference in encoding?

Attaching sample records.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #18 from Katrin Fischer  ---
Created attachment 105333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105333=edit
Sample records downloaded from cart

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Jonathan Druart  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #16 from Jonathan Druart  
---
Closing again, please reopen (and attach the file) if still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Martin Renvoize  changed:

   What|Removed |Added

   Target Milestone|Oldversions |---

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

--- Comment #15 from Owen Leonard  ---
I cannot recreate this problem in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #14 from Jonathan Druart  
---
Also on which screen the display starts to be incorrect.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #13 from Jonathan Druart  
---
Could you attach the record here and tell us the different options you chose on
importing it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #12 from Katrin Fischer  ---
I have no idea what's going on there... but it doesn't work for me. :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #11 from Jonathan Druart  
---
% marcdump ~/Downloads/cart.iso2709|grep 245
/home/jonathan/Downloads/cart.iso2709
245 10 _aäüö ❤ ✓

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #10 from Jonathan Druart  
---
Still ok for me on 18.11.x following comments 1 and 3.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|CLOSED  |REOPENED

--- Comment #9 from Katrin Fischer  ---
I am still seeing this issue, tested in 18.11:

To test: 
- Create a record using umlauts öüä
- Put the record in your cart in OPAC
- Use the Download button and MARC as format
- Try to reimport the record or use MarcEdit to create a mrk
- Verify the Umlauts don't appear correctly

Example:
Deutsche Übersetzung turns into:
Deutsche {DC}bersetzung

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Katrin Fischer  changed:

   What|Removed |Added

Summary|Broken diacritics on|Broken diacritics on
   |records exported as MARC|records exported as MARC
   |from cart on reimport   |from cart

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #8 from Katrin Fischer  ---
I can no longer reproduce this issue on master (tested in kohadevbox).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Jonathan Druart  changed:

   What|Removed |Added

   Severity|critical|major

--- Comment #7 from Jonathan Druart  
---
Lowering the severity as it's not confirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #6 from Katrin Fischer  ---
Sorry not yet!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #5 from Jonathan Druart  
---
Any news here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #4 from Katrin Fischer  ---
I tested this on master before filing, but will test again and try to attach
the exported files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
>From /cgi-bin/koha/basket/basket.pl?bib_list=1/ I used Download > iso2709
Then import with the default character encoding option: UTF-8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #2 from Katrin Fischer  ---
Hm, no. I get this when I export using the MARC option from the download menu.
The attachement to the email (send cart) is fine. 
Which encoding did you pick for importing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

--- Comment #1 from Jonathan Druart  
---
This seems to work for me, I have exported a record with 245$a "äüö ❤ ✓" from
the cart and then reimported it (do not look for matching records, add incoming
record, add items).
The title appears ok during the whole import process.

Do you mean you do not get this problem when exporting using the export records
tool?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17754

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/