[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #6 from Katrin Fischer --- This depends on bug 17418, which is not in 16.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Owen Leonard changed: What|Removed |Added Blocks||17893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 [Bug 17893] Move JavaScript to the footer on staff client catalog pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Jonathan Druart changed: What|Removed |Added Attachment #58719|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 58720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58720&action=edit Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly. Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Claire Gravely changed: What|Removed |Added Attachment #58705|0 |1 is obsolete|| --- Comment #3 from Claire Gravely --- Created attachment 58719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58719&action=edit Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 --- Comment #2 from Owen Leonard --- Created attachment 58705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58705&action=edit Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 --- Comment #1 from Owen Leonard --- Affected would be any templates which include: [% PROCESS options_for_libraries... or [% PROCESS options_for_authorised_value_categories... ...because those blocks are defined in html_helpers.inc. The breakage would only occur if you tried to add [% SET footerjs = 1 %] to any of those templates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
