[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Nick Clemenschanged: What|Removed |Added Status|Pushed to Master|RESOLVED CC||n...@bywatersolutions.com Resolution|--- |FIXED --- Comment #22 from Nick Clemens --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #20 from Kyle M Hall--- Created attachment 70067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70067=edit Bug 17951: (followup) Make Makefile.PL handle template_cache_dir config This patch adds Makefile.PL the capability of handling the template_cache_dir configuration entry. To do so, it: - Adds the --template-cache-dir option switch (consistency with koha-create) - Sets a default value for template_cache_dir to '/tmp/koha' - Adds a dialog requesting the path for the template cache dir to Makefile.PL - It tweaks etc/koha-conf.xml so it is correctly changed by rewrite-config.PL To test: - Apply this patch - Run: $ perl Makefile.PL --template-cache-dir your/favourite/dir => SUCCESS: The dialogs don't ask for template cache dir => SUCCESS: The resulting Makefile contains an entry for TEMPLATE_CACHE_DIR which value matches what we passed to --template-cache-dir - Run: $ perl Makefile.PL - When prompted for a template cache dir, introduce whatever you want => SUCCESS: The default you are offered is /tmp/koha => SUCCESS: At the end of the process, Makefile contains what we put in there - Run: $ sudo make install => SUCCESS: The resulting koha-conf.xml contains a entry containing whatever you picked for that purpose. - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Kyle M Hallchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Kyle M Hallchanged: What|Removed |Added Attachment #68163|0 |1 is obsolete|| Attachment #68164|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall --- Created attachment 70066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70066=edit Bug 17951: Make koha-create set template_cache_dir correctly This patch makes koha-create (and friends) handle the template_cache_dir config entry correctly. It does so by: - Adding a replaceable string to the template for koha-conf.xml - Making koha-create-dirs create the needed directories (i.e. /var/cache/koha/instance and /var/cache/koha/instance/templates) - Adding a --template-cache-dir switch to koha-create (so sysadmins can specify their favourite directory for the templates cache). - koha-remove now takes care of the instance's *templates* dir. - The install scripts now automatically create /var/cache/koha so it can be used later by koha-create and friends. It does so the same way it does for other install-created directories. To test, you should ideally be able to build your own packages. This instructions can be followed by people that doesn't have that ability yet. But can be used on a custom packages setup too. To test: - Make sure you have the latest misc4dev in your kohadevbox (if it is a fresh box you have it already) - Run: $ sudo perl misc4dev/cp_debian_files.pl - Manually create the /var/cache/koha dir (skip if you have your own packages): $ sudo mkdir /var/cache/koha - Create a new instance: $ sudo koha-create --create-db cachetest => SUCCESS: * /etc/koha/sites/cachetest/koha-conf.xml contains template_cache_dir and is populated with /var/cache/koha/cachetest/templates * The directory /var/cache/koha/cachetest/templates exists! - Create a new instance, pass your own cache dir: $ sudo koha-create --create-db --template-cache-dir /tmp cachetest2 => SUCCESS: etc/koha/sites/cachetest2/koha-conf.xml contains template_cache_dir and is populated with /tmp - Run: $ man koha-create => SUCCESS: The docs mention the --template-cache-dir option switch correctly. - Sign off :-D! Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #18 from Fridolin SOMERS--- (In reply to Jonathan Druart from comment #17) > (In reply to Fridolin SOMERS from comment #15) > > Be careful that TT cache should not be enabled with Plack. > > Could you be more specific? Sorry, i was wrong. I have found something odd with Plack but it is not linked to template_cache_dir. I will explain it in a mail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #17 from Jonathan Druart--- (In reply to Fridolin SOMERS from comment #15) > Be careful that TT cache should not be enabled with Plack. Could you be more specific? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #16 from Marcel de Rooy--- (In reply to Fridolin SOMERS from comment #15) > Be careful that TT cache should not be enabled with Plack. See IRC discussion. If possible, please report specific problems on using both. At this time its use is still recommended.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Fridolin SOMERSchanged: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #15 from Fridolin SOMERS --- Be careful that TT cache should not be enabled with Plack. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Jonathan Druartchanged: What|Removed |Added Keywords|rel_17_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Jonathan Druartchanged: What|Removed |Added Keywords||rel_17_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Katrin Fischerchanged: What|Removed |Added Status|Needs Signoff |Signed Off CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Katrin Fischerchanged: What|Removed |Added Attachment #62690|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 68164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68164=edit Bug 17951: (followup) Make Makefile.PL handle template_cache_dir config This patch adds Makefile.PL the capability of handling the template_cache_dir configuration entry. To do so, it: - Adds the --template-cache-dir option switch (consistency with koha-create) - Sets a default value for template_cache_dir to '/tmp/koha' - Adds a dialog requesting the path for the template cache dir to Makefile.PL - It tweaks etc/koha-conf.xml so it is correctly changed by rewrite-config.PL To test: - Apply this patch - Run: $ perl Makefile.PL --template-cache-dir your/favourite/dir => SUCCESS: The dialogs don't ask for template cache dir => SUCCESS: The resulting Makefile contains an entry for TEMPLATE_CACHE_DIR which value matches what we passed to --template-cache-dir - Run: $ perl Makefile.PL - When prompted for a template cache dir, introduce whatever you want => SUCCESS: The default you are offered is /tmp/koha => SUCCESS: At the end of the process, Makefile contains what we put in there - Run: $ sudo make install => SUCCESS: The resulting koha-conf.xml contains a entry containing whatever you picked for that purpose. - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Katrin Fischerchanged: What|Removed |Added Attachment #62443|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 68163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68163=edit Bug 17951: Make koha-create set template_cache_dir correctly This patch makes koha-create (and friends) handle the template_cache_dir config entry correctly. It does so by: - Adding a replaceable string to the template for koha-conf.xml - Making koha-create-dirs create the needed directories (i.e. /var/cache/koha/instance and /var/cache/koha/instance/templates) - Adding a --template-cache-dir switch to koha-create (so sysadmins can specify their favourite directory for the templates cache). - koha-remove now takes care of the instance's *templates* dir. - The install scripts now automatically create /var/cache/koha so it can be used later by koha-create and friends. It does so the same way it does for other install-created directories. To test, you should ideally be able to build your own packages. This instructions can be followed by people that doesn't have that ability yet. But can be used on a custom packages setup too. To test: - Make sure you have the latest misc4dev in your kohadevbox (if it is a fresh box you have it already) - Run: $ sudo perl misc4dev/cp_debian_files.pl - Manually create the /var/cache/koha dir (skip if you have your own packages): $ sudo mkdir /var/cache/koha - Create a new instance: $ sudo koha-create --create-db cachetest => SUCCESS: * /etc/koha/sites/cachetest/koha-conf.xml contains template_cache_dir and is populated with /var/cache/koha/cachetest/templates * The directory /var/cache/koha/cachetest/templates exists! - Create a new instance, pass your own cache dir: $ sudo koha-create --create-db --template-cache-dir /tmp cachetest2 => SUCCESS: etc/koha/sites/cachetest2/koha-conf.xml contains template_cache_dir and is populated with /tmp - Run: $ man koha-create => SUCCESS: The docs mention the --template-cache-dir option switch correctly. - Sign off :-D! Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Tomás Cohen Arazichanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #12 from Tomás Cohen Arazi--- Created attachment 62690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62690=edit Bug 17951: (followup) Make Makefile.PL handle template_cache_dir config This patch adds Makefile.PL the capability of handling the template_cache_dir configuration entry. To do so, it: - Adds the --template-cache-dir option switch (consistency with koha-create) - Sets a default value for template_cache_dir to '/tmp/koha' - Adds a dialog requesting the path for the template cache dir to Makefile.PL - It tweaks etc/koha-conf.xml so it is correctly changed by rewrite-config.PL To test: - Apply this patch - Run: $ perl Makefile.PL --template-cache-dir your/favourite/dir => SUCCESS: The dialogs don't ask for template cache dir => SUCCESS: The resulting Makefile contains an entry for TEMPLATE_CACHE_DIR which value matches what we passed to --template-cache-dir - Run: $ perl Makefile.PL - When prompted for a template cache dir, introduce whatever you want => SUCCESS: The default you are offered is /tmp/koha => SUCCESS: At the end of the process, Makefile contains what we put in there - Run: $ sudo make install => SUCCESS: The resulting koha-conf.xml contains a entry containing whatever you picked for that purpose. - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #11 from Tomás Cohen Arazi--- (In reply to Jonathan Druart from comment #9) > (In reply to Tomás Cohen Arazi from comment #8) > > (In reply to Jonathan Druart from comment #6) > > > Sounds like changes to etc/koha-conf.xml are missing. > > > > Bug 7533? > > I do not understand what you are referring to. I am aware of bug 7533 as I > wrote the patch for it. Yes, I misunderstood you at the beginning of this conversation. Sorry! > Apply the patch then compare etc/koha-conf.xml and > debian/templates/koha-conf-site.xml.in, I think you will understand I am > saying. I now understand you want koha-conf.xml to be filled with the same stuff, enabled by default, etc. > Looking at bug 16083 it seems that we should continue to keep them in sync. Wow, I always thought I was aware of developments in the install/CLI stuff, and now I know I'm not aware of all of them :-D > Do not you think? Yes, they should be in sync. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #10 from Tomás Cohen Arazi--- (In reply to Marcel de Rooy from comment #5) > Still want to mention: > > [1] Should koha-remove remove a custom template cache dir? It currently does > not and this is consistent with the way we handle other dirs like uploads. > Although template cache files are better candidates for immediate removal. I mimicked what is done with uploads. I think a custom dir shouldn't be removed. > [2] Should we somehow allow a user to say that he does not want template > caching? I think that it is good to enable template caching by default now > in packaging, but should we make it easier to disable it? If a user wants to disable template caching, they just need to comment out the relevant entry. But they will still get the warning in about.pl, that originally triggered me to write this patch to start with (i.e. we introduced something that will always warn the user if an entry is missing, and not add it automatically in the first place). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #9 from Jonathan Druart--- (In reply to Tomás Cohen Arazi from comment #8) > (In reply to Jonathan Druart from comment #6) > > Sounds like changes to etc/koha-conf.xml are missing. > > Bug 7533? I do not understand what you are referring to. I am aware of bug 7533 as I wrote the patch for it. Apply the patch then compare etc/koha-conf.xml and debian/templates/koha-conf-site.xml.in, I think you will understand I am saying. Looking at bug 16083 it seems that we should continue to keep them in sync. Do not you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #8 from Tomás Cohen Arazi--- (In reply to Jonathan Druart from comment #6) > Sounds like changes to etc/koha-conf.xml are missing. Bug 7533? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #7 from Tomás Cohen Arazi--- (In reply to Jonathan Druart from comment #6) > Sounds like changes to etc/koha-conf.xml are missing. Ha, it is there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Marcel de Rooychanged: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from Marcel de Rooy --- Still want to mention: [1] Should koha-remove remove a custom template cache dir? It currently does not and this is consistent with the way we handle other dirs like uploads. Although template cache files are better candidates for immediate removal. [2] Should we somehow allow a user to say that he does not want template caching? I think that it is good to enable template caching by default now in packaging, but should we make it easier to disable it ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Marcel de Rooychanged: What|Removed |Added Attachment #59512|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 62443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62443=edit Bug 17951: Make koha-create set template_cache_dir correctly This patch makes koha-create (and friends) handle the template_cache_dir config entry correctly. It does so by: - Adding a replaceable string to the template for koha-conf.xml - Making koha-create-dirs create the needed directories (i.e. /var/cache/koha/instance and /var/cache/koha/instance/templates) - Adding a --template-cache-dir switch to koha-create (so sysadmins can specify their favourite directory for the templates cache). - koha-remove now takes care of the instance's *templates* dir. - The install scripts now automatically create /var/cache/koha so it can be used later by koha-create and friends. It does so the same way it does for other install-created directories. To test, you should ideally be able to build your own packages. This instructions can be followed by people that doesn't have that ability yet. But can be used on a custom packages setup too. To test: - Make sure you have the latest misc4dev in your kohadevbox (if it is a fresh box you have it already) - Run: $ sudo perl misc4dev/cp_debian_files.pl - Manually create the /var/cache/koha dir (skip if you have your own packages): $ sudo mkdir /var/cache/koha - Create a new instance: $ sudo koha-create --create-db cachetest => SUCCESS: * /etc/koha/sites/cachetest/koha-conf.xml contains template_cache_dir and is populated with /var/cache/koha/cachetest/templates * The directory /var/cache/koha/cachetest/templates exists! - Create a new instance, pass your own cache dir: $ sudo koha-create --create-db --template-cache-dir /tmp cachetest2 => SUCCESS: etc/koha/sites/cachetest2/koha-conf.xml contains template_cache_dir and is populated with /tmp - Run: $ man koha-create => SUCCESS: The docs mention the --template-cache-dir option switch correctly. - Sign off :-D! Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Tomás Cohen Arazichanged: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |tomasco...@gmail.com |ommunity.org| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Barton Chittendenchanged: What|Removed |Added CC||bar...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Tomás Cohen Arazichanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #2 from Tomás Cohen Arazi--- Created attachment 59512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59512=edit Bug 17951: Make koha-create set template_cache_dir correctly This patch makes koha-create (and friends) handle the template_cache_dir config entry correctly. It does so by: - Adding a replaceable string to the template for koha-conf.xml - Making koha-create-dirs create the needed directories (i.e. /var/cache/koha/instance and /var/cache/koha/instance/templates) - Adding a --template-cache-dir switch to koha-create (so sysadmins can specify their favourite directory for the templates cache). - koha-remove now takes care of the instance's *templates* dir. - The install scripts now automatically create /var/cache/koha so it can be used later by koha-create and friends. It does so the same way it does for other install-created directories. To test, you should ideally be able to build your own packages. This instructions can be followed by people that doesn't have that ability yet. But can be used on a custom packages setup too. To test: - Make sure you have the latest misc4dev in your kohadevbox (if it is a fresh box you have it already) - Run: $ sudo perl misc4dev/cp_debian_files.pl - Manually create the /var/cache/koha dir (skip if you have your own packages): $ sudo mkdir /var/cache/koha - Create a new instance: $ sudo koha-create --create-db cachetest => SUCCESS: * /etc/koha/sites/cachetest/koha-conf.xml contains template_cache_dir and is populated with /var/cache/koha/cachetest/templates * The directory /var/cache/koha/cachetest/templates exists! - Create a new instance, pass your own cache dir: $ sudo koha-create --create-db --template-cache-dir /tmp cachetest2 => SUCCESS: etc/koha/sites/cachetest2/koha-conf.xml contains template_cache_dir and is populated with /tmp - Run: $ man koha-create => SUCCESS: The docs mention the --template-cache-dir option switch correctly. - Sign off :-D! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Bug 17951 depends on bug 7533, which changed state. Bug 7533 Summary: Add template_cache_dir to the koha-conf.xml file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- *** Bug 17957 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Bug 17951 depends on bug 7533, which changed state. Bug 7533 Summary: Add template_cache_dir to the koha-conf.xml file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Tomás Cohen Arazichanged: What|Removed |Added Depends on||7533 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 [Bug 7533] Add template_cache_dir to the koha-conf.xml file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/