[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-03-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
Depends on bug 15503 which is not in 16.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-03-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Brendan Gallagher  ---
Pushed to Master - Should be in the 17.05 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-03-07 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #60834|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 60888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60888=edit
Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug
15503 followup

Fix use of 'gstrate' for 'tax_rate'

Signed-off-by: Matthias Meusburger 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-03-07 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-03-06 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-03-06 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #60811|0   |1
is obsolete||

--- Comment #6 from Matthias Meusburger  ---
Created attachment 60834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60834=edit
Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug
15503 followup

Fix use of 'gstrate' for 'tax_rate'

Signed-off-by: Matthias Meusburger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-03-03 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Nick Clemens  changed:

   What|Removed |Added

  Attachment #60249|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 60811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60811=edit
Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug
15503 followup

Fix use of 'gstrate' for 'tax_rate'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-03-03 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-03-03 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-03-01 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

--- Comment #4 from Matthias Meusburger  ---
With the patch applied, after validating the items informations, I have a "The
method gstrate is not covered by tests!" error message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-02-24 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||matthias.meusburger@biblibr
   ||e.com

--- Comment #3 from Jonathan Druart  
---
Matts, Any chances to get a signoff on this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-02-15 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60217|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 60249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60249=edit
Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug
15503 followup

To test:
Use a vendor with values in gstrate, listincgst, discount and ensure they are
used correctly in plan from 15503

Bug 15503 test plan:
1) Edit the MarcItemFieldsToOrder syspref. For example:
homebranch: 975$a
holdingbranch: 975$b
itype: 975$9|975$z
nonpublic_note: 975$x
public_note: 975$y
loc: 975$8
ccode: 975$c
notforloan: 975$7
uri: 975$u
copyno: 975$n
quantity: 969$h
budget_code: 922$a
price: 975$p

2) Create some sample records in koha with values in these fields, then save
them as Unicode-UTF-8
Example:
922_aBudget_code_1
922_aBudget_code_2
969_h3
969_h1
975_71
   _8loc
   _9CD
   _aHomebranch_1
   _bHoldingbranch_1
   _cccode_1
   _ncopyno
   _uuri
   _xnonpublic_note
   _ypublic_note
   _p12.5
975_70
   _8loc2
   _aHomebranch_2
   _bHoldingbranch_2
   _cccode_2
   _ncopyno2
   _uuri2
   _xnonpublic_note2
   _ypublic_note2
   _zDVD
   _p22

3) Import your test records with the import tool (Stage MARC records for
import)

4) Choose a basket, then click on "Add to basket" => "From a staged file"

5) Choose the file you have imported. For each record that had item
informations, you will have a preview of the item that will be created on the
left side of the screen. Values can still be modified at this point. Save.

6) Check that the items and corresponding order lines have been created.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-02-15 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-02-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 Depends on||15503
   Severity|enhancement |major


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
[Bug 15503] Grab Item Information from Order Files
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup

2017-02-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115

--- Comment #1 from Nick Clemens  ---
Created attachment 60217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60217=edit
Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug
15503 followup

To test:
Use a vendor with values in gstrate, listincgst, discount and ensure they are
used correctly in plan from 15503

Bug 15503 test plan:
1) Edit the MarcItemFieldsToOrder syspref. For example:
homebranch: 975$a
holdingbranch: 975$b
itype: 975$9|975$z
nonpublic_note: 975$x
public_note: 975$y
loc: 975$8
ccode: 975$c
notforloan: 975$7
uri: 975$u
copyno: 975$n
quantity: 969$h
budget_code: 922$a
price: 975$p

2) Create some sample records in koha with values in these fields, then save
them as Unicode-UTF-8
Example:
922_aBudget_code_1
922_aBudget_code_2
969_h3
969_h1
975_71
   _8loc
   _9CD
   _aHomebranch_1
   _bHoldingbranch_1
   _cccode_1
   _ncopyno
   _uuri
   _xnonpublic_note
   _ypublic_note
   _p12.5
975_70
   _8loc2
   _aHomebranch_2
   _bHoldingbranch_2
   _cccode_2
   _ncopyno2
   _uuri2
   _xnonpublic_note2
   _ypublic_note2
   _zDVD
   _p22

3) Import your test records with the import tool (Stage MARC records for
import)

4) Choose a basket, then click on "Add to basket" => "From a staged file"

5) Choose the file you have imported. For each record that had item
informations, you will have a preview of the item that will be created on the
left side of the screen. Values can still be modified at this point. Save.

6) Check that the items and corresponding order lines have been created.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/