[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #14 from Jon Knight  ---
Thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #63851|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 66144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66144=edit
[SIGNED OFF] Bug 18690: Use MARC modification templates with bulkmarcimport.pl

When importing large numbers of MARC records from a legacy LMS to Koha
using bulkmarcimport.pl, it did not make use of the MARC modification
templates in the system (which can be useful for coversion of 852
fields to 952 fields for item holdings for example). This patch allows
MARC modification templates to be used with bulkmarcimport.pl.

To test:
1) Apply patch.
2) Set up a MARC modification template (in Home > Tools > MARC
modification templates) to make some changes to imported MARC
records (for example copy a subfield).
3) Take a test set of MARC records that have fields matching the
template and import them using the bulkmarcimport.pl tool. For example
if these MARC records are in testrecords.mrc and the MARC modification
template is called testtemplate use something like:

   perl misc/migration_tools/bulkmarcimport.pl -commit 1000 \\
 -file testrecords.mrc -marcmodtemplate testtemplate

4) Check the imported records in Koha to see that the required
modifications have been applied when the MARC records are imported.
5) Sign off.

https://bugs.koha-community.org/show_bug.cgi?id=18389

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #12 from Katrin Fischer  ---
The QA tools point out some small issues with tabs vs. spaces - something to
keep in mind for your next patches!

As this works great, I am fixing them in the signed-off patch :)

 FAIL   misc/migration_tools/bulkmarcimport.pl
   OK critic
   FAIL   forbidden patterns
forbidden pattern: tab char (line 126)
forbidden pattern: tab char (line 128)
forbidden pattern: tab char (line 285)
forbidden pattern: tab char (line 125)
forbidden pattern: tab char (line 131)
forbidden pattern: tab char (line 127)
forbidden pattern: tab char (line 286)
   OK git manipulation
   OK pod
   OK spelling
   OK valid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #11 from Katrin Fischer  ---
Hi Jon, it would be great if this could also be included in the
stage_file.pl/commit_file.pl scripts that are command line tools of the staged
MARC import. Of course, separate bug (not trying to scope creep)!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #10 from Jonathan Druart  
---
Sounds good, thanks Jon!
Do not forget to change the status accordingly :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Jon Knight  changed:

   What|Removed |Added

  Attachment #63353|0   |1
is obsolete||
  Attachment #63469|0   |1
is obsolete||

--- Comment #9 from Jon Knight  ---
Created attachment 63851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63851=edit
Revised patch with commit information reformatted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #8 from Jon Knight  ---
OK.  This may take some time as I'm new to git and I've not idea how to
recommit something I've already committed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
   Assignee|gmcha...@gmail.com  |j.p.kni...@lboro.ac.uk
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #7 from Jonathan Druart  
---
Hi Jon,
Could you resubmit your patch following the requirements on the wiki page
https://wiki.koha-community.org/wiki/Commit_messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #6 from Katrin Fischer  ---
Thx for the follow-up!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #5 from Jon Knight  ---
Oh, and thanks for the advice Katrin - I'm still getting to grips with Koha and
git (been an RCS/SVN user for years!).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Jon Knight  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #4 from Jon Knight  ---
Created attachment 63469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63469=edit
Additional patch to remove use strict/warn and add POD

This is an additional patch to remove the use strict and use warn lines before
the use Perl::Modern, and add some POD for the help option.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |Needs Signoff

--- Comment #3 from Katrin Fischer  ---
Oh, and also don't forget to switch to "Needs sign-off" when you upload a patch
for testing! Spotted this in my mailbox, but it will now show on the Dashboard
etc. otherwise!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Katrin Fischer  changed:

   What|Removed |Added

Version|16.11   |master
 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #2 from Katrin Fischer  ---
Comment on attachment 63353
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63353
The same patch as above only generated within git and without touch existing
whitespace formatting oddities in the script.

Review of attachment 63353:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18389=63353)
-

Hi Jon,

the patch is looking good, thx for your contribution! Looking at the code, I am
missing documentation of the new option - could you add it please so it shows
up when bulkmarcimport is run without params or with -h?

Also noticed another small thing:

::: misc/migration_tools/bulkmarcimport.pl
@@ +3,4 @@
>  
>  use strict;
>  use warnings;
> +use Modern::Perl;

use Modern::Perl; replaces use strict; and use warnings; so the 2 lines above
should be deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Jon Knight  changed:

   What|Removed |Added

  Attachment #61907|0   |1
is obsolete||
 CC||j.p.kni...@lboro.ac.uk

--- Comment #1 from Jon Knight  ---
Created attachment 63353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63353=edit
The same patch as above only generated within git and without touch existing
whitespace formatting oddities in the script.

When I mentioned this bug/patch on the Koha IRC channel originally I was told I
needed to read up on how to submit bugs/patch because I'd done something wrong.
I've read a load of wiki pages, etc now and I think the issue might have been
that I tidied up the white space formatting in another part of the same script
and didn't have the patch generated by git (rather I just used context diffing
on our non-git installation). Hopefully this patch will find more favour. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/