[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #21 from Katrin Fischer  ---
There are too many ElasticSearch patches missing from 16.11.x - better to focus
on the more current vesions. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #20 from Mason James  ---
(In reply to Katrin Fischer from comment #19)
> Sorry, reverted - tests were failing.

Skipping for 16.05.x, due to failing tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

--- Comment #19 from Katrin Fischer  ---
Sorry, reverted - tests were failing.

 perl t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t 

not ok 9 - Exception thrown on invalid value in the marclist param
#   Failed test 'Exception thrown on invalid value in the marclist param'
#   at t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line
53.
# expecting: Koha::Exceptions::WrongParameter
# found: Can't locate object method "throw" via package
"Koha::Exceptions::WrongParameter" (perhaps you forgot to load
"Koha::Exceptions::WrongParameter"?) at
/home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line
432.
1..9
# Looks like you failed 1 test of 9.
not ok 1 - build_authorities_query_compat() tests
#   Failed test 'build_authorities_query_compat() tests'
#   at t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line 55.
# Looks like you failed 1 test of 1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #18 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.12.

Please note: Not all Elasticsearch related patches have been pushed to 16.11.x
as there were some problems/conflicts and I received no answer on the bugs. 
This applied cleanly, so I have pushed it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to Master|Pushed to Stable

--- Comment #17 from Fridolin SOMERS  ---
Pushed to 17.05.x, will be in 17.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #16 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

--- Comment #15 from Jonathan Druart  
---
Created attachment 66020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66020=edit
Bug 18624: Do not return 1 in tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

--- Comment #14 from Marcel de Rooy  ---
Side note: We are still waiting for the removal of the useless call of
SearchAuthorities in QueryBuilder on bug 16976 in PNA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

--- Comment #13 from Marcel de Rooy  ---
QA Comment:
Trusting on Tomas for the ElasticSearch test. Code looks good to me. A unit
test is added; it passes after the third patch.
The Zebra side is fine too, also after the template change in the fourth patch,
since AuthoritiesMarc does not care about all or any:
else {# Assume any if no index was specified
$attr = " \@attr 1=Any ";

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65592|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 65883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65883=edit
Bug 18624: Regression test for 'any' vs 'all'

This test makes it explicit that the only string producing _all as index on
build_authorities_query_compat is 'all'.
To test:
- Apply this patch
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
=> FAIL: Test fails because the list of valid values is wrong in Koha.

Note: this list has to be in sync with the templates passing the same values. A
followup will be added
to fix a discrepancy found between OPAC and Intranet.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65593|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 65884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65884=edit
Bug 18624: Run time errors when searching authorities with Elastic search 5.3

It seems we have a syntax mismatch - any vs all

all seems to the be list we expect so updating code that way

To test:
1 - Enabled Elasticsearch
2 - Index some authorities
3 - Perform a 'Search entire record' search
4 - Internal server error (
Invalid marclist field provided: all at
/usr/local/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
line 433.
)
5 - Run:
$ sudo koha-shell kohadev
   k$ cd kohaclone
   k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
=> FAIL: Tests fail because 'any is used'
6 - Apply patch
7 - Search should work
8 - Run:
   k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
=> SUCCESS: Tests pass!
9 Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Edited the test plan so it mentions the new tests

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65591|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 65882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65882=edit
Bug 18624: Minor refactoring to ease testing

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #65594|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 65885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65885=edit
Bug 18624: (followup) opac-authorities-home.tt uses 'any'

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Marcel de Rooy  changed:

   What|Removed |Added

   Hardware|PC  |All
 CC||m.de.r...@rijksmuseum.nl
 OS|Linux   |All

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #64385|0   |1
is obsolete||

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 65593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65593=edit
Bug 18624: Run time errors when searching authorities with Elastic search 5.3

It seems we have a syntax mismatch - any vs all

all seems to the be list we expect so updating code that way

To test:
1 - Enabled Elasticsearch
2 - Index some authorities
3 - Perform a 'Search entire record' search
4 - Internal server error (
Invalid marclist field provided: all at
/usr/local/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
line 433.
)
5 - Run:
$ sudo koha-shell kohadev
   k$ cd kohaclone
   k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
=> FAIL: Tests fail because 'any is used'
6 - Apply patch
7 - Search should work
8 - Run:
   k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
=> SUCCESS: Tests pass!
9 Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Edited the test plan so it mentions the new tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 65594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65594=edit
Bug 18624: (followup) opac-authorities-home.tt uses 'any'

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 65591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65591=edit
Bug 18624: Minor refactoring to ease testing

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 65592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65592=edit
Bug 18624: Regression test for 'any' vs 'all'

This test makes it explicit that the only string producing _all as index on
build_authorities_query_compat is 'all'.
To test:
- Apply this patch
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
=> FAIL: Test fails because the list of valid values is wrong in Koha.

Note: this list has to be in sync with the templates passing the same values. A
followup will be added
to fix a discrepancy found between OPAC and Intranet.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

--- Comment #4 from Jonathan Druart  
---
Nick, please provide tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Nice, please provide tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Nick Clemens  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Nick Clemens  changed:

   What|Removed |Added

Summary|Run time errors when|Software error when
   |searching authorities with  |searching authorities in
   |Elastic search 5.3  |Elasticsearch - incorrect
   ||parameter "any" should be
   ||"all"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/