[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

--- Comment #37 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #36)
> 1. when adding/editing a patron category, "Display in quick add: " is a bit
> meaningless, I would add a quick description, like we have for "Default
> privacy:", "Block expired patrons:", etc.
OK

> 
> 2. There is a condition ([% IF Koha.Preference('PatronQuickAddFields') ||
> Koha.Preference('BorrowerMandatoryField') %]) template-side to display the
> "Quick add new patron" button, should we do the same on the patron's
> category form?
Indeed

> 
> 
> And a question: what is the use case here? It seems that it would have been
> done in css or javascript easily... :)
It is a request from Aix-Marseille University which has 10 patron categories.
I think its more efficient for them to have only the most-used categories in
quick-add.
The actually have a JS customisation but it would be better to have it for
everybody in code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #36 from Jonathan Druart  
---
1. when adding/editing a patron category, "Display in quick add: " is a bit
meaningless, I would add a quick description, like we have for "Default
privacy:", "Block expired patrons:", etc.

2. There is a condition ([% IF Koha.Preference('PatronQuickAddFields') ||
Koha.Preference('BorrowerMandatoryField') %]) template-side to display the
"Quick add new patron" button, should we do the same on the patron's category
form?


And a question: what is the use case here? It seems that it would have been
done in css or javascript easily... :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72868|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72869|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|Small patch |Medium patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

--- Comment #33 from Katrin Fischer  ---
Created attachment 74832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74832=edit
Bug 18818: (follow-up) Correct template

Main change is the use of Yes/No instead if Display/Don't display.
It is more compact and more explicit.

And fixes in categories.tt :
- Template Toolkit markup inside HTML in 
- Missing double-quotes in HTML attributes
- Missing value display in delete confirmation table
- Correct capitalization

Signed-off-by: JM Broust 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73604|0   |1
is obsolete||

--- Comment #35 from Katrin Fischer  ---
Created attachment 74834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74834=edit
Bug 18818: DBIC Schema changes

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

--- Comment #34 from Katrin Fischer  ---
Created attachment 74833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74833=edit
Bug 18818: Define new column as boolean in DBIC Schema

See https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans

Signed-off-by: JM Broust 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72867|0   |1
is obsolete||

--- Comment #32 from Katrin Fischer  ---
Created attachment 74831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74831=edit
Bug 18818: Display in quick add list now depends on a field in database

This patch allows to manage the patron categories contained in 'Quick add new
patron'.

Test plan:
1) Apply patches but not "define new column as boolean in DBIC Schema"
2) Update database structure : installer/data/mysql/updatedatabase.pl
3) Apply patch "define new column as boolean in DBIC Schema"
4) Update DBIx shema : misc/devel/update_dbix_class_files.pl
5) Go to Administation > Patron categories
6) Check there is a field named "Display in quick add" with "Yes"
7) Edit a category to set "No" and save
8) Check change is well saved
9) Go to "Patrons" and click on "Quick add patron"
10) Check the list contains only wanted categories

Signed-off-by: JM Broust 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #31 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #30)
> I've tried again, same result:
> 
>  FAIL koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
>OK   forbidden patterns
>OK   git manipulation
>OK   spelling
>OK   tt_valid
>FAIL valid_template
>   The method quick_add_display is not covered by tests!

Hum, this looks like a false positive. If you do not recreate the problem using
the interface I'd ignore it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit
   ||y.org

--- Comment #30 from Katrin Fischer  ---
I've tried again, same result:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   FAIL   valid_template
The method quick_add_display is not covered by tests!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #29 from Katrin Fischer  ---
Hi Frido, can you please check again?

- applied patches
- ran updatedatabase
- restart_all

And I still have the same error in the QA tools :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

--- Comment #28 from Fridolin SOMERS  ---
Created attachment 73604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73604=edit
Bug 18818: DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

--- Comment #27 from Fridolin SOMERS  ---
Ah ok its missing a patch for DBIX class files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #26 from Katrin Fischer  ---
There is an error in the QA test tools. please fix!

 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   FAIL   valid_template
The method quick_add_display is not covered by tests!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|Manage categories displayed |Manage categories displayed
   |in Quick_add patron list|in Quick add patron list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/