[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Abbey Holt  changed:

   What|Removed |Added

 CC||ah...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-05-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #192 from Andrew Fuerste-Henry  ---
I wasn't able to apply these to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #191 from Alex Arnaud  ---
All patches are rebased.

Added a new patch to combine "Duplicate" and "New Catalog Record" save targets?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94452|0   |1
is obsolete||

--- Comment #189 from Alex Arnaud  ---
Created attachment 99108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99108=edit
Bug 18823: typo on loggelogged_in_user

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #190 from Alex Arnaud  ---
Created attachment 99109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99109=edit
Bug 18823: combine Duplicate and New Catalog Record save targets

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94450|0   |1
is obsolete||

--- Comment #187 from Alex Arnaud  ---
Created attachment 99106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99106=edit
Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected
along with MARC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94449|0   |1
is obsolete||

--- Comment #186 from Alex Arnaud  ---
Created attachment 99105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99105=edit
Bug 18823: reduce batches management modal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94447|0   |1
is obsolete||

--- Comment #184 from Alex Arnaud  ---
Created attachment 99103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99103=edit
Bug 18823: C4::Koha::GetNormalizedISBN loading

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94451|0   |1
is obsolete||

--- Comment #188 from Alex Arnaud  ---
Created attachment 99107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99107=edit
Bug 18823: Fix save button size and show searchable backends only in search
result

Signed-off-by: Cori Lynn Arnold 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94448|0   |1
is obsolete||

--- Comment #185 from Alex Arnaud  ---
Created attachment 99104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99104=edit
Bug 18823: center sucess saving message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94442|0   |1
is obsolete||

--- Comment #179 from Alex Arnaud  ---
Created attachment 99098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99098=edit
Bug 18823: Check Batch and Record save target when importing a record from a
batch.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94445|0   |1
is obsolete||

--- Comment #182 from Alex Arnaud  ---
Created attachment 99101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99101=edit
Bug 18823: Add pod for UpdateMarcTimestamp and template filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94446|0   |1
is obsolete||

--- Comment #183 from Alex Arnaud  ---
Created attachment 99102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99102=edit
Bug 18823: add unit tests for added/changed subroutines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #9|0   |1
is obsolete||

--- Comment #181 from Alex Arnaud  ---
Created attachment 99100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99100=edit
Bug 18823: Fix targets registering

Signed-off-by: cori 
ebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94443|0   |1
is obsolete||

--- Comment #180 from Alex Arnaud  ---
Created attachment 99099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99099=edit
Bug 18823: Don't show/check batch that are not enabled for saved targets

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94441|0   |1
is obsolete||

--- Comment #178 from Alex Arnaud  ---
Created attachment 99097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99097=edit
Bug 18823: Keep Batch selected and remove record backends when needed.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94440|0   |1
is obsolete||

--- Comment #177 from Alex Arnaud  ---
Created attachment 99096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99096=edit
Bug 18823: Search improvements

Search can now find titles and keywords with single quotes i.e. "Time
Traveler's Wife" in import batches.

Tests:

1) Open advanced cataloging edtior
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets
(and some both)
3.a) note that import batches for saving appear on the left
 side as targets to save
4) Search for a bibliographic record, make changes and apply to
 an import batch
5) Search for the bibliographic record in the import batch by
 author, title, isbn
6) Make changes to the import batch records and verify the
 changes are applied (either through searching again, or through
 the Staged MARC management page in Tools)

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94439|0   |1
is obsolete||

--- Comment #176 from Alex Arnaud  ---
Created attachment 99095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99095=edit
Bug 18823: Rancor - improve batch search/update ISBN handling

Rebase

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94436|0   |1
is obsolete||

--- Comment #173 from Alex Arnaud  ---
Created attachment 99092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99092=edit
Bug 18823: Rancor - add support for editing/searching records

rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94438|0   |1
is obsolete||

--- Comment #175 from Alex Arnaud  ---
Created attachment 99094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99094=edit
Bug 18823: Rancor - save override warnings

Rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #94437|0   |1
is obsolete||

--- Comment #174 from Alex Arnaud  ---
Created attachment 99093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99093=edit
Bug 18823: Improvements to import batch searching and enabled/disabled

Rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2020-01-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

--- Comment #172 from Cori Lynn Arnold  ---

Alex,

Please address Nick's comment 171 re:  "Edit as new (Duplicate)"

I think it's fine if we just label it that. 

Also, please make sure to provide a thorough test plan before sending it back
to "Needs Sign Off" 

Thanks!
-cori lynn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #171 from Nick Clemens  ---
> 
> At the start, the "Duplicate" batch is not intented to appear in the batch
> list (and so not intented to be checked).
> The feature come from Bug 16232 and is used from the record detail page.
> Bug 23436 make this batch appear properly in the lits.
> 
> I'm not the initiator of this feature. So i'm listening to the librarians
> for how to use these "Duplicate", "New record".
> Feedbacks are welcome.

Duplicate is equivalent to "Edit as new (Duplicate)" in the old editor - so I
think Duplicate and New Catalog Record can be combined to "New catalog record"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #170 from Cori Lynn Arnold  ---

As discussed on IRC, the use cases are that a cataloger needs to be able to
save, edit, and delete records in an import batch. 

We (at DGI) are not sticklers on the interface or how that gets handled by the
GUI, but we *need* the feature to work, and work soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #169 from Cori Lynn Arnold  ---

In my opinion, this is working as we, the initiators of this feature, expect.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #168 from Alex Arnaud  ---
(In reply to Nick Clemens from comment #150)
> Minor conflict from new clipboard feature on rancor
Rebased
> 
> Preferences.Save( [% loggelogged_in_user.borrowernumber | $raw %] );
> Should be 'logged_in_user'?
Fixed
> 
> This is very awesome! It seems to work as expected for the most part, but I
> found some functional issues that I think must be addressed:
> 
> After saving duplicate we should use the new record number and duplicate
> should be unchecked - is essentially 'Save as new'?
> 
> Checking 'Catalog record ##' and 'New catalog record' would imply duplicate,
> but it doesn't do that - maybe we shouldn't have 'New catalog record' when
> editing an existing record?
> 
> Similarly, saving as 'Duplicate' and 'New catalog record' creates two new
> records if I uncheck the current record.
I'm quite confused with this "Duplicate" batch. It's apparently the same as
"New catalog record".
But "New record" almost works as we want: After saving, the new record id is
checked. Almost because we may
uncheck "New record" (?).

At the start, the "Duplicate" batch is not intented to appear in the batch list
(and so not intented to be checked).
The feature come from Bug 16232 and is used from the record detail page.
Bug 23436 make this batch appear properly in the lits.

I'm not the initiator of this feature. So i'm listening to the librarians for
how to use these "Duplicate", "New record".
Feedbacks are welcome.

> 
> Saving to "Batch: test" and "test: #5" is confusing, do I need to check
> both? the Batch seems superfluous, I am not sure that unchecking the
> specific record and selecting only the batch is clear that we are creating a
> new record, maybe if a specific record is not checked we can show "Batch:
> test (new record)"

"Batch: test" is the current batch you are working on. 
We keep it checked so that you can create new records and save them without to
re-check the batch.

"test: #5" tells you are working on the record #5 saved in the test batch.

If you save again a record keeping "Batch: test" and "test: #5" checked. The
record is updated in the batch.
If you uncheck "test: #5" and save, we try to save a new record with the same
id in the batch Test => Error, duplicate id
Keeping only "test: #5" checked seems also updating the record in the batch.

Once again i would appreciate some feedback from Rancor users.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #167 from Alex Arnaud  ---
Created attachment 94452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94452=edit
Bug 18823: typo on loggelogged_in_user

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #92124|0   |1
is obsolete||

--- Comment #166 from Alex Arnaud  ---
Created attachment 94451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94451=edit
Bug 18823: Fix save button size and show searchable backends only in search
result

Signed-off-by: Cori Lynn Arnold 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91217|0   |1
is obsolete||

--- Comment #163 from Alex Arnaud  ---
Created attachment 94448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94448=edit
Bug 18823: center sucess saving message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91219|0   |1
is obsolete||

--- Comment #165 from Alex Arnaud  ---
Created attachment 94450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94450=edit
Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected
along with MARC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91218|0   |1
is obsolete||

--- Comment #164 from Alex Arnaud  ---
Created attachment 94449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94449=edit
Bug 18823: reduce batches management modal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91216|0   |1
is obsolete||

--- Comment #162 from Alex Arnaud  ---
Created attachment 94447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94447=edit
Bug 18823: C4::Koha::GetNormalizedISBN loading

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91215|0   |1
is obsolete||

--- Comment #161 from Alex Arnaud  ---
Created attachment 94446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94446=edit
Bug 18823: add unit tests for added/changed subroutines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91212|0   |1
is obsolete||

--- Comment #158 from Alex Arnaud  ---
Created attachment 94443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94443=edit
Bug 18823: Don't show/check batch that are not enabled for saved targets

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91213|0   |1
is obsolete||

--- Comment #159 from Alex Arnaud  ---
Created attachment 9
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9=edit
Bug 18823: Fix targets registering

Signed-off-by: cori 
ebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91214|0   |1
is obsolete||

--- Comment #160 from Alex Arnaud  ---
Created attachment 94445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94445=edit
Bug 18823: Add pod for UpdateMarcTimestamp and template filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91206|0   |1
is obsolete||

--- Comment #152 from Alex Arnaud  ---
Created attachment 94437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94437=edit
Bug 18823: Improvements to import batch searching and enabled/disabled

Rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91211|0   |1
is obsolete||

--- Comment #157 from Alex Arnaud  ---
Created attachment 94442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94442=edit
Bug 18823: Check Batch and Record save target when importing a record from a
batch.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91208|0   |1
is obsolete||

--- Comment #154 from Alex Arnaud  ---
Created attachment 94439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94439=edit
Bug 18823: Rancor - improve batch search/update ISBN handling

Rebase

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91209|0   |1
is obsolete||

--- Comment #155 from Alex Arnaud  ---
Created attachment 94440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94440=edit
Bug 18823: Search improvements

Search can now find titles and keywords with single quotes i.e. "Time
Traveler's Wife" in import batches.

Tests:

1) Open advanced cataloging edtior
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets
(and some both)
3.a) note that import batches for saving appear on the left
 side as targets to save
4) Search for a bibliographic record, make changes and apply to
 an import batch
5) Search for the bibliographic record in the import batch by
 author, title, isbn
6) Make changes to the import batch records and verify the
 changes are applied (either through searching again, or through
 the Staged MARC management page in Tools)

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91207|0   |1
is obsolete||

--- Comment #153 from Alex Arnaud  ---
Created attachment 94438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94438=edit
Bug 18823: Rancor - save override warnings

Rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91210|0   |1
is obsolete||

--- Comment #156 from Alex Arnaud  ---
Created attachment 94441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94441=edit
Bug 18823: Keep Batch selected and remove record backends when needed.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #91205|0   |1
is obsolete||

--- Comment #151 from Alex Arnaud  ---
Created attachment 94436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94436=edit
Bug 18823: Rancor - add support for editing/searching records

rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #150 from Nick Clemens  ---
Minor conflict from new clipboard feature on rancor

Preferences.Save( [% loggelogged_in_user.borrowernumber | $raw %] );
Should be 'logged_in_user'?

This is very awesome! It seems to work as expected for the most part, but I
found some functional issues that I think must be addressed:

After saving duplicate we should use the new record number and duplicate should
be unchecked - is essentially 'Save as new'?

Checking 'Catalog record ##' and 'New catalog record' would imply duplicate,
but it doesn't do that - maybe we shouldn't have 'New catalog record' when
editing an existing record?

Similarly, saving as 'Duplicate' and 'New catalog record' creates two new
records if I uncheck the current record.

Saving to "Batch: test" and "test: #5" is confusing, do I need to check both?
the Batch seems superfluous, I am not sure that unchecking the specific record
and selecting only the batch is clear that we are creating a new record, maybe
if a specific record is not checked we can show "Batch: test (new record)"

The export feature is awesome - it would be nice to have this on the 'Manage
staged records' page too, but not a blocker here

Not a blocker, but if I revert and imported batch should I be able to manage
that batch in Rancor?
Similarly, if I stage a new batch I must reload rancor to be able to manage
that batch

Some overall GUI cleanup would be nice, but I think this can go as is with
improvement later

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

  Attachment #92120|0   |1
is obsolete||

--- Comment #149 from Cori Lynn Arnold  ---
Created attachment 92124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92124=edit
Bug 18823: Fix save button size and show searchable backends only in search
result

Signed-off-by: Cori Lynn Arnold 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #148 from Alex Arnaud  ---
Created attachment 92120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92120=edit
Bug 18823: Fix save button size and show searchable backends only in search
result

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #92051|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #147 from Cori Lynn Arnold  ---

Two minor issues: 

First: The drop-down portion of the save button isn't in-line with the rest of
the button

https://paste.pics/84b44eda4c05379bcc729c1884d1a292

Second: Checking the "Searchable?" checkbox in the import batches popup seems
to have no effect on the search box searching.

To recreate:
1. Create an import batch, make it searchable / save target
2. Save a record to the import batch 
3. Search for the record using the left-hand search box (i.e. not advanced),
verify it appears in the import batch 
4. Uncheck the box for "Searchable" in the import batch screen
5. Search for the record using the left-hand search box, the import batch is
searched

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #146 from Cori Lynn Arnold  ---
Created attachment 92051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92051=edit
Bug 11529: (RM follow-up) Add WHILE to directive list

The QA tools don't current recognise the WHILE directive used in this
template update. This patch adds the keyword to the list of recognised
directives and thus allows through unfiltered variables during QA runs.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

 Depends on||23436


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23436
[Bug 23436] Undefined named save backend in advanced editor
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #145 from Cori Lynn Arnold  ---
Alex, I looked at bug 16232.

The left hand box with the targets doesn't exist until this patch, so the issue
is caused by this patch, not that one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #144 from Alex Arnaud  ---
That last error seems to be introduced by Bug 16232

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #143 from Alex Arnaud  ---
Can't see this error.
It seems odd to me that there is this kind of issue here (insert_copyright is
not defined at marc-editor.js:140)

Using chromium

But i have an other error with firefox:
TypeError: a.label is undefined

This one prevents the editor to be loaded too.
Working on first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #142 from Cori Lynn Arnold  ---

Patches apply, but going to the advanced editor causes a javascript error that
prevents the page from fully loading:

Uncaught ReferenceError: insert_copyright is not defined
at marc-editor.js:140
at Object.execCb (require_19.0600010.js:29)
at X.check (require_19.0600010.js:18)
at X. (require_19.0600010.js:23)
at require_19.0600010.js:8
at require_19.0600010.js:23
at y (require_19.0600010.js:7)
at X.emit (require_19.0600010.js:23)
at X.check (require_19.0600010.js:19)
at X. (require_19.0600010.js:23)

https://snag.gy/4eWg7B.jpg

using Chrome browser.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88506|0   |1
is obsolete||

--- Comment #140 from Alex Arnaud  ---
Created attachment 91218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91218=edit
Bug 18823: reduce batches management modal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88505|0   |1
is obsolete||

--- Comment #139 from Alex Arnaud  ---
Created attachment 91217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91217=edit
Bug 18823: center sucess saving message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88507|0   |1
is obsolete||

--- Comment #141 from Alex Arnaud  ---
Created attachment 91219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91219=edit
Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected
along with MARC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88504|0   |1
is obsolete||

--- Comment #138 from Alex Arnaud  ---
Created attachment 91216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91216=edit
Bug 18823: C4::Koha::GetNormalizedISBN loading

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88503|0   |1
is obsolete||

--- Comment #137 from Alex Arnaud  ---
Created attachment 91215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91215=edit
Bug 18823: add unit tests for added/changed subroutines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88502|0   |1
is obsolete||

--- Comment #136 from Alex Arnaud  ---
Created attachment 91214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91214=edit
Bug 18823: Add pod for UpdateMarcTimestamp and template filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88500|0   |1
is obsolete||

--- Comment #134 from Alex Arnaud  ---
Created attachment 91212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91212=edit
Bug 18823: Don't show/check batch that are not enabled for saved targets

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88501|0   |1
is obsolete||

--- Comment #135 from Alex Arnaud  ---
Created attachment 91213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91213=edit
Bug 18823: Fix targets registering

Signed-off-by: cori 
ebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88498|0   |1
is obsolete||

--- Comment #132 from Alex Arnaud  ---
Created attachment 91210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91210=edit
Bug 18823: Keep Batch selected and remove record backends when needed.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88499|0   |1
is obsolete||

--- Comment #133 from Alex Arnaud  ---
Created attachment 91211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91211=edit
Bug 18823: Check Batch and Record save target when importing a record from a
batch.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88493|0   |1
is obsolete||

--- Comment #127 from Alex Arnaud  ---
Created attachment 91205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91205=edit
Bug 18823: Rancor - add support for editing/searching records

rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88497|0   |1
is obsolete||

--- Comment #131 from Alex Arnaud  ---
Created attachment 91209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91209=edit
Bug 18823: Search improvements

Search can now find titles and keywords with single quotes i.e. "Time
Traveler's Wife" in import batches.

Tests:

1) Open advanced cataloging edtior
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets
(and some both)
3.a) note that import batches for saving appear on the left
 side as targets to save
4) Search for a bibliographic record, make changes and apply to
 an import batch
5) Search for the bibliographic record in the import batch by
 author, title, isbn
6) Make changes to the import batch records and verify the
 changes are applied (either through searching again, or through
 the Staged MARC management page in Tools)

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88495|0   |1
is obsolete||

--- Comment #129 from Alex Arnaud  ---
Created attachment 91207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91207=edit
Bug 18823: Rancor - save override warnings

Rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88496|0   |1
is obsolete||

--- Comment #130 from Alex Arnaud  ---
Created attachment 91208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91208=edit
Bug 18823: Rancor - improve batch search/update ISBN handling

Rebase

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88494|0   |1
is obsolete||

--- Comment #128 from Alex Arnaud  ---
Created attachment 91206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91206=edit
Bug 18823: Improvements to import batch searching and enabled/disabled

Rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #126 from Cori Lynn Arnold  ---
Failed to apply:

Applying: Bug 18823: Rancor - add support for editing/searching records
Using index info to reconstruct a base tree...
M   C4/Biblio.pm
M   cataloguing/editor.pl
M   koha-tmpl/intranet-tmpl/prog/css/cateditor.css
M   koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
M   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
Auto-merging koha-tmpl/intranet-tmpl/prog/css/cateditor.css
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/css/cateditor.css
Auto-merging cataloguing/editor.pl
Auto-merging C4/Biblio.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 18823: Rancor - add support for editing/searching
records
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-18823-Rancor---add-support-for-editingsearchin-0J4EtP.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88508|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #125 from Cori Lynn Arnold  ---

Alex, yes, I'm okay with that. I didn't think through the implications of
getting rid of the record # in the box.

-cori lynn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #124 from Alex Arnaud  ---
This is a consequence of removing record number (the last patch).

Katrin said: "Once saved for the first time, both: 'new record' and 'catalog
record #' are checked. I'd expect it to create a duplicate in that case."

But now i see the benefit of keeping it. After saving a record in a batch, i
think there is 2 options:

1) Update the record because you made a mistake
   - let the "Batch: batch_name" checked,
   - let the "batch_name: #id" checked
So that the record is updated in the batch.

2) Save a new record in the same batch from the already saved record
   - make a few changes on record
   - let the "Batch: batch_name" checked,
   - uncheck "batch_name: #id"
New record saved

So, let the record number seems to fix the problem. Are you ok with that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #123 from Cori Lynn Arnold  ---


Cannot update record

Steps:
0. Create an import batch for "Saving / Searching"
1. Search for a title: "Machine Man by Max Barry"
2. Click "Import"
3. Check the box for your import batch in step 0.
4. Hit "Save"
5. Change the publisher to "TEST OF CHANGE TO PUBLISHER"
6. Hit "Save" 
7. Error "Conflict Error Cannot Save"

Expected result:

a. Update the record with the same controlNum

Catalogers make mistakes, we must be able to fix them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88431|0   |1
is obsolete||

--- Comment #121 from Alex Arnaud  ---
Created attachment 88507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88507=edit
Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected
along with MARC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88430|0   |1
is obsolete||

--- Comment #120 from Alex Arnaud  ---
Created attachment 88506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88506=edit
Bug 18823: reduce batches management modal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88432|0   |1
is obsolete||

--- Comment #122 from Alex Arnaud  ---
Created attachment 88508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88508=edit
Bug 18823: Don't keep record number checked after saving

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88429|0   |1
is obsolete||

--- Comment #119 from Alex Arnaud  ---
Created attachment 88505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88505=edit
Bug 18823: center sucess saving message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88427|0   |1
is obsolete||

--- Comment #117 from Alex Arnaud  ---
Created attachment 88503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88503=edit
Bug 18823: add unit tests for added/changed subroutines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88428|0   |1
is obsolete||

--- Comment #118 from Alex Arnaud  ---
Created attachment 88504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88504=edit
Bug 18823: C4::Koha::GetNormalizedISBN loading

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88424|0   |1
is obsolete||

--- Comment #114 from Alex Arnaud  ---
Created attachment 88500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88500=edit
Bug 18823: Don't show/check batch that are not enabled for saved targets

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88426|0   |1
is obsolete||

--- Comment #116 from Alex Arnaud  ---
Created attachment 88502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88502=edit
Bug 18823: Add pod for UpdateMarcTimestamp and template filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88422|0   |1
is obsolete||

--- Comment #112 from Alex Arnaud  ---
Created attachment 88498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88498=edit
Bug 18823: Keep Batch selected and remove record backends when needed.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88418|0   |1
is obsolete||

--- Comment #108 from Alex Arnaud  ---
Created attachment 88494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88494=edit
Bug 18823: Improvements to import batch searching and enabled/disabled

Rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88420|0   |1
is obsolete||

--- Comment #110 from Alex Arnaud  ---
Created attachment 88496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88496=edit
Bug 18823: Rancor - improve batch search/update ISBN handling

Rebase

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88425|0   |1
is obsolete||

--- Comment #115 from Alex Arnaud  ---
Created attachment 88501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88501=edit
Bug 18823: Fix targets registering

Signed-off-by: cori 
ebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88423|0   |1
is obsolete||

--- Comment #113 from Alex Arnaud  ---
Created attachment 88499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88499=edit
Bug 18823: Check Batch and Record save target when importing a record from a
batch.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88421|0   |1
is obsolete||

--- Comment #111 from Alex Arnaud  ---
Created attachment 88497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88497=edit
Bug 18823: Search improvements

Search can now find titles and keywords with single quotes i.e. "Time
Traveler's Wife" in import batches.

Tests:

1) Open advanced cataloging edtior
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets
(and some both)
3.a) note that import batches for saving appear on the left
 side as targets to save
4) Search for a bibliographic record, make changes and apply to
 an import batch
5) Search for the bibliographic record in the import batch by
 author, title, isbn
6) Make changes to the import batch records and verify the
 changes are applied (either through searching again, or through
 the Staged MARC management page in Tools)

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88419|0   |1
is obsolete||

--- Comment #109 from Alex Arnaud  ---
Created attachment 88495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88495=edit
Bug 18823: Rancor - save override warnings

Rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #88417|0   |1
is obsolete||

--- Comment #107 from Alex Arnaud  ---
Created attachment 88493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88493=edit
Bug 18823: Rancor - add support for editing/searching records

rebase.

Signed-off-by: cori 
Rebased-on: 2019-03-20 Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #106 from Alex Arnaud  ---
(In reply to Katrin Fischer from comment #89)
> 
> 2) Unit tests
> 
> c) Changes to Koha/MetaSearcher are untested.
> d) New svc/cataloguing/import_batches is untested.
> e) New svc/cataloguing/metasearch
As far as i know, we don't test scripts in svc (currently 0 test). I'm not
aware
of a valid method to do that.

About Koha/MetaSearcher. I started writing units tests but i encountered a
problem:
The method in charge of searching use forked process. That make the db context
set in UT lost.
The only way i found to make it works: commit all db changes. But this is quite
unsafe.
> 
> 5) Some first notes from GUI testing
> 
> a) I am not completely sold on the placement of the 'Save to' box. It
> already looks a bit 'squashed' and it will look worse in other languages
> (being German I know our words for things tend to be longer)
>
I also have long batch names. But i believe text is properly handle with line
returns.
And i think this box positioning/sizing is consistent with the search one.
Maybe you/someone can do a better proposal

I think all the rest is fixed or improved.
Put this back to needs signoff since there is some behavior changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #103 from Alex Arnaud  ---
Created attachment 88430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88430=edit
Bug 18823: reduce batches management modal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #102 from Alex Arnaud  ---
Created attachment 88429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88429=edit
Bug 18823: center sucess saving message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >