[Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Fridolin SOMERS  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #36 from Fridolin SOMERS  ---
17.05.x end of life is in septembre so I will keep as it is

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #35 from Mirko Tietgen  ---
Ok, it is, in this order,

18285
18286
18287
18288
18289
18226
18851

No rebase needed. All tests run fine afterwards (not checked db-dependent)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #34 from Mirko Tietgen  ---
Nevermind, it fails a lot more tests afterwards. There is more missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #33 from Mirko Tietgen  ---
Fridolin: I suppose you missed that it depends on bug 18226. I could easily
apply both to 17.05.x, there is just one test to 'git add'. This would probably
fix the failing t/XSLT.t in 17.05.x (with Test::DBiX::Class but without DB, as
on the nightly server). Would you reconsider pushing to 17.05.x?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Katrin Fischer  changed:

   What|Removed |Added

Summary|use Test::DBIx::Class in|Use Test::DBIx::Class in
   |tests breaks packaging  |tests breaks packaging
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #32 from Fridolin SOMERS  ---
I have a lot of conflicts during rebase on 17.05.x and I'm not sure my test env
is well configured to mock DB.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #31 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #30 from Tomás Cohen Arazi  ---
I successfully ran all the tests:
- With and without a DB server running
- With and without Test::DBIx::Class installed

Added a tiny followup to avoid irrelevant warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #29 from Tomás Cohen Arazi  ---
Created attachment 65579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65579=edit
Bug 18851: (QA followup) Test doesn't need sessions on DB

As the DB structure is not initialized for sessions, running this tests raise
an irrelevant warning.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65368|0   |1
is obsolete||

--- Comment #28 from Tomás Cohen Arazi  ---
Created attachment 65578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65578=edit
Bug 18851: Fix few other tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65199|0   |1
is obsolete||

--- Comment #27 from Tomás Cohen Arazi  ---
Created attachment 65577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65577=edit
Bug 18851: Make OverDrive.T pass if dbms is not running

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #64990|0   |1
is obsolete||

--- Comment #24 from Tomás Cohen Arazi  ---
Created attachment 65574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65574=edit
Bug 18851: Database handler must not be created at runtime

Signed-off-by: Mirko Tietgen 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #64991|0   |1
is obsolete||

--- Comment #25 from Tomás Cohen Arazi  ---
Created attachment 65575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65575=edit
Bug 18851: Test::DBIx::Class is not needed in 00-load.t

Signed-off-by: Mirko Tietgen 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #64992|0   |1
is obsolete||

--- Comment #26 from Tomás Cohen Arazi  ---
Created attachment 65576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65576=edit
Bug 18851: Tests must be skipped in cardnumber.t if Test::DBIx::Class is not
installed

Signed-off-by: Mirko Tietgen 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #64993|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart  
---
Created attachment 65368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65368=edit
Bug 18851: Fix few other tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #22 from Nick Clemens  ---
With SQL stopped and no Test::DBIx::Class - all pass

With SQL stopped and Test::DBIx::Class:
t/Patron.t(Wstat: 65280 Tests: 2 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 11 tests but ran 2.
t/SuggestionEngine_AuthorityFile.t (Wstat: 256 Tests: 4 Failed: 1)
  Failed test:  4
  Non-zero exit status: 1
  Parse errors: Bad plan.  You planned 46 tests but ran 4.
t/XSLT.t  (Wstat: 65280 Tests: 8 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 9 tests but ran 8.

With SQL started and no Test::DBIx::Class - all pass

With SQL started and Test::DBIx::Class:
t/SuggestionEngine_AuthorityFile.t (Wstat: 256 Tests: 4 Failed: 1)
  Failed test:  4
  Non-zero exit status: 1
  Parse errors: Bad plan.  You planned 46 tests but ran 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #21 from Jonathan Druart  
---
Created attachment 65199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65199=edit
Bug 18851: Make OverDrive.T pass if dbms is not running

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #20 from Nick Clemens  ---
These all work for me, however, t/Koha_ExternalContent_OverDrive.t fails for me
without a db. Can you test with WebService::ILS::OverDrive::Patron installed
and verify?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Jonathan Druart  changed:

   What|Removed |Added

Summary|use Test::DBIx::Class in|use Test::DBIx::Class in
   |00-load.t breaks packaging  |tests breaks packaging

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/