[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Katrin Fischer changed: What|Removed |Added Component|Circulation |Architecture, internals, ||and plumbing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Katrin Fischer changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Severity|trivial |enhancement Resolution|--- |FIXED --- Comment #20 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #19 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.02 Dead code go to hell ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #17 from Marcel de Rooy --- Taking the liberty to move this directly into PQA now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added Attachment #64761|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #16 from Marcel de Rooy --- Created attachment 64770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64770&action=edit Bug 18881: [QA Follow-up] Remove even more Removing the commented section from the template: If it does not work, it should not be here. When it works again, put it back in. Since @itemtypesloop is not used, remove it from the script too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #15 from Marcel de Rooy --- Created attachment 64769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64769&action=edit Bug 18881: Remove dead code from view_holdsqueue.pl Aleisha spotted the typo in $itemtypes and proposed a correction on bug 18859. The description was not even used. Template calls GetDescription. To test: Verify that viewing the holds queue still works as expected. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added Depends on|18859 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 [Bug 18859] Warns when accessing Circulation -> Holds Queue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Bug 18881 depends on bug 18859, which changed state. Bug 18859 Summary: Warns when accessing Circulation -> Holds Queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 What|Removed |Added Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #14 from Marcel de Rooy --- *** Bug 18859 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #13 from Marc Véron --- (In reply to Marcel de Rooy from comment #12) > Applying: Bug 18881: Remove dead code in circ/view_holdsqueue.pl > fatal: sha1 information is lacking or useless (circ/view_holdsqueue.pl). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. Re-tested, applies cleanly here (on top of Bug 18859). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Marcel de Rooy --- Applying: Bug 18881: Remove dead code in circ/view_holdsqueue.pl fatal: sha1 information is lacking or useless (circ/view_holdsqueue.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marc Véron changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #11 from Marc Véron --- Created attachment 64761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64761&action=edit Bug 18881: Remove dead code in circ/view_holdsqueue.pl Remove a line of dead code from circ/view_holdsqueue.pl To test: - Apply patch - Go to Home > Circulation > Holds queue - Verify that description in Item type column displays as before - Create a translation for an item type: Home > Administration > Item types > Modify item type 'BK' There you have a link 'Translate into other languages' to create translations To test, you can even 'translate' for English to overwrite the original description. - Verify that the translated descriptions displays when changing the language as appropriate - For an explanation how translation of item types descriptions work and why it is not done with Pootle see comment #7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marc Véron changed: What|Removed |Added Attachment #64726|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marc Véron changed: What|Removed |Added Status|Failed QA |ASSIGNED Summary|Change comment about|Remove dead code in |translated itemtype |circ/view_holdsqueue.pl |description in | |circ/view_holdsqueue.pl | --- Comment #10 from Marc Véron --- (In reply to Marcel de Rooy from comment #9) > If we remove this comment, some day somebody wonders again why we do not use > the translated description. > So instead of removing I would opt for adding a legitimate reason why we > really do not want a translation. The translation takes place by overlaying in the template, using the itemtype. The whole line is dead code. Changed bug title as appropriate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/