[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

  Attachment #73362|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #13 from M. Tompsett  ---
In order to apply just one or the other.

On a kohadevbox:
git checkout -b bug_18889_t1 origin/master
git bz apply 18889
i
-- that's interactive, and then you put # at the beginning of the
   line you do not want

I'll leave the setting of titles up to someone else.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #12 from M. Tompsett  ---
(In reply to Séverine Queune from comment #10)
> The 'Simpler counter-patch' doesn't apply.

It does by itself. That's the point of the counter-patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #11 from Séverine Queune  ---
Should title be "Add barcode to 'Fines' tab in biblio description" or something
like that ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #10 from Séverine Queune  ---
The 'Simpler counter-patch' doesn't apply.

> Applying: Bug 18889: Simpler counter-patch
> Using index info to reconstruct a base tree...
> M koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
> M members/pay.pl
> Falling back to patching base and 3-way merge...
> error: Your local changes to the following files would be overwritten by 
> merge:
>   members/pay.pl
> Please, commit your changes or stash them before you can merge.
> Aborting
> Failed to merge in the changes.
> Patch failed at 0001 Bug 18889: Simpler counter-patch
> The copy of the patch that failed is found in:
>/var/repositories/koha/.git/rebase-apply/patch

Barcode display is good applying only the first patch 'Storing and display of
barcode with fines in intranet'.

I'm not sure if I can sign or failed it because of the conflict.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #9 from M. Tompsett  ---
Counter Patch Test Plan

1) Add a manual fine with a barcode to a member.
2) Look at the pay invoice tab.
   -- no barcode shown.
3) apply counter patch only patch
   -- and no updatedatabase or rebuilding tables required!
4) restart_all (silly plack caching)
5) refresh the pay invoice tab.
   -- barcode now displayed.
6) run koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #8 from M. Tompsett  ---
Created attachment 73519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73519=edit
Bug 18889: Simpler counter-patch

There is no need to add barcode into the accountlines
table, as a relationship via itemnumber can easily look it up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #7 from M. Tompsett  ---
Comment on attachment 73362
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73362
Bug 18889 - Storing and display of barcode with fines in intranet

Review of attachment 73362:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18889=73362)
-

::: C4/Accounts.pm
@@ +281,4 @@
>  date  => \'NOW()',
>  amount=> $amount,
>  description   => $desc,
> +barcode   => $barcode,

Why pass barcode when the itemnumber is available?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #6 from Alex Buckley  ---
I have recorded some screencast videos showing the behaviour of the bug before
applying the patch and following the test plan after applying the patch and
running steps 4 and 5. If you are testing this and are confused about the test
plan I will happily email these videos to you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #4 from Alex Buckley  ---
Created attachment 73365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73365=edit
Patch applies cleanly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #5 from Alex Buckley  ---
Created attachment 73366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73366=edit
Circled barcode in the pay fines table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #3 from Alex Buckley  ---
Created attachment 73362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73362=edit
Bug 18889 - Storing and display of barcode with fines in intranet

Test plan:
1. Create a manual invoice fine making sure you enter in a barcode value

2. Go to the 'Pay fines' tab and notice that the barcode value is not
displayed

3. Apply patch

4. Update your database by running the updatedatabase.pl script in
koha-shell

This will run the atomicupdate file
bug_18889_added_barcode_field_to_accountlines.sql which contains the
database changes

5. Update your DBIx by running the command (in the Koha root directory):
misc/devel/update_dbix_class_files.pl --db_name= --db_user=
--db_pass=

6. Repeat step 1 and 2 and notice that there is a new front end column
in the 'Pay fines' page which displays the item barcode

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

  Attachment #69352|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||david.bourga...@inlibro.com

--- Comment #2 from David Bourgault  ---
Patch had a minor conflict when applying.

When following test plan I got the following:

Software error:

DBIC result _type  isn't of the _type Category at members/moremember.pl line
138.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

   Assignee|amitddng...@gmail.com   |alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #1 from Alex Buckley  ---
Created attachment 69352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69352=edit
Bug 18889 - Storing and display of barcode with fines in intranet

Test plan:
1. Create a manual invoice fine making sure you enter in a barcode value

2. Go to the 'Pay fines' tab and notice that the barcode value is not
displayed

3. Apply patch

4. Update your database by running the updatedatabase.pl script in
koha-shell

This will run the atomicupdate file
bug_18889_added_barcode_field_to_accountlines.sql which contains the
database changes

5. Update your DBIx by running the command (in the Koha root directory):
misc/devel/update_dbix_class_files.pl --db_name= --db_user=
--db_pass=

6. Repeat step 1 and 2 and notice that there is a new front end column
in the 'Pay fines' page which displays the item barcode

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Amit Gupta  changed:

   What|Removed |Added

 CC||amitddng...@gmail.com
 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |amitddng...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

vimal kumar  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/