[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

--- Comment #15 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #14)
> Sounds like we have other tests failing:
> 
> #   Failed test 'Syntax check misc/search_tools/rebuild_elastic_search.pl'
> #   at /usr/share/perl5/Test/Strict.pm line 406.
> # Can't locate Catmandu/Importer/MARC.pm in @INC (you may need to install
> the Catmandu::Importer::MARC module) (@INC contains: installer
> misc/translator /kohadevbox/koha /etc/perl
> /usr/local/lib/x86_64-linux-gnu/perl/5.20.2
> /usr/local/share/perl/5.20.2/x86_64-linux-gnu-thread-multi
> /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20
> /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
> /usr/local/lib/site_perl . /kohadevbox/koha /etc/perl
> /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2
> /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5
> /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
> /usr/local/lib/site_perl .) at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 26.
> # BEGIN failed--compilation aborted at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 26.
> # Compilation failed in require at
> misc/search_tools/rebuild_elastic_search.pl line 89.
> # BEGIN failed--compilation aborted at
> misc/search_tools/rebuild_elastic_search.pl line 89.
> # Looks like you failed 1 test of 663.
> [23:53:44] t/db_dependent/00-strict.t
> 
> 
> 
> #   Failed test 'use Koha::SearchEngine::Elasticsearch::Search;'
> #   at t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
> # Tried to use 'Koha::SearchEngine::Elasticsearch::Search'.
> # Error:  Can't locate Catmandu/Store/ElasticSearch.pm in @INC (you may
> need to install the Catmandu::Store::ElasticSearch module) (@INC contains:
> /kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2
> /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20
> /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
> /usr/local/lib/site_perl .) at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 49.
> # BEGIN failed--compilation aborted at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 49.
> # Compilation failed in require at
> t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
> # BEGIN failed--compilation aborted at
> t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
> Can't locate object method "search" via package
> "Koha::SearchEngine::Elasticsearch::Search" at
> t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 47.
> # Looks like your test exited with 255 just after 4.
> [22:48:34] t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t

I would argue that OTHER failures are beyond the scope of this patch, and that
it should go back to passed QA, and two more bugs created.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #14 from Jonathan Druart  
---
Sounds like we have other tests failing:

#   Failed test 'Syntax check misc/search_tools/rebuild_elastic_search.pl'
#   at /usr/share/perl5/Test/Strict.pm line 406.
# Can't locate Catmandu/Importer/MARC.pm in @INC (you may need to install the
Catmandu::Importer::MARC module) (@INC contains: installer misc/translator
/kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2
/usr/local/share/perl/5.20.2/x86_64-linux-gnu-thread-multi
/usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20
/usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl . /kohadevbox/koha /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2
/usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl .) at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 26.
# BEGIN failed--compilation aborted at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 26.
# Compilation failed in require at misc/search_tools/rebuild_elastic_search.pl
line 89.
# BEGIN failed--compilation aborted at
misc/search_tools/rebuild_elastic_search.pl line 89.
# Looks like you failed 1 test of 663.
[23:53:44] t/db_dependent/00-strict.t



#   Failed test 'use Koha::SearchEngine::Elasticsearch::Search;'
#   at t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
# Tried to use 'Koha::SearchEngine::Elasticsearch::Search'.
# Error:  Can't locate Catmandu/Store/ElasticSearch.pm in @INC (you may
need to install the Catmandu::Store::ElasticSearch module) (@INC contains:
/kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2
/usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20
/usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl .) at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 49.
# BEGIN failed--compilation aborted at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 49.
# Compilation failed in require at
t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
# BEGIN failed--compilation aborted at
t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
Can't locate object method "search" via package
"Koha::SearchEngine::Elasticsearch::Search" at
t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 47.
# Looks like your test exited with 255 just after 4.
[22:48:34] t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66779|0   |1
is obsolete||

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 67523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67523=edit
Bug 18897: Use Module::Load::Conditional::can_load

Rather than rely on eval(), Jonathan Druart recommended in
comment #6 to use Use Module::Load::Conditional::can_load.
This addresses that concern.

TEST PLAN
-
$ git fetch
$ git checkout -b bug_18897 origin/master
$ git bz apply 18897
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
...
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the correct library is missing.
$ sudo apt-get install libcatmandu-store-elasticsearch-perl
-- Note it runs as expected.
run the koha qa test tools

Signed-off-by: Lee Jamison 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66569|0   |1
is obsolete||

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 67522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67522=edit
Bug 18897: Improve error message

Test Plan:
$ git fetch
$ git checkout -b bug_18897 origin/master
$ git bz apply 18897
-- interactive apply just the first patch
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
...
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the wrong library is missing.
$ git bz apply 18897
-- interactive apply this patch
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the correct library is missing.
run the koha qa test tools

Signed-off-by: Mark Tompsett 

Signed-off-by: Lee Jamison 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66568|0   |1
is obsolete||

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 67521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67521=edit
Bug 18897: Koha_Elasticsearch_Indexer.t doesn't skip when ES module(s) not
installed

If Catmandu::Importer::MARC is not installed,
Koha_Elasticsearch_Indexer.t fails instead of skipping.
It should skip as ES is not currently mandatory.

Test Plan:
1. Run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t"
   as koha-shell
2. Note failure on test 1/5 indicating module not installed.
3. Apply patch.
4. Re-run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t"
5. Note test now skips.

Signed-off-by: Mark Tompsett 

Signed-off-by: Lee Jamison 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18738

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Lee Jamison  changed:

   What|Removed |Added

  Attachment #66777|0   |1
is obsolete||

--- Comment #10 from Lee Jamison  ---
Created attachment 66779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66779=edit
Bug 18897: Use Module::Load::Conditional::can_load

Rather than rely on eval(), Jonathan Druart recommended in
comment #6 to use Use Module::Load::Conditional::can_load.
This addresses that concern.

TEST PLAN
-
$ git fetch
$ git checkout -b bug_18897 origin/master
$ git bz apply 18897
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
...
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the correct library is missing.
$ sudo apt-get install libcatmandu-store-elasticsearch-perl
-- Note it runs as expected.
run the koha qa test tools

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

--- Comment #9 from M. Tompsett  ---
Missed a line:

> TEST PLAN
> -
> $ git fetch
> $ git checkout -b bug_18897 origin/master
> $ git bz apply 18897
> $ sudo apt-get remove libcatmandu-store-elasticsearch-perl
> ...
> $ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
> -- Note that the message says the correct library is missing.
> $ sudo apt-get install libcatmandu-store-elasticsearch-perl
> $ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
> -- Note it runs as expected.
> run the koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

--- Comment #8 from M. Tompsett  ---
Created attachment 66777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66777=edit
Bug 18897: Use Module::Load::Conditional::can_load

Rather than rely on eval(), Jonathan Druart recommended in
comment #6 to use Use Module::Load::Conditional::can_load.
This addresses that concern.

TEST PLAN
-
$ git fetch
$ git checkout -b bug_18897 origin/master
$ git bz apply 18897
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
...
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the correct library is missing.
$ sudo apt-get install libcatmandu-store-elasticsearch-perl
-- Note it runs as expected.
run the koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

M. Tompsett  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #7 from Nick Clemens  ---
Failing per comment #6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
It would be better to use Module::Load::Conditional::can_load I think

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Lee Jamison  changed:

   What|Removed |Added

  Attachment #66479|0   |1
is obsolete||

--- Comment #5 from Lee Jamison  ---
Created attachment 66569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66569=edit
Bug 18897: Improve error message

Test Plan:
$ git fetch
$ git checkout -b bug_18897 origin/master
$ git bz apply 18897
-- interactive apply just the first patch
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
...
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the wrong library is missing.
$ git bz apply 18897
-- interactive apply this patch
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the correct library is missing.
run the koha qa test tools

Signed-off-by: Mark Tompsett 

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Lee Jamison  changed:

   What|Removed |Added

  Attachment #66478|0   |1
is obsolete||

--- Comment #4 from Lee Jamison  ---
Created attachment 66568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66568=edit
Bug 18897: Koha_Elasticsearch_Indexer.t doesn't skip when ES module(s) not
installed

If Catmandu::Importer::MARC is not installed,
Koha_Elasticsearch_Indexer.t fails instead of skipping.
It should skip as ES is not currently mandatory.

Test Plan:
1. Run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t"
   as koha-shell
2. Note failure on test 1/5 indicating module not installed.
3. Apply patch.
4. Re-run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t"
5. Note test now skips.

Signed-off-by: Mark Tompsett 

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
  Attachment #64818|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

--- Comment #3 from M. Tompsett  ---
Created attachment 66479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66479=edit
Bug 18897: Improve error message

Test Plan:
$ git fetch
$ git checkout -b bug_18897 origin/master
$ git bz apply 18897
-- interactive apply just the first patch
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
...
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the wrong library is missing.
$ git bz apply 18897
-- interactive apply this patch
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the correct library is missing.
run the koha qa test tools

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

--- Comment #2 from M. Tompsett  ---
Created attachment 66478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66478=edit
Bug 18897: Koha_Elasticsearch_Indexer.t doesn't skip when ES module(s) not
installed

If Catmandu::Importer::MARC is not installed,
Koha_Elasticsearch_Indexer.t fails instead of skipping.
It should skip as ES is not currently mandatory.

Test Plan:
1. Run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t"
   as koha-shell
2. Note failure on test 1/5 indicating module not installed.
3. Apply patch.
4. Re-run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t"
5. Note test now skips.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Lee Jamison  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18899

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

--- Comment #1 from Lee Jamison  ---
Created attachment 64818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64818=edit
Bug 18897 - Koha_Elasticsearch_Indexer.t doesn't skip when ES module not
installed

If Catmandu::Importer::MARC is not installed,
Koha_Elasticsearch_Indexer.t fails instead of skipping.

Test Plan:
1. Run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t"
   as koha-shell.
2. Note failure on test 1/5 indicating module not installed.
3. Apply patch.
4. Re-run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t"
5. Note test now skips.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Lee Jamison  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Lee Jamison  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|ldjami...@marywood.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/