[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Niamh changed: What|Removed |Added CC||niamh.walker-headon@it-tall ||aght.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #9 from Katrin Fischer --- I am not sure all libraries can generally agree to send the notice on date due, because then the user has no way to return the item on time usually. I think there are separate issues thinking about the notice: - Don't send a notice every day the item is not returned, sent a notice once or at least not too often - Be able to inform the patrons on time before the due date so they are able to return the item on time - Don't inform the user weeks ahead Could it help to set the "No renewal before" to a lower number of days? This would prevent auto renewals from happening and together with "No automatic renewal after" could limit the timeframe for sending the notice to a few days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #8 from Jonathan Druart --- (In reply to Nick Clemens from comment #7) > We have several libraries with different opinions on this: > Some want the emails to be sent the day the item becomes non-renewable > Some want the notices sent on the day the item would be renewed > > This patch seems to send the notice on the due date of the item > > Could this be done as a switch in the cronjob? (or a syspref?) I think what you describe can be considered as a new enh, whereas this patch fixes a much bigger issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- We have several libraries with different opinions on this: Some want the emails to be sent the day the item becomes non-renewable Some want the notices sent on the day the item would be renewed This patch seems to send the notice on the due date of the item Could this be done as a switch in the cronjob? (or a syspref?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20360 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Jonathan Druart --- (In reply to Caroline Cyr La Rose from comment #5) > Hi Jonathan, > > I'm having trouble testing this. Which cron job are we supposed to run? Is > it automatic_renewals.pl --send-notices? Yes > Furthermore, I had an item due in the future (in december) and I still > received a notice saying the auto renewal failed because I had fines (which > was true). But why would it try to renew something due in december? You need to tune that using the 'No automatic renewal before/after' settings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs Signoff |Failed QA --- Comment #5 from Caroline Cyr La Rose --- Hi Jonathan, I'm having trouble testing this. Which cron job are we supposed to run? Is it automatic_renewals.pl --send-notices? Furthermore, I had an item due in the future (in december) and I still received a notice saying the auto renewal failed because I had fines (which was true). But why would it try to renew something due in december? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- It seems a bit harsh to send the notice the day the item is due, as this means the patron will only have 'that day' to return the book safely. But as the automatic renewal will be tried daily depending on 'No renewal before' and (I tihnk) 'No automatic renewal after' I am not sure how to avoid spamming the patrons with lots of emails. I guess ideally one email would be sent the first time the renewal fails? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Field changed: What|Removed |Added CC||jonathan.field@ptfs-europe. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What|Removed |Added Depends on||15705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 [Bug 15705] Notify the user on auto renewing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #3 from Ray Delahunty --- Yes, I think that is a perfect plan. My suggestion about the edit to the template toolkit was just a suggestion. We have a workaround in place in 16.05 (which has the same problem) and will have to retain it when we upgrade to 17.05 in a week or so. We have repurposed ODUE to be the renewal failed advisory, and use RENEWAL as the renewal success advisory, and have turned off the AUTO_RENEWAL notice. That works OK, but we do hope to see the functionality working as you describe so we can restart using AUTO_RENEWAL. We are also funding the change of that email into a digest one, to further improve the auto-renewal functionality. Ray Delahunty University of the Arts London -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19053 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What|Removed |Added Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Version|17.05 |master --- Comment #2 from Jonathan Druart --- Hi Ray, What you describe sounds like a bug. Could you take a look at this patch and tell me if it could meet your needs? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #1 from Jonathan Druart --- Created attachment 65590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65590&action=edit Bug 19014: Do not sent on_reserve notification if the checkout is due in the future If holds exist on an item that have been checked out and marked as auto renewal, we do not want to notify patrons with a on_reserve notification if the checkout is due in the future. These on_reserve notifications must only be sent if the checkout is due today or in the past. Test plan: - Check an item in and mark it as auto renewal, use a due date in the past to ease the testing - Place a hold in this item - Execute the cronjob => Without this patch, the patron will get notified even if the checkout is due in the future => With this patch applied the patron will only get notified the day the checkout is due or if the due date is passed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What|Removed |Added Summary|Limit auto-renewal notice |Patrons should not get a |to item due immediately.|on_reserve notification if |Template Toolkit change?|the checkout is due in the ||future CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/