[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
Dilan, please do not edit the commit message. You removed the test plan from
the first patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Nick Clemens  changed:

   What|Removed |Added

  Attachment #66133|0   |1
is obsolete||
  Attachment #68476|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 68488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68488=edit
Bug 19038: Remove the OPACShowBarcode syspref

Followed test plan and works as expected. Functionality of patch from bug 16759
appears intact too.

Signed-off-by: Dilan Johnpullé 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

--- Comment #7 from Nick Clemens  ---
Created attachment 68489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68489=edit
Bug 19038: QA Followup - Hide barcode column by default (as syspref default is
hide)

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

--- Comment #5 from Tomás Cohen Arazi  ---
(In reply to Nick Clemens from comment #4)
> I think this one is good, however, what I see is that the upgrade is odd.
> 
> If you have set columns configuration already, this won't set it regardless
> of syspref so if pref is set to "Don't show" and columns setting is set to
> show barcode then after this patch the column will show(it was hidden before)
> 
> I don't know if this matters if both bugs are pushed to same version, can
> you answer Tomas?

This is a followup bug for 16759 and is intended to be pushed along with it.
There shouldn't actually exist column settings when the upgrade is done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |In Discussion

--- Comment #4 from Nick Clemens  ---
I think this one is good, however, what I see is that the upgrade is odd.

If you have set columns configuration already, this won't set it regardless of
syspref so if pref is set to "Don't show" and columns setting is set to show
barcode then after this patch the column will show(it was hidden before)

I don't know if this matters if both bugs are pushed to same version, can you
answer Tomas?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

--- Comment #3 from Nick Clemens  ---
Created attachment 68476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68476=edit
Bug 19038: QA Followup - Hide barcode column by default (as syspref default is
hide)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #65518|0   |1
is obsolete||

--- Comment #2 from Dilan Johnpullé  ---
Created attachment 66133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66133=edit
Bug 19038: Remove the OPACShowBarcode syspref

Followed test plan and works as expected. Functionality of patch from bug 16759
appears intact too.

Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 65518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65518=edit
Bug 19038: Remove the OPACShowBarcode syspref

This patch removes the OPACShowBarcode syspref in favour of the new
columns settings option introduced by bug 16759.

On the upgrade step, it picks the value for OPACShowBarcode and uses it
to populate the columns_settings table.

To test:
- Verify the upgrade process maintains the current behaviour

Regards

Sponsored-by: Dover

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||16759
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
  Change sponsored?|--- |Sponsored


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759
[Bug 16759] Make opac holdings table configurable
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/