[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Lisette Scheer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18623

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #66 from Katrin Fischer  ---
*** Bug 13842 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||Let your library go
  release notes||paperless. This enhancement
   ||enables the ability to send
   ||payment and write-off
   ||receipts by email.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

--- Comment #65 from Katrin Fischer  ---
This might be a nice candidate for 'new'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

  Component|Circulation |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21396

--- Comment #64 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #59)
> It's usually a bad idea to require instead of use, to catch errors at
> compilation time.

See bug 21396.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396
[Bug 21396] Missing use statements in Koha::Account
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #63 from Martin Renvoize  ---
Enhancement, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #62 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #61 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #59)
> (In reply to Kyle M Hall from comment #58)
> > (In reply to Jonathan Druart from comment #56)
> > > 1. There is 'Account Writeoff' vs 'Account writeoff'
> > > 
> > > 2. In Koha::Account->pay, why require C4::Letters; instead of use?
> > > 
> > > 3. Koha/Account.pm:273
> > >   lang=> Koha::Patrons->find( $self->{patron_id} )->lang,
> > > No need to refetch the patron object, you did it already at the beginning 
> > > of
> > > the method.
> > > 
> > > 4. Koha/Account.pm:280
> > >   offsets => scalar Koha::Account::Offsets->search( { id => { -in => [ 
> > > map {
> > > $_->id } @account_offsets ] } } ),
> > > 
> > > I do not understand this line, we are refetching what we already have?
> > 
> > Follow addresses everything but 2. I used require instead of use because use
> > is hoisted and it would import it even if the feature is not being used.
> > Basically it's a small efficiency improvement.
> 
> It's usually a bad idea to require instead of use, to catch errors at
> compilation time.
> It's too late for 18.05 so I will let next RM decides.
> 
> Moreover the title of the last patch is not formatted correctly.

We already load C4::Letters in plack.psgi anyway. I agree with Jonathan it is
better to use the lib, to catch problems in compilation time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #75093|0   |1
is obsolete||

--- Comment #60 from Kyle M Hall  ---
Created attachment 75134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75134=edit
Bug 19191 [QA Followup]: Remove double fetches from database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #59 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #58)
> (In reply to Jonathan Druart from comment #56)
> > 1. There is 'Account Writeoff' vs 'Account writeoff'
> > 
> > 2. In Koha::Account->pay, why require C4::Letters; instead of use?
> > 
> > 3. Koha/Account.pm:273
> >   lang=> Koha::Patrons->find( $self->{patron_id} )->lang,
> > No need to refetch the patron object, you did it already at the beginning of
> > the method.
> > 
> > 4. Koha/Account.pm:280
> >   offsets => scalar Koha::Account::Offsets->search( { id => { -in => [ map {
> > $_->id } @account_offsets ] } } ),
> > 
> > I do not understand this line, we are refetching what we already have?
> 
> Follow addresses everything but 2. I used require instead of use because use
> is hoisted and it would import it even if the feature is not being used.
> Basically it's a small efficiency improvement.

It's usually a bad idea to require instead of use, to catch errors at
compilation time.
It's too late for 18.05 so I will let next RM decides.

Moreover the title of the last patch is not formatted correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #58 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #56)
> 1. There is 'Account Writeoff' vs 'Account writeoff'
> 
> 2. In Koha::Account->pay, why require C4::Letters; instead of use?
> 
> 3. Koha/Account.pm:273
>   lang=> Koha::Patrons->find( $self->{patron_id} )->lang,
> No need to refetch the patron object, you did it already at the beginning of
> the method.
> 
> 4. Koha/Account.pm:280
>   offsets => scalar Koha::Account::Offsets->search( { id => { -in => [ map {
> $_->id } @account_offsets ] } } ),
> 
> I do not understand this line, we are refetching what we already have?

Follow addresses everything but 2. I used require instead of use because use is
hoisted and it would import it even if the feature is not being used. Basically
it's a small efficiency improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #57 from Kyle M Hall  ---
Created attachment 75093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75093=edit
Bug 19191 [QA Followup] - Remove double fetches from database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #56 from Jonathan Druart  
---
1. There is 'Account Writeoff' vs 'Account writeoff'

2. In Koha::Account->pay, why require C4::Letters; instead of use?

3. Koha/Account.pm:273
  lang=> Koha::Patrons->find( $self->{patron_id} )->lang,
No need to refetch the patron object, you did it already at the beginning of
the method.

4. Koha/Account.pm:280
  offsets => scalar Koha::Account::Offsets->search( { id => { -in => [ map {
$_->id } @account_offsets ] } } ),

I do not understand this line, we are refetching what we already have?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #55 from Kyle M Hall  ---
Created attachment 75072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75072=edit
Bug 19191: Add syspref to control use of email receipts, defaulting to disabled

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #53 from Kyle M Hall  ---
Created attachment 75070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75070=edit
Bug 19191: Fix capitalization of notice titles

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #54 from Kyle M Hall  ---
Created attachment 75071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75071=edit
Bug 19191: Add non-english notices

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #52 from Kyle M Hall  ---
Created attachment 75069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75069=edit
Bug 19191: Add correct unit tests

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #51 from Kyle M Hall  ---
Created attachment 75068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75068=edit
Bug 19191: Remove need for bug 19966

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #75066|0   |1
is obsolete||

--- Comment #50 from Kyle M Hall  ---
Created attachment 75067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75067=edit
Bug 19191: Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74626|0   |1
is obsolete||
  Attachment #74627|0   |1
is obsolete||
  Attachment #74628|0   |1
is obsolete||
  Attachment #74629|0   |1
is obsolete||
  Attachment #74630|0   |1
is obsolete||
  Attachment #74686|0   |1
is obsolete||

--- Comment #49 from Kyle M Hall  ---
Created attachment 75066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75066=edit
Bug 19191: Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #48 from Jonathan Druart  
---
Please rebase
CONFLICT (content): Merge conflict in t/db_dependent/Accounts.t
CONFLICT (content): Merge conflict in Koha/Account/Offset.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74631|0   |1
is obsolete||

--- Comment #47 from Katrin Fischer  ---
Created attachment 74686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74686=edit
Bug 19191: Add syspref to control use of email receipts, defaulting to disabled

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15273

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74625|0   |1
is obsolete||

--- Comment #41 from Kyle M Hall  ---
Created attachment 74626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74626=edit
Bug 19191: Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #45 from Kyle M Hall  ---
Created attachment 74630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74630=edit
Bug 19191: Add non-english notices

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #42 from Kyle M Hall  ---
Created attachment 74627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74627=edit
Bug 19191: Remove need for bug 19966

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #46 from Kyle M Hall  ---
Created attachment 74631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74631=edit
Bug 19191: Add syspref to control use of email receipts, defaulting to disabled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #43 from Kyle M Hall  ---
Created attachment 74628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74628=edit
Bug 19191: Add correct unit tests

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #44 from Kyle M Hall  ---
Created attachment 74629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74629=edit
Bug 19191: Fix capitalization of notice titles

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74504|0   |1
is obsolete||
  Attachment #74505|0   |1
is obsolete||
  Attachment #74506|0   |1
is obsolete||
  Attachment #74507|0   |1
is obsolete||
  Attachment #74508|0   |1
is obsolete||

--- Comment #40 from Kyle M Hall  ---
Created attachment 74625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74625=edit
Bug 19191: Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #39 from Katrin Fischer  ---
Puh, ok, I found a problem: When we push this as is, we will immediately start
sending out payment and writeoff notices after update. Libraries might not
expect that to happen and it smells trouble, especially since you'd want to
translate/adapt the notice. I think the easisest solution would be to not add
them with a database update.

We could put the sample notices on a wiki page instead, so people can easily
add them. Or into the manual.

Or: We could add a system preference to determine when to send them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74424|0   |1
is obsolete||

--- Comment #38 from Katrin Fischer  ---
Created attachment 74508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74508=edit
Bug 19191: Add non-english notices

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74423|0   |1
is obsolete||

--- Comment #37 from Katrin Fischer  ---
Created attachment 74507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74507=edit
Bug 19191: Fix capitalization of notice titles

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74095|0   |1
is obsolete||

--- Comment #35 from Katrin Fischer  ---
Created attachment 74505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74505=edit
Bug 19191: Remove need for bug 19966

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74105|0   |1
is obsolete||

--- Comment #36 from Katrin Fischer  ---
Created attachment 74506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74506=edit
Bug 19191: Add correct unit tests

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74094|0   |1
is obsolete||

--- Comment #34 from Katrin Fischer  ---
Created attachment 74504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74504=edit
Bug 19191: Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #33 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #32)
> Hi Kyle, didn't sign them yet, will check the follow-up tonight!

My bad! Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off

--- Comment #32 from Katrin Fischer  ---
Hi Kyle, didn't sign them yet, will check the follow-up tonight!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #31 from Kyle M Hall  ---
Created attachment 74424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74424=edit
Bug 19191: Add non-english notices

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #30 from Kyle M Hall  ---
Created attachment 74423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74423=edit
Bug 19191: Fix capitalization of notice titles

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #29 from Katrin Fischer  ---
Hi Kyle, 

it works now!

Can you please fix the remaining issues in a follow-up?

- Fix capitalization on notice templates: Account Writeoff, Account Payment
- Add notices to other installers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74104|0   |1
is obsolete||

--- Comment #28 from Kyle M Hall  ---
Created attachment 74105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74105=edit
Bug 19191: Add correct unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #27 from Kyle M Hall  ---
Created attachment 74104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74104=edit
Bug 19191: Add correct unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74093|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall  ---
Created attachment 74094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74094=edit
Bug 19191: Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #26 from Kyle M Hall  ---
Created attachment 74095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74095=edit
Bug 19191: Remove need for bug 19966

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74092|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall  ---
Created attachment 74093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74093=edit
Bug 19191: Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72370|0   |1
is obsolete||
  Attachment #73924|0   |1
is obsolete||

--- Comment #23 from Kyle M Hall  ---
Created attachment 74092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74092=edit
Bug 19191: Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #22 from Katrin Fischer  ---
Ok, big problem:
- notice templates are there
- homebranch library has an email
- patron has an email
But no notice is generated on paying/writing off.

> To fix after initial testing is finished:
> - Fix capitalization on notice templates: Account Writeoff, Account Payment
> - Add database update
> - Add notices to other installers

Maybe related:

ERROR: nothing to substitute - both 'tables', 'loops' and 'substitute' are
empty at /home/vagrant/kohaclone/Koha/Account.pm line 265.
Use of uninitialized value in string eq at
/home/vagrant/kohaclone/members/paycollect.pl line 194.
Use of uninitialized value in string eq at
/home/vagrant/kohaclone/members/pay.pl line 224.

Please fix all notes in one patch (installers now too, notices are ok afaikt if
they work ;) )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72370|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #21 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #19)
> Question:
> - How can you control the sending of the emails? (delete the notices?)

Yes, removing the notice disables the feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #20 from Katrin Fischer  ---
Continuing here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #19 from Katrin Fischer  ---
Question:
- How can you control the sending of the emails? (delete the notices?)

To fix after initial testing is finished:
- Fix capitalization on notice templates: Account Writeoff, Account Payment
- Add database update
- Add notices to other installers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #18 from Katrin Fischer  ---
Continuing here, sample notices can be fixed once the base patch passes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72366|0   |1
is obsolete||
  Attachment #72370|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall  ---
Created attachment 73924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73924=edit
Bug 19191: Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #16 from Katrin Fischer  ---
We'll also need a follow up to include the new sample notices in the the
translated web installers and in a database update!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #15 from Katrin Fischer  ---
Needs a real quick rebase!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Depends on|19966   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966
[Bug 19966] Add ability to pass objects directly to slips and notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72367|0   |1
is obsolete||

--- Comment #14 from Kyle M Hall  ---
Created attachment 72370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72370=edit
Bug 19191: Remove need for bug 19966

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #13 from Kyle M Hall  ---
Created attachment 72367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72367=edit
Bug 19191: Remove need for bug 19966

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #70471|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall  ---
Created attachment 72366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72366=edit
Bug 19191: Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |BLOCKED

--- Comment #11 from Katrin Fischer  ---
BLOCKED by bug 19966 still needing a sign-off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||19966


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966
[Bug 19966] Add ability to pass objects directly to slips and notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #68812|0   |1
is obsolete||
  Attachment #70466|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 70471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70471=edit
Bug 19191 - Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #70465|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 70466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70466=edit
Bug 19191 [QA Followup] - Remove db update so feature is disabled by default
for existing installations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #8 from Kyle M Hall  ---
Created attachment 70465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70465=edit
Bug 19191 [QA Followup] - Remove db update so feature is disabled by default
for existing installations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Josef Moravec  changed:

   What|Removed |Added

  Attachment #68605|0   |1
is obsolete||

--- Comment #7 from Josef Moravec  ---
Created attachment 68812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68812=edit
Bug 19191 - Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Run updatedatabase.pl
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Josef Moravec  changed:

   What|Removed |Added

 Blocks||19545


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19545
[Bug 19545] Make possible to turn off (and on) sending payment receipts by
email
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #6 from Kyle M Hall  ---
(In reply to Josef Moravec from comment #4)
> Kyle, thanks for this nice feature, just couple of thoughts:
> 
> > 2) Run updatedatabase.pl
>
> You probably forget to add atomic update file - there is just
> sample_notices.sql addition

Good catch!

> Will it be possible to NOT to send e-mail about payment? Let's say
> configurable for patrons or patron categories? Somehow similire to current
> "Enhanced Messaging" feature?

That would be an excellent followup feature, but is outside the scope of this
particular work. I'd love to see it! For now the feature can be turned on and
off for each notice by simply having the notice exist or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #66554|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 68605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68605=edit
Bug 19191 - Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Run updatedatabase.pl
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #4 from Josef Moravec  ---
Kyle, thanks for this nice feature, just couple of thoughts:

> 2) Run updatedatabase.pl

You probably forget to add atomic update file - there is just
sample_notices.sql addition


Will it be possible to NOT to send e-mail about payment? Let's say configurable
for patrons or patron categories? Somehow similire to current "Enhanced
Messaging" feature?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Simon Pouchol  changed:

   What|Removed |Added

 CC||simon.pouc...@biblibre.com

--- Comment #3 from Simon Pouchol  ---
Hey,
I tried to test this patch, and couldn't apply it (Dependency patch 14826
applied just fine):

Applying: Bug 19191 - Add ability to email receipts for account payments and
write-offs
Using index info to reconstruct a base tree...
M   C4/Letters.pm
M   Koha/Account/Offset.pm
M   t/db_dependent/Letters/TemplateToolkit.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Letters/TemplateToolkit.t
Auto-merging Koha/Account/Offset.pm
CONFLICT (content): Merge conflict in Koha/Account/Offset.pm
Auto-merging C4/Letters.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 19191 - Add ability to email receipts for account
payments and write-offs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Amit Gupta  changed:

   What|Removed |Added

 CC||amit.gupta@informaticsgloba
   ||l.com,
   ||amitddng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #2 from Kyle M Hall  ---
This patch also introduces a new method of passing objects directly through to
the notice template without processing. This is incredibly efficient for
notices that only support Template Toolkit syntax, as it does not require
refetching the data from the database multiple times as the existing parameters
may.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||14826


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Resurrect account offsets table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #1 from Kyle M Hall  ---
Created attachment 66554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66554=edit
Bug 19191 - Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Run updatedatabase.pl
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

Summary|Add ability to send |Add ability to email
   |receipts for account|receipts for account
   |payments and write-offs |payments and write-offs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/