[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #16 from Katrin Fischer --- Doesn't apply cleanly to 16.11.x - please provide rebased patches if you want this to be included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Fridolin SOMERSchanged: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Master|Pushed to Stable --- Comment #15 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. Reducing log files saves trees ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #13 from Jonathan Druart--- Created attachment 66961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66961=edit Bug 19258: Prevent warn when reversing a payment The following warn is triggered when I click the Reverse button next to an individual payment on the Account tab: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_boraccount_2epl line 63, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side, create a manual invoice, pay it 2) Go to the Account tab, click Reverse next to the payment you just made 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #12 from Jonathan Druart--- Created attachment 66960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66960=edit Bug 19258: Preventing warns when paying a fine or charge from Pay selected button The following warns are triggered when I click the Pay selected button: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 267, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 273, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, select the fine you just created and click Pay selected 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #11 from Jonathan Druart--- Created attachment 66959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66959=edit Bug 19258: Prevent warns when writing off an individual fine The following warns are triggered when I click the Write Off button next to an individual fine or charge: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 171, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. (this shows many times) Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, click the Write off button next to the invoice you just created 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Jonathan Druartchanged: What|Removed |Added Attachment #66864|0 |1 is obsolete|| Attachment #66865|0 |1 is obsolete|| Attachment #66866|0 |1 is obsolete|| Attachment #66867|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 66958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66958=edit Bug 19258: Prevent warn when paying a fine or charge To test: 1) Go to a members detail page in staff client 2) Select the Fines tab in the left pane 3) Select the Create manual invoice tab below the button menu bar 4) Create a fine and click save (e.g. Type: Fine, Amount: 5.00) 5) Select the Pay fines tab below the button menu bar 6) Click Pay on the item 7) Blank the staff error log 8) click confirm -- staff error log has message 9) apply this first patch 10) repeat steps 3-8 -- staff error log is blank 11) run koha qa test tools Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 M. Tompsettchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 M. Tompsettchanged: What|Removed |Added CC||mtomp...@hotmail.com Attachment #66859|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 M. Tompsettchanged: What|Removed |Added Attachment #66860|0 |1 is obsolete|| --- Comment #7 from M. Tompsett --- Created attachment 66865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66865=edit Bug 19258: Prevent warns when writing off an individual fine The following warns are triggered when I click the Write Off button next to an individual fine or charge: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 171, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. (this shows many times) Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, click the Write off button next to the invoice you just created 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 M. Tompsettchanged: What|Removed |Added Attachment #66861|0 |1 is obsolete|| --- Comment #8 from M. Tompsett --- Created attachment 66866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66866=edit Bug 19258: Preventing warns when paying a fine or charge from Pay selected button The following warns are triggered when I click the Pay selected button: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 267, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 273, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, select the fine you just created and click Pay selected 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 M. Tompsettchanged: What|Removed |Added Attachment #66862|0 |1 is obsolete|| --- Comment #9 from M. Tompsett --- Created attachment 66867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66867=edit Bug 19258: Prevent warn when reversing a payment The following warn is triggered when I click the Reverse button next to an individual payment on the Account tab: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_boraccount_2epl line 63, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side, create a manual invoice, pay it 2) Go to the Account tab, click Reverse next to the payment you just made 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #6 from M. Tompsett--- Created attachment 66864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66864=edit Bug 19258: Prevent warn when paying a fine or charge To test: 1) Go to a members detail page in staff client 2) Select the Fines tab in the left pane 3) Select the Create manual invoice tab below the button menu bar 4) Create a fine and click save (e.g. Type: Fine, Amount: 5.00) 5) Select the Pay fines tab below the button menu bar 6) Click Pay on the item 7) Blank the staff error log 8) click confirm -- staff error log has message 9) apply this first patch 10) repeat steps 3-8 -- staff error log is blank 11) run koha qa test tools Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #5 from Aleisha Amohia--- This is ready for testing and tests 4 different areas in the fines section of the member's page. Test each patch one after the other following each test plan. Will be quick testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #4 from Aleisha Amohia--- Created attachment 66862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66862=edit Bug 19258: Prevent warn when reversing a payment The following warn is triggered when I click the Reverse button next to an individual payment on the Account tab: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_boraccount_2epl line 63, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side, create a manual invoice, pay it 2) Go to the Account tab, click Reverse next to the payment you just made 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #3 from Aleisha Amohia--- Created attachment 66861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66861=edit Bug 19258: Preventing warns when paying a fine or charge from Pay selected button The following warns are triggered when I click the Pay selected button: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 267, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 273, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, select the fine you just created and click Pay selected 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #2 from Aleisha Amohia--- Created attachment 66860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66860=edit Bug 19258: Prevent warns when writing off an individual fine The following warns are triggered when I click the Write Off button next to an individual fine or charge: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 171, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. (this shows many times) Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, click the Write off button next to the invoice you just created 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Aleisha Amohiachanged: What|Removed |Added Attachment #66859|Bug 19258: Prevent warn |Bug 19258: Prevent warn description|when paying a fine or |when paying a fine or |charge |charge from Pay Amount ||button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Aleisha Amohiachanged: What|Removed |Added Summary|Warn when paying a fine or |Warn when paying or writing |charge from 'Pay amount'|off a fine or charge |button | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/