[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||26203


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26203
[Bug 26203] Message enqueued with no to_address when using
CanMarkHoldsToPullAsLost for patron without an email address
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||26183


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26183
[Bug 26183] UpdateItemWhenLostFromHoldList should be limited in scope
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Nick Clemens  changed:

   What|Removed |Added

 Blocks||22476


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476
[Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #75 from Nick Clemens  ---
update systempreferences set
options="batchmod|moredetail|cronjob|additem|pendingreserves",
value="batchmod|moredetail|cronjob|additem|pendingreserves" where
variable="MarkLostItemsAsReturned";

This update is wrong - we should not be setting the options for all installs,
and they should be comma separated

Filed bug 21869

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Nick Clemens  changed:

   What|Removed |Added

 Blocks||21869


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869
[Bug 21869] Bad update statement loses values for MarkLostItemsAsReturned
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Hugh Rundle  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20844

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #74 from Jonathan Druart  
---
Last patch pushed to master for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #73 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #72)
> Created attachment 75535 [details] [review]
> Bug 19287: (follow-up) Use the notice defined for the library of the patron

Fix the bug caught by Séverine on bug 20767 comment 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #72 from Jonathan Druart  
---
Created attachment 75535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75535=edit
Bug 19287: (follow-up) Use the notice defined for the library of the patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Niamh  changed:

   What|Removed |Added

 CC||niamh.walker-headon@it-tall
   ||aght.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #71 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #74700|0   |1
is obsolete||

--- Comment #70 from Jonathan Druart  
---
Created attachment 74749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74749=edit
Bug 19287: Add CANCEL_HOLD_ON_LOST to installer files for all languages

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #69 from Katrin Fischer  ---
I's probalby not even show the hint about the biblio leve hold, but that's just
a matter of taste :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #68 from Katrin Fischer  ---
Created attachment 74705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74705=edit
Bug 19287: (QA follow-up) Fix preference description

The last part of the preference description didn't show.
Moved behind the other text and rephrased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73887|0   |1
is obsolete||

--- Comment #65 from Katrin Fischer  ---
Created attachment 74702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74702=edit
Bug 19287: Update UpdateItemWhenLostFromHoldList description

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73885|0   |1
is obsolete||

--- Comment #63 from Katrin Fischer  ---
Created attachment 74700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74700=edit
Bug 19287: Add CANCEL_HOLD_ON_LOST to installer files for all languages

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73886|0   |1
is obsolete||

--- Comment #64 from Katrin Fischer  ---
Created attachment 74701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74701=edit
Bug 19287: Add column action to columns settings

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73889|0   |1
is obsolete||

--- Comment #67 from Katrin Fischer  ---
Created attachment 74704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74704=edit
Bug 19287: Shorten button text

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73888|0   |1
is obsolete||

--- Comment #66 from Katrin Fischer  ---
Created attachment 74703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74703=edit
Bug 19287: Do not display buttons for biblio level holds

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73881|0   |1
is obsolete||

--- Comment #59 from Katrin Fischer  ---
Created attachment 74696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74696=edit
Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list

The goal to this enhancement is to add the ability to cancel a hold and
mark items as lost from the 'Holds to pull' page.
A new pref is added to control the behaviour, default is off

To mark items as lost you need to set the new pref CanMarkHoldsToPullAsLost to
one of these two values:
- "Allow to mark items as lost"
=> The item will be marked as lost and the hold will be cancelled
- "Allow to mark items as lost and notify the patron"
=> Same as previously but the patron will be notified as well.

The notification is done using a new notice template
(code=CANCEL_HOLD_ON_LOST).
Feel free to suggest another default wording.

To update the values of the items when one of these 2 buttons are used, you
need to
fill the UpdateItemWhenLostFromHoldList with something like: 'itemlost: 1'

Test plan:
1/ Place holds on some items
2/ Go to Home > Circulation > Holds to pull
From here you can cancel the hold or
3/ Mark the items as lost
=> You will receive feedback messages depending on different situations:
* The CANCEL_HOLD_ON_LOST does not exist
* The patron does not have an email address (but the notice has been
enqueued! It is the current behaviour with other notices)
* The notice has been enqueued
* The hold has been cancelled

QA Notes:
From which library do we want to pick the notice? This patch use
reserves.branchcode

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73884|0   |1
is obsolete||

--- Comment #62 from Katrin Fischer  ---
Created attachment 74699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74699=edit
Bug 19287: Use the notice defined for the homebranch of the patron

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73883|0   |1
is obsolete||

--- Comment #61 from Katrin Fischer  ---
Created attachment 74698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74698=edit
Bug 19287: Fix conflict with bug 19974

Note that these patches should be pushed along with bug 19984 to avoid
regressions (if the syspref is changed between the 2 update DB entries)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73882|0   |1
is obsolete||

--- Comment #60 from Katrin Fischer  ---
Created attachment 74697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74697=edit
Bug 19287: Fix conflict with bug 19304

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #58 from Katrin Fischer  ---
Blocked by dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||19974
 Status|Patch doesn't apply |Signed Off

--- Comment #57 from Jonathan Druart  
---
Dependency was missing


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974
[Bug 19974] Marking an item as 'lost' will not actually modify the current item
(cataloguing/additem.pl)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #56 from Katrin Fischer  ---
The third patch won't apply, can you please take a look?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull'
list
Applying: Bug 19287: Fix conflict with bug 19304
Applying: Bug 19287: Fix conflict with bug 19974
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref).
error: could not build fake ancestor
Patch failed at 0001 Bug 19287: Fix conflict with bug 19974
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-19287-Fix-conflict-with-bug-19974-Ayu3UB.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #55 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #45)
> Comment on attachment 70918 [details] [review]
> Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list
> 
> Review of attachment 70918 [details] [review]:

Thanks Katrin!
All your remarks have been taken into account in different patch to ease next
reviews.
They can be squashed if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #54 from Jonathan Druart  
---
Created attachment 73889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73889=edit
Bug 19287: Shorten button text

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #53 from Jonathan Druart  
---
Created attachment 73888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73888=edit
Bug 19287: Do not display buttons for biblio level holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #52 from Jonathan Druart  
---
Created attachment 73887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73887=edit
Bug 19287: Update UpdateItemWhenLostFromHoldList description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #50 from Jonathan Druart  
---
Created attachment 73885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73885=edit
Bug 19287: Add CANCEL_HOLD_ON_LOST to installer files for all languages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #48 from Jonathan Druart  
---
Created attachment 73883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73883=edit
Bug 19287: Fix conflict with bug 19974

Note that these patches should be pushed along with bug 19984 to avoid
regressions (if the syspref is changed between the 2 update DB entries)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #51 from Jonathan Druart  
---
Created attachment 73886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73886=edit
Bug 19287: Add column action to columns settings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #49 from Jonathan Druart  
---
Created attachment 73884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73884=edit
Bug 19287: Use the notice defined for the homebranch of the patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #47 from Jonathan Druart  
---
Created attachment 73882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73882=edit
Bug 19287: Fix conflict with bug 19304

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #70918|0   |1
is obsolete||
  Attachment #70919|0   |1
is obsolete||

--- Comment #46 from Jonathan Druart  
---
Created attachment 73881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73881=edit
Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list

The goal to this enhancement is to add the ability to cancel a hold and
mark items as lost from the 'Holds to pull' page.
A new pref is added to control the behaviour, default is off

To mark items as lost you need to set the new pref CanMarkHoldsToPullAsLost to
one of these two values:
- "Allow to mark items as lost"
=> The item will be marked as lost and the hold will be cancelled
- "Allow to mark items as lost and notify the patron"
=> Same as previously but the patron will be notified as well.

The notification is done using a new notice template
(code=CANCEL_HOLD_ON_LOST).
Feel free to suggest another default wording.

To update the values of the items when one of these 2 buttons are used, you
need to
fill the UpdateItemWhenLostFromHoldList with something like: 'itemlost: 1'

Test plan:
1/ Place holds on some items
2/ Go to Home > Circulation > Holds to pull
From here you can cancel the hold or
3/ Mark the items as lost
=> You will receive feedback messages depending on different situations:
* The CANCEL_HOLD_ON_LOST does not exist
* The patron does not have an email address (but the notice has been
enqueued! It is the current behaviour with other notices)
* The notice has been enqueued
* The hold has been cancelled

QA Notes:
From which library do we want to pick the notice? This patch use
reserves.branchcode

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19974
 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #45 from Katrin Fischer  ---
Comment on attachment 70918
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70918
Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list

Review of attachment 70918:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19287=70918)
-

Hi Jonathan, 

I'll add a see also to bug 19974 - might need a follow-up depending on it.

>QA Notes:
>From which library do we want to pick the notice? This patch use
>reserves.branchcode
_send_message_by_email will be using the homebranch of the library for getting
the right return-path and reply-to addresses for the email. I think instead of
the pick-up library i'd use the homebranch of the patron to make it all match.

1) Please add the new notice to the different installers for new installations.
2) New action column is not in column visibility settings. I think for print it
might make sense that someone wants to hide it from display.

::: installer/data/mysql/atomicupdate/bug_19287.sql
@@ +1,3 @@
> +INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, 
> `explanation`, `type` ) VALUES 
> ('CanMarkHoldsToPullAsLost','do_not_allow','do_not_allow|allow|allow_and_notify','Add
>  a button to the "Holds to pull" screen to mark an item as lost and notify 
> the patron.','Choice');
> +
> +INSERT IGNORE INTO letter(module, code, branchcode, name, is_html, title, 
> content, message_transport_type, lang) VALUES ('reserves', 
> 'CANCEL_HOLD_ON_LOST', '', 'Hold has been cancelled', 0, "Hold has been 
> cancelled", "Dear [% borrower.firstname %] [% borrower.surname %],\n\nWe 
> regret to inform you that the following item cannot longer be placed on hold, 
> it has been marked as lost\n\nTitle: [% biblio.title %]\nAuthor: [% 
> biblio.author %]\nCopy: [% item.copynumber %]\nLocation: [% branch.branchname 
> %]", 'email', 'default');

3) I think maybe:
We regret to inform you, that the following item can not be provided due to it
being missing. Your hold was cancelled.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ +712,5 @@
> +-
> +- Update item's values when marked as lost from the hold to pull 
> screen
> +- pref: UpdateItemWhenLostFromHoldList
> +  type: textarea
> +- This is a list of values to update an item when it is marked 
> as lost from the holds to pull screen.

4) I think it would be good to give an example here for the syntax. I am not
sure how to set it and to test it. And I think have all the text above the
input field.

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
@@ +34,5 @@
> +There is no notice template with a code 
> 'CANCEL_HOLD_ON_LOST' defined in your system.
> +[% CASE 'hold_cancelled' %]
> +The hold has been correctly cancelled.
> +[% CASE 'hold_placed_at_biblio_level' %]
> +The hold has been placed at biblio level. It is 
> not possible to mark it as lost.

5) Maybe we should not display the button in this case?
The hold has been placed on biblio level. It is not possible to determine the
item to mark as lost. (the it in the second sentence refers to hold for me, and
you can't mark holds lost)

@@ +125,5 @@
> +
> +
> +[% ELSIF Koha.Preference('CanMarkHoldsToPullAsLost') == 
> 'allow_and_notify' %]
> + value="mark_as_lost_and_notify" />
> +

6) Mark lost and notify patron (shorter for the button)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Roch D'Amour  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Roch D'Amour  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Roch D'Amour  changed:

   What|Removed |Added

 CC||roch.dam...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #43 from sandbo...@biblibre.com  ---
Created attachment 70918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70918=edit
Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list

The goal to this enhancement is to add the ability to cancel a hold and
mark items as lost from the 'Holds to pull' page.
A new pref is added to control the behaviour, default is off

To mark items as lost you need to set the new pref CanMarkHoldsToPullAsLost to
one of these two values:
- "Allow to mark items as lost"
=> The item will be marked as lost and the hold will be cancelled
- "Allow to mark items as lost and notify the patron"
=> Same as previously but the patron will be notified as well.

The notification is done using a new notice template
(code=CANCEL_HOLD_ON_LOST).
Feel free to suggest another default wording.

To update the values of the items when one of these 2 buttons are used, you
need to
fill the UpdateItemWhenLostFromHoldList with something like: 'itemlost: 1'

Test plan:
1/ Place holds on some items
2/ Go to Home > Circulation > Holds to pull
From here you can cancel the hold or
3/ Mark the items as lost
=> You will receive feedback messages depending on different situations:
* The CANCEL_HOLD_ON_LOST does not exist
* The patron does not have an email address (but the notice has been
enqueued! It is the current behaviour with other notices)
* The notice has been enqueued
* The hold has been cancelled

QA Notes:
From which library do we want to pick the notice? This patch use
reserves.branchcode

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #44 from sandbo...@biblibre.com  ---
Created attachment 70919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70919=edit
Bug 19287: Fix conflict with bug 19304

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #42 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #70764|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #70705|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #41 from Séverine Queune  ---
(In reply to Jonathan Druart from comment #40)
> (In reply to Séverine Queune from comment #38)
> > (In reply to Jonathan Druart from comment #37)
> > > (In reply to Séverine Queune from comment #35)
> > - with "Allow and notify" option, I get this sotware error :
> > Undefined subroutine ::Members::GetNoticeEmailAddress called at
> > /home/koha/src/circ/pendingreserves.pl line 95.
> 
> Yes, conflict with bug 19287, should be ok now.

Cancellation still works with the "Allow" only option.

I have this (normal) Software error when I used the "Allow and notify" option :
> The method 0 is not covered by tests!
Email is "pending" on the patron account, but I can't be sure that, in a
functional instance, cancellation is made because I can't refresh the error
page, and when I go back to the "Holds to pull" page or the record, hold is
still on the item.

I will see tomorrow with Nicolas, maybe he could install this patch on our
Koha-Test and we could see if everything works as expected.

Is that ok with you ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #40 from Jonathan Druart  
---
(In reply to Séverine Queune from comment #38)
> (In reply to Jonathan Druart from comment #37)
> > (In reply to Séverine Queune from comment #35)
> - with "Allow and notify" option, I get this sotware error :
> Undefined subroutine ::Members::GetNoticeEmailAddress called at
> /home/koha/src/circ/pendingreserves.pl line 95.

Yes, conflict with bug 19287, should be ok now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #39 from Jonathan Druart  
---
Created attachment 70764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70764=edit
Bug 19287: Fix conflict with bug 19304

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #38 from Séverine Queune  ---
(In reply to Jonathan Druart from comment #37)
> (In reply to Séverine Queune from comment #35)
> > Did I miss a dependency ? The patch doesn’t seem to apply.
> 
> It applied correctly here, could you test again with this rebased version?

New patch applies correctly.

- with "Allow and notify" option, I get this sotware error :
Undefined subroutine ::Members::GetNoticeEmailAddress called at
/home/koha/src/circ/pendingreserves.pl line 95.

- "Mark as lost" works well : hold is cancelled, the fields set in the syspref
are correctly updated (and when I choose itemlost is changed, itemlost_on is
"timestamped" (can I say it ?)).

Cancellation is blocked with this 2 options if hold is placed on biblio.

- with the syspref set to "Do not allow", I only see the usual option "Cancel
hold".



(In reply to Katrin Fischer from comment #31)
> Why the holds awaiting pickup list? That would mean, you got the book for
> the patron, you checked it in, you sent the email notice to the patron and
> THEN you notice it's actually not there... ? Wouldn't it make more sense to
> this from the holds queue or holds to pull pages that you use when looking
> for the item?

That was definetly a good idea to use the "Holds to pull" list, thank you
Katrin !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #37 from Jonathan Druart  
---
(In reply to Séverine Queune from comment #35)
> Did I miss a dependency ? The patch doesn’t seem to apply.

It applied correctly here, could you test again with this rebased version?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #36 from Jonathan Druart  
---
Created attachment 70705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70705=edit
Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list

The goal to this enhancement is to add the ability to cancel a hold and
mark items as lost from the 'Holds to pull' page.
A new pref is added to control the behaviour, default is off

To mark items as lost you need to set the new pref CanMarkHoldsToPullAsLost to
one of these two values:
- "Allow to mark items as lost"
=> The item will be marked as lost and the hold will be cancelled
- "Allow to mark items as lost and notify the patron"
=> Same as previously but the patron will be notified as well.

The notification is done using a new notice template
(code=CANCEL_HOLD_ON_LOST).
Feel free to suggest another default wording.

To update the values of the items when one of these 2 buttons are used, you
need to
fill the UpdateItemWhenLostFromHoldList with something like: 'itemlost: 1'

Test plan:
1/ Place holds on some items
2/ Go to Home > Circulation > Holds to pull
>From here you can cancel the hold or
3/ Mark the items as lost
=> You will receive feedback messages depending on different situations:
* The CANCEL_HOLD_ON_LOST does not exist
* The patron does not have an email address (but the notice has been
enqueued! It is the current behaviour with other notices)
* The notice has been enqueued
* The hold has been cancelled

QA Notes:
>From which library do we want to pick the notice? This patch use
reserves.branchcode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #69746|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #35 from Séverine Queune  ---
Did I miss a dependency ? The patch doesn’t seem to apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

Summary|Add ability to mark an item |Add ability to mark an item
   |'Lost' from 'Holds awaiting |'Lost' from 'Holds to pull'
   |pickup' list|list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/