[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Nick Clemens  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||n...@bywatersolutions.com
 Resolution|--- |FIXED

--- Comment #26 from Nick Clemens  ---
Enhancement, not backported for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #25 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72854|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 73069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73069=edit
Bug 19454: (QA follow-up) Fix selection on categorycode

A follow-up on a preceding report introduced a join instead of a
subquery. This made the categorycode ambiguous.

Test plan:
See former patches.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72852|0   |1
is obsolete||

--- Comment #22 from Katrin Fischer  ---
Created attachment 73067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73067=edit
Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl

Instead of updating patrons over all patron categories, it would be
helpful if we could filter on a specified category.

Test plan:
[1] Select two patrons A and B in say categories C1 and C2.
[2] Change the msg prefs for A and B away from defaults.
[3] Run borrowers-force-messaging-defaults.pl -doit -cat C1
Verify that patron A changed and patron B did not.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

Amended: Replace -category by --category. (marcelr 20180314)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72853|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 73068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73068=edit
Bug 19454: (Follow-up) Add a total line when updating

Test plan:
[1] Run the script with -doit and -cat [some_category] and verify that
the printed total is correct.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #72850|0   |1
is obsolete||

--- Comment #20 from Marcel de Rooy  ---
Created attachment 72853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72853=edit
Bug 19454: (Follow-up) Add a total line when updating

Test plan:
[1] Run the script with -doit and -cat [some_category] and verify that
the printed total is correct.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #72849|0   |1
is obsolete||

--- Comment #19 from Marcel de Rooy  ---
Created attachment 72852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72852=edit
Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl

Instead of updating patrons over all patron categories, it would be
helpful if we could filter on a specified category.

Test plan:
[1] Select two patrons A and B in say categories C1 and C2.
[2] Change the msg prefs for A and B away from defaults.
[3] Run borrowers-force-messaging-defaults.pl -doit -cat C1
Verify that patron A changed and patron B did not.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

Amended: Replace -category by --category. (marcelr 20180314)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #72851|0   |1
is obsolete||

--- Comment #21 from Marcel de Rooy  ---
Created attachment 72854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72854=edit
Bug 19454: (QA follow-up) Fix selection on categorycode

A follow-up on a preceding report introduced a join instead of a
subquery. This made the categorycode ambiguous.

Test plan:
See former patches.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #18 from Marcel de Rooy  ---
Created attachment 72851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72851=edit
Bug 19454: (QA follow-up) Fix selection on categorycode

A follow-up on a preceding report introduced a join instead of a
subquery. This made the categorycode ambiguous.

Test plan:
See former patches.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #71654|0   |1
is obsolete||

--- Comment #16 from Marcel de Rooy  ---
Created attachment 72849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72849=edit
Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl

Instead of updating patrons over all patron categories, it would be
helpful if we could filter on a specified category.

Test plan:
[1] Select two patrons A and B in say categories C1 and C2.
[2] Change the msg prefs for A and B away from defaults.
[3] Run borrowers-force-messaging-defaults.pl -doit -cat C1
Verify that patron A changed and patron B did not.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

Amended: Replace -category by --category. (marcelr 20180304)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #71655|0   |1
is obsolete||

--- Comment #17 from Marcel de Rooy  ---
Created attachment 72850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72850=edit
Bug 19454: (Follow-up) Add a total line when updating

Test plan:
[1] Run the script with -doit and -cat [some_category] and verify that
the printed total is correct.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #15 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #14)

Thx Katrin for QAing.

> 1) Question: I notice all other options are are -- and the new one is the
> only one - - is there a reason to use one or the other?

Good catch :) There is no real difference. I will add a minus for consistency.
According to Getopt::Long we should one minus for single character options like
-l and two minuses for long option names like --long. But if you define a
'category' option and you have nothing else starting with a 'c', -c and --c
will work both.

> DBD::mysql::st execute failed: Column 'categorycode' in where clause is
> ambiguous 

Oops. Caused by a QA follow-up on one of the preceding reports that replaced a
subquery by a join, followed by a rebase here. Will fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #14 from Katrin Fischer  ---
Hi Marcel,

2 things I am afraid.

1) Question: I notice all other options are are -- and the new one is the only
one - - is there a reason to use one or the other?

2) The example given doesn't work for me:

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$
./misc/maintenance/borrowers-force-messaging-defaults.pl --doit -category PT

Since: -00-00
DBD::mysql::st execute failed: Column 'categorycode' in where clause is
ambiguous [for Statement "SELECT DISTINCT bo.borrowernumber, bo.categorycode
FROM borrowers bo
LEFT JOIN borrower_message_preferences mp USING (borrowernumber)
WHERE bo.dateenrolled >= ? AND categorycode = ?" with ParamValues:
0='-00-00', 1='PT'] at
./misc/maintenance/borrowers-force-messaging-defaults.pl line 62.
DBD::mysql::st fetchrow failed: fetch() without execute() [for Statement
"SELECT DISTINCT bo.borrowernumber, bo.categorycode FROM borrowers bo
LEFT JOIN borrower_message_preferences mp USING (borrowernumber)
WHERE bo.dateenrolled >= ? AND categorycode = ?" with ParamValues:
0='-00-00', 1='PT'] at ./misc/maintenance/borrowers-force


My database is using the test date, I made sure there are patrons with category
PT.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #13 from Marcel de Rooy  ---
Simple rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #69206|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 71655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71655=edit
Bug 19454: (Follow-up) Add a total line when updating

Test plan:
[1] Run the script with -doit and -cat [some_category] and verify that
the printed total is correct.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #69205|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 71654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71654=edit
Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl

Instead of updating patrons over all patron categories, it would be
helpful if we could filter on a specified category.

Test plan:
[1] Select two patrons A and B in say categories C1 and C2.
[2] Change the msg prefs for A and B away from defaults.
[3] Run borrowers-force-messaging-defaults.pl -doit -cat C1
Verify that patron A changed and patron B did not.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #10 from Marcel de Rooy  ---
(In reply to Charles Farmer from comment #9)
> Signed-off-by: Charles Farmer 

Thx Charles

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Charles Farmer  changed:

   What|Removed |Added

  Attachment #68202|0   |1
is obsolete||

--- Comment #8 from Charles Farmer  ---
Created attachment 69205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69205=edit
Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl

Instead of updating patrons over all patron categories, it would be
helpful if we could filter on a specified category.

Test plan:
[1] Select two patrons A and B in say categories C1 and C2.
[2] Change the msg prefs for A and B away from defaults.
[3] Run borrowers-force-messaging-defaults.pl -doit -cat C1
Verify that patron A changed and patron B did not.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Charles Farmer  changed:

   What|Removed |Added

  Attachment #68203|0   |1
is obsolete||

--- Comment #9 from Charles Farmer  ---
Created attachment 69206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69206=edit
Bug 19454: (Follow-up) Add a total line when updating

Test plan:
[1] Run the script with -doit and -cat [some_category] and verify that
the printed total is correct.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #7 from Marcel de Rooy  ---
(In reply to Charles Farmer from comment #6)
> Can't really say if the problem is on my end or not, but I couldn't apply
> your patches:
> > fatal: sha1 information is lacking or useless 
> > (misc/maintenance/borrowers-force-messaging-defaults.pl)

You need two dependencies. 19451 and 19452

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #6 from Charles Farmer  ---
Can't really say if the problem is on my end or not, but I couldn't apply your
patches:
> fatal: sha1 information is lacking or useless 
> (misc/maintenance/borrowers-force-messaging-defaults.pl)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #5 from Marcel de Rooy  ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68176|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 68202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68202=edit
Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl

Instead of updating patrons over all patron categories, it would be
helpful if we could filter on a specified category.

Test plan:
[1] Select two patrons A and B in say categories C1 and C2.
[2] Change the msg prefs for A and B away from defaults.
[3] Run borrowers-force-messaging-defaults.pl -doit -cat C1
Verify that patron A changed and patron B did not.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68177|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 68203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68203=edit
Bug 19454: (Follow-up) Add a total line when updating

Test plan:
[1] Run the script with -doit and -cat [some_category] and verify that
the printed total is correct.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #2 from Marcel de Rooy  ---
Created attachment 68177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68177=edit
Bug 19454: (Follow-up) Add a total line when updating

Test plan:
[1] Run the script with -doit and -cat [some_category] and verify that
the printed total is correct.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #1 from Marcel de Rooy  ---
Created attachment 68176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68176=edit
Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl

Instead of updating patrons over all patron categories, it would be
helpful if we could filter on a specified category.

Test plan:
[1] Select two patrons A and B in say categories C1 and C2.
[2] Change the msg prefs for A and B away from defaults.
[3] Run borrowers-force-messaging-defaults.pl -doit -cat C1
Verify that patron A changed and patron B did not.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Script  |Script
   |borrowers-force-messaging-d |borrowers-force-messaging-d
   |efaults.pl should filter on |efaults.pl should be able
   |patron category |to filter on patron
   ||category

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/