[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Bug 19489 depends on bug 22006, which changed state. Bug 22006 Summary: Koha::Account::Line->item should return undef if no item linked https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #30 from Nick Clemens --- Cleared minor conflict when applying (test counts) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens changed: What|Removed |Added Attachment #83301|0 |1 is obsolete|| --- Comment #29 from Nick Clemens --- Created attachment 83620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83620&action=edit Bug 19489: Cover non-existent issue Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens changed: What|Removed |Added Attachment #83300|0 |1 is obsolete|| --- Comment #28 from Nick Clemens --- Created attachment 83619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83619&action=edit Bug 19489: Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens changed: What|Removed |Added Attachment #83299|0 |1 is obsolete|| --- Comment #27 from Nick Clemens --- Created attachment 83618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83618&action=edit Bug 19489: Add the Koha::Account::Line->issue method Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #26 from Jonathan Druart --- I have updated the commit message, re-added the test plan and submitted a follow-up to cover the non-existing issue case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Jonathan Druart changed: What|Removed |Added Assignee|je...@bywatersolutions.com |kohadevi...@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Jonathan Druart changed: What|Removed |Added Attachment #83109|0 |1 is obsolete|| Attachment #83277|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 83299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83299&action=edit Bug 19489: Add the Koha::Account::Line->issue method Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #25 from Jonathan Druart --- Created attachment 83301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83301&action=edit Bug 19489: Cover non-existent issue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #24 from Jonathan Druart --- Created attachment 83300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83300&action=edit Bug 19489: Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Attachment #83276|0 |1 is obsolete|| --- Comment #22 from Devinim --- Created attachment 83277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83277&action=edit Bug 19489: (Improvements in KohaDate) Development for fines and Fees Module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Attachment #83110|0 |1 is obsolete|| Attachment #83242|0 |1 is obsolete|| --- Comment #21 from Devinim --- Created attachment 83276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83276&action=edit Bug 19489: (Improvements in KohaDate) Development for fines and Fees Module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #20 from Jonathan Druart --- Created attachment 83242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83242&action=edit Bug 19489: Simplify the code a bit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Jonathan Druart changed:
What|Removed |Added
Depends on||22006
--- Comment #19 from Jonathan Druart
---
(In reply to Devinim from comment #17)
> (In reply to Jonathan Druart from comment #15)
> > due_date must be displayed with the as_due_date flag, not with_hours:
> >
> > [% your_due_date | $KohaDates as_due_date => 1 %]
>
> Hi Jonathan,
>
> In order to make code integrity, we've looked at
> members/readingrec.tt
> Line 95 of that file also uses due_date.
It is wrong :)
IIRC due dates must be displayed using the as_due_date flag, to not show the
time part if 23:59
(In reply to Devinim from comment #18)
> (In reply to Jonathan Druart from comment #16)
> > 2. As well, the html filter is not needed when already KohaDates filtered.
>
> 2. As similar to answer 1, some other files also use html filter like
> reserve/request.tt
> catalogue/issuehistory.tt
It is because we removed the html filter when the $KohaDates occurrences were
used without parameters. It is not a big deal anyway but we could avoid
unnecessary processing removing these filters. I am going to deal with that on
a separate bug report.
> > 3. in printinvoice.pl
> >
> > +$accountline->{'item'} = $accountline->{itemnumber} ?
> > $accountline_object->item : "" ;
> > +$accountline->{'issue'} = $accountline->{issue_id} ?
> > $accountline_object->issue : "" ;
> >
> > It read wrong, why not:
> > $accountline->{item} = $accountline_object->item || "" ;
> > $accountline->{issue} = $accountline_object->issue || "";
> > ?
> >
> 3. If you choose Create manual invoice tab and then select a type without
> using a barcode number (like New Card), since there won't be an itemnumber
> in accountline table, item object will give an error like ( DBIC result
> _type isn't of the _type Item at
> /home/vagrant/kohaclone/members/printinvoice.pl line 60) .
It's a bug, I have opened bug 22006
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006
[Bug 22006] Koha::Account::Line->item should return undef if no item linked
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #18 from Devinim ---
(In reply to Jonathan Druart from comment #16)
> 2. As well, the html filter is not needed when already KohaDates filtered.
>
> 3. in printinvoice.pl
>
> +$accountline->{'item'} = $accountline->{itemnumber} ?
> $accountline_object->item : "" ;
> +$accountline->{'issue'} = $accountline->{issue_id} ?
> $accountline_object->issue : "" ;
>
> It read wrong, why not:
> $accountline->{item} = $accountline_object->item || "" ;
> $accountline->{issue} = $accountline_object->issue || "";
> ?
2. As similar to answer 1, some other files also use html filter like
reserve/request.tt
catalogue/issuehistory.tt
3. If you choose Create manual invoice tab and then select a type without using
a barcode number (like New Card), since there won't be an itemnumber in
accountline table, item object will give an error like ( DBIC result _type
isn't of the _type Item at /home/vagrant/kohaclone/members/printinvoice.pl line
60) .
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #17 from Devinim --- (In reply to Jonathan Druart from comment #15) > due_date must be displayed with the as_due_date flag, not with_hours: > > [% your_due_date | $KohaDates as_due_date => 1 %] Hi Jonathan, In order to make code integrity, we've looked at members/readingrec.tt Line 95 of that file also uses due_date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #16 from Jonathan Druart
---
2. As well, the html filter is not needed when already KohaDates filtered.
3. in printinvoice.pl
+$accountline->{'item'} = $accountline->{itemnumber} ?
$accountline_object->item : "" ;
+$accountline->{'issue'} = $accountline->{issue_id} ?
$accountline_object->issue : "" ;
It read wrong, why not:
$accountline->{item} = $accountline_object->item || "" ;
$accountline->{issue} = $accountline_object->issue || "";
?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart --- due_date must be displayed with the as_due_date flag, not with_hours: [% your_due_date | $KohaDates as_due_date => 1 %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens changed: What|Removed |Added Attachment #82614|0 |1 is obsolete|| Attachment #82846|0 |1 is obsolete|| --- Comment #13 from Nick Clemens --- Created attachment 83109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83109&action=edit Bug 19489: (Improvements in Unit test and Koha::Account::Line->issue method) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #14 from Nick Clemens --- Created attachment 83110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83110&action=edit Bug 19489: Development for fines and Fees Module Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Attachment #82615|0 |1 is obsolete|| --- Comment #12 from Devinim --- Created attachment 82846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82846&action=edit Bug 19489: Development for fines and Fees Module Due to changes in pay.tt occured from other patches we have renewed pay.tt file. Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #11 from Devinim --- (In reply to Owen Leonard from comment #9) > This seems to be working, but the test doesn't pass: > > t/db_dependent/Koha/Account/Lines.t .. 1/5 > # Failed test 'No tests run for subtest "item() tests"' > # at t/db_dependent/Koha/Account/Lines.t line 67. > DBIx::Class::Storage::DBI::_dbh_execute(): Field 'account_balance' doesn't > have a default value at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 288 > # Looks like your test exited with 255 just after 1. > t/db_dependent/Koha/Account/Lines.t .. Dubious, test returned 255 (wstat > 65280, 0xff00) > Failed 5/5 subtests > > Test Summary Report > --- > t/db_dependent/Koha/Account/Lines.t (Wstat: 65280 Tests: 1 Failed: 1) > Failed test: 1 > Non-zero exit status: 255 > Parse errors: Bad plan. You planned 5 tests but ran 1. > Files=1, Tests=1, 3 wallclock secs ( 0.01 usr 0.01 sys + 1.21 cusr 0.52 > csys = 1.75 CPU) > Result: FAIL We applied the test on the latest provisioned kohadevbox environment and we found that there are some changes to pay.tt . When we changed pay.tt manually we passed dependency test as you may see below. prove t/db_dependent/Koha/Account/Lines.t t/db_dependent/Koha/Account/Lines.t .. ok All tests successful. Files=1, Tests=5, 5 wallclock secs ( 0.03 usr 0.01 sys + 3.90 cusr 0.66 csys = 4.60 CPU) Result: PASS How did you get your errors? Thanks, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #10 from Devinim --- Hi Owen, It is most probably another patch made it this since we've tested before sending patches and unit tests. Our developers is looking once again, will change it soon. Thanks a lot. Devinim Koha Team -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard --- This seems to be working, but the test doesn't pass: t/db_dependent/Koha/Account/Lines.t .. 1/5 # Failed test 'No tests run for subtest "item() tests"' # at t/db_dependent/Koha/Account/Lines.t line 67. DBIx::Class::Storage::DBI::_dbh_execute(): Field 'account_balance' doesn't have a default value at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 288 # Looks like your test exited with 255 just after 1. t/db_dependent/Koha/Account/Lines.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 5/5 subtests Test Summary Report --- t/db_dependent/Koha/Account/Lines.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 5 tests but ran 1. Files=1, Tests=1, 3 wallclock secs ( 0.01 usr 0.01 sys + 1.21 cusr 0.52 csys = 1.75 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Blocks||21879 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21879 [Bug 21879] Code cleaning in printinvoice.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #8 from Devinim --- Created attachment 82615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82615&action=edit Bug 19489: Development for fines and Fees Module Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Attachment #82520|0 |1 is obsolete|| --- Comment #7 from Devinim --- Created attachment 82614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82614&action=edit Bug 19489: Improvements in Unit test and Koha::Account::Line->issue method Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Lines.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Attachment #82519|0 |1 is obsolete|| --- Comment #6 from Devinim --- Created attachment 82520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82520&action=edit Bug 19489 - (Object Method) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning Unit test added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Attachment #81991|0 |1 is obsolete|| --- Comment #5 from Devinim --- Created attachment 82519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82519&action=edit Bug 19489 - (Object Method) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning Unit test added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Attachment #81956|0 |1 is obsolete|| Attachment #81989|0 |1 is obsolete|| --- Comment #4 from Devinim --- Created attachment 81991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81991&action=edit Bug 19489 - (Object Method) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #3 from Devinim --- Created attachment 81989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81989&action=edit (Object method) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #2 from Nick Clemens ---
Comment on attachment 81956
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81956
Bug 19489 - Development for fines and Fees Module - Detailed Description of
charges in Patron Account Tab/Fines Tab
Review of attachment 81956:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19489&attachment=81956)
-
Everything works nicely in testing, the columns appear as expected.
The method for checkouts itself should be an object method for
Koha::Account::Line
It would be nice too if there were some refactoring to simply pass the Line
objects and use the fields/method on the the template rather than formatting in
a hash in the scripts
::: members/accountline-details.pl
@@ +24,5 @@
> use C4::Output;
> use C4::Context;
> use Koha::Patrons;
> +use Koha::Checkouts;
> +use Koha::Old::Checkouts;
Rather than importing these here we should implement 'checkout' as an object
method for the Koha::Account::Line
@@ +67,5 @@
> my $patron = Koha::Patrons->find( $accountline->borrowernumber );
> +my $issues;
> +if ( $accountline->issue_id ) {
> +$issues = Koha::Checkouts->find($accountline->issue_id );
> +$issues = Koha::Old::Checkouts->find($accountline->issue_id ) unless
> $issues;
As mentioned above - this should use an object method from Koha::Account::Line
The plural is also confusing as there should on ly ever be one
$accountline->checkout;
::: members/boraccount.pl
@@ +112,5 @@
> +
> +if ( $accountline->{issue_id} ) {
> +my $issues = Koha::Checkouts->find($accountline->{issue_id} );
> +$issues = Koha::Old::Checkouts->find($accountline->{issue_id} )
> unless $issues;
> +$accountline->{issue}= $issues;
As before, this should use an object method
::: members/pay.pl
@@ +152,5 @@
> }
> +if ( $account_line->{issue_id} ) {
> +my $issues = Koha::Checkouts->find($account_line->{issue_id} );
> +$issues = Koha::Old::Checkouts->find($account_line->{issue_id} )
> unless $issues;
> +$account_line->{issue}= $issues;
Use object method
::: members/printinvoice.pl
@@ +64,5 @@
> +
> +if ( $accountline->{issue_id} ) {
> +my $issues = Koha::Checkouts->find($accountline->{issue_id} );
> +$issues = Koha::Old::Checkouts->find($accountline->{issue_id} ) unless
> $issues;
> +$accountline->{issue}= $issues;
Use object method
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Status|NEW |Needs Signoff CC||kohadevi...@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #1 from Devinim --- Created attachment 81956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81956&action=edit Bug 19489 - Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Indranil Das Gupta changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=6508 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Indranil Das Gupta changed: What|Removed |Added CC||indr...@l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
