[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Josef Moravec changed: What|Removed |Added Status|Patch doesn't apply |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Michal Denar --- Josef, can You rebase this bug? Thank You Mike -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #14 from Josef Moravec--- Created attachment 73397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73397=edit Bug 19520: Add more information about rotating collections Test plan: 1) Apply the patch 2) Update database 3) prove t/db_dependent/Koha/RotatingCollections.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #13 from Josef Moravec--- Created attachment 73396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73396=edit Bug 19520: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Josef Moravecchanged: What|Removed |Added Attachment #73260|0 |1 is obsolete|| Attachment #73261|0 |1 is obsolete|| Attachment #73262|0 |1 is obsolete|| Attachment #73263|0 |1 is obsolete|| --- Comment #11 from Josef Moravec --- Created attachment 73394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73394=edit Bug 19520: Update database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #12 from Josef Moravec--- Created attachment 73395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73395=edit Bug 19520: Update databse schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #10 from Josef Moravec--- (In reply to M. Tompsett from comment #5) > Comment on attachment 72819 [details] [review] > Bug 19520: Update database > > Review of attachment 72819 [details] [review]: > - > > ::: > installer/data/mysql/atomicupdate/ > Bug19520_Add_more_information_to_rotating_collections.perl > @@ +5,5 @@ > > +$dbh->do( "ALTER TABLE collections ADD CONSTRAINT `collections_ibfk_2` > > FOREIGN KEY (`createdBy`) REFERENCES `borrowers` (`borrowernumber`) ON > > DELETE SET NULL ON UPDATE CASCADE"); > > + > > +$dbh->do( "ALTER TABLE collections ADD COLUMN createdOn datetime > > default NULL AFTER createdBy" ); > > + > > +$dbh->do( "ALTER TABLE collections ADD COLUMN lastTransferredOn > > datetime default NULL AFTER createdOn" ); > > These 4 do's should be encapsulated by !column_exists checks. > > @@ +10,5 @@ > > + > > +# or perform some test and warn > > +# if( !column_exists( 'biblio', 'biblionumber' ) ) { > > +#warn "There is something wrong"; > > +# } > > And you don't need comments. :) Done, thanks ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #7 from Josef Moravec--- Created attachment 73261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73261=edit Bug 19520: Update databse schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #8 from Josef Moravec--- Created attachment 73262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73262=edit Bug 19520: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #9 from Josef Moravec--- Created attachment 73263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73263=edit Bug 19520: Add more information about rotating collections Test plan: 1) Apply the patch 2) Update database 3) prove t/db_dependent/Koha/RotatingCollections.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Josef Moravecchanged: What|Removed |Added Attachment #72819|0 |1 is obsolete|| Attachment #72820|0 |1 is obsolete|| Attachment #72821|0 |1 is obsolete|| Attachment #72822|0 |1 is obsolete|| --- Comment #6 from Josef Moravec --- Created attachment 73260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73260=edit Bug 19520: Update database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #5 from M. Tompsett--- Comment on attachment 72819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72819 Bug 19520: Update database Review of attachment 72819: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19520=72819) - ::: installer/data/mysql/atomicupdate/Bug19520_Add_more_information_to_rotating_collections.perl @@ +5,5 @@ > +$dbh->do( "ALTER TABLE collections ADD CONSTRAINT `collections_ibfk_2` > FOREIGN KEY (`createdBy`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE > SET NULL ON UPDATE CASCADE"); > + > +$dbh->do( "ALTER TABLE collections ADD COLUMN createdOn datetime default > NULL AFTER createdBy" ); > + > +$dbh->do( "ALTER TABLE collections ADD COLUMN lastTransferredOn datetime > default NULL AFTER createdOn" ); These 4 do's should be encapsulated by !column_exists checks. @@ +10,5 @@ > + > +# or perform some test and warn > +# if( !column_exists( 'biblio', 'biblionumber' ) ) { > +#warn "There is something wrong"; > +# } And you don't need comments. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #2 from Josef Moravec--- Created attachment 72820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72820=edit Bug 19520: Update databse schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Josef Moravecchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #4 from Josef Moravec--- Created attachment 72822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72822=edit Bug 19520: Add more information about rotating collections Test plan: 1) Apply the patch 2) Update database 3) ) prove t/db_dependent/Koha/RotatingCollections.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #1 from Josef Moravec--- Created attachment 72819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72819=edit Bug 19520: Update database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 --- Comment #3 from Josef Moravec--- Created attachment 72821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72821=edit Bug 19520: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19520] Show more information about rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Josef Moravecchanged: What|Removed |Added Depends on||19519 Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519 [Bug 19519] Ability to bind the rotating collection with branch during creating -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/