[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 Bug 1963 depends on bug 8915, which changed state. Bug 8915 Summary: Referential integrity constraints and InnoDB vs MyISAM storage engine http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl --- I would favor pushing this patch, if we fix the constraint stuff on another report (including some lines in updatedatabase to correct the historical ballast from MyISAM etc.) This patches fixes a display problem that theoretically should not occur, but in practice does. The other report would deal with the wrong data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 --- Comment #12 from Kyle M Hall k...@bywatersolutions.com --- (In reply to comment #11) I would favor pushing this patch, if we fix the constraint stuff on another report (including some lines in updatedatabase to correct the historical ballast from MyISAM etc.) This patches fixes a display problem that theoretically should not occur, but in practice does. The other report would deal with the wrong data. I tend to agree. This patch may just be 'hiding' the underlying problem, but we are now aware of it. As long as we follow up on this issue with a correction 'under the hood', I see no reason not to push this as a quick fix from the user stand point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #13 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 --- Comment #7 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #6) So, please, push this patch. The constraint issue is more general, and related to storage Engine used. InnoDB is now mandatory. InnoDB is the MySQL default storage engine since version 5.1, replacing MyISAM. So the problem may occur less and less. But for legacy Koha DB, it can happen, and it can have surprising effect like this bug. mmm... definetely, i'm not for pushing this patch: without the patch, the problem is visible (even if, I agree, it's not easy to link the error with the DB problem) With the patch it's no more visible, and, as we say in french, it's hiding the dust under the carpet The correct solution is to fix your database problem. I'll ask other QA team member for their opinion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 --- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #7) (In reply to comment #6) So, please, push this patch. The constraint issue is more general, and related to storage Engine used. InnoDB is now mandatory. InnoDB is the MySQL default storage engine since version 5.1, replacing MyISAM. So the problem may occur less and less. But for legacy Koha DB, it can happen, and it can have surprising effect like this bug. mmm... definetely, i'm not for pushing this patch: without the patch, the problem is visible (even if, I agree, it's not easy to link the error with the DB problem) With the patch it's no more visible, and, as we say in french, it's hiding the dust under the carpet The correct solution is to fix your database problem. I'll ask other QA team member for their opinion I disagree. Frédéric submitted a patch which fixes the constraint problem, but in the meantime, this is a good workaround for those libraries that have the problem. There is absolutely no reason why library patrons should have to deal with errors, ever. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #8) I disagree. Frédéric submitted a patch which fixes the constraint problem, but in the meantime, this is a good workaround for those libraries that have the problem. There is absolutely no reason why library patrons should have to deal with errors, ever. Jared, it does not fix the constraint problem, it fixes the perl error. The proper way to fix the problem is to issue 3 SQL commands: 1- delete all wrong entries 2- switch to innodb 3- add the constraint * DELETE FROM virtualshefcontent WHERE biblionumber NOT IN (SELECT biblio.biblionumber FROM biblio WHERE biblio.biblionumber=virtualshelfcontent.biblionumber) * ALTER TABLE virtualshelfcontent ENGINE=innodb * ALTER TABLE virtualshelfcontent ADD CONSTRAINT ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 --- Comment #10 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #9) (In reply to comment #8) I disagree. Frédéric submitted a patch which fixes the constraint problem, but in the meantime, this is a good workaround for those libraries that have the problem. There is absolutely no reason why library patrons should have to deal with errors, ever. Jared, it does not fix the constraint problem, it fixes the perl error. The proper way to fix the problem is to issue 3 SQL commands: 1- delete all wrong entries 2- switch to innodb 3- add the constraint * DELETE FROM virtualshefcontent WHERE biblionumber NOT IN (SELECT biblio.biblionumber FROM biblio WHERE biblio.biblionumber=virtualshelfcontent.biblionumber) * ALTER TABLE virtualshelfcontent ENGINE=innodb * ALTER TABLE virtualshelfcontent ADD CONSTRAINT ... Not this patch. Frédéric submitted a separate patch for updating the constraints. Bug 8915. However, that one requires a great deal of testing, I think. This patch will serve to keep patrons from being exposed to errors while we make sure there are no undesired side effects. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Depends on||8915 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * this patch fixes the display, but not the main problem: we should not let a list have a biblio that has been removed. A follow-up would be useful to clean the database then add a constraint * I agree that fixing the display is a first step, but this bug should not be closed until the main problem is fixed. passed QA for this one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 --- Comment #5 from Paul Poulain paul.poul...@biblibre.com --- mmm... before pushing, I had a doubt and checked kohastructure. The constraint already exists. CONSTRAINT `shelfcontents_ibfk_2` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE, So, Frederic, this case should not happen. Could you check your structure, and do you have an explanation. The constraint has been added by commit d6f8fde9 installer/data/mysql/kohastructure.sql (Marcel de Rooy 2011-12-08 16:10:57 +0100 2128) CONSTRAINT `shel is it possible that your database has been created before and the updatedatabase failed (because of invalid data) ? (not pushing this patch for now, needs a little bit more investigation) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|RESOLVED|REOPENED CC||frede...@tamil.fr Hardware|Macintosh |All Version|rel_2_2 |master Resolution|MOVED |--- --- Comment #1 from Frédéric Demians frede...@tamil.fr --- This bug reappear in HEAD/3.8. When trying to display a virtual shelf (list) containing a deleted biblio, this error message is displayed: Software error: Can't call method field on an undefined value at C4/Koha.pm line 1231. A fix is possible by modifying SQL query retrieving biblios, just skipping records from virtual shelf table with no linked record in biblio table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 --- Comment #2 from Frédéric Demians frede...@tamil.fr --- Created attachment 12694 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12694action=edit Bug 1963 Problem with deleted biblio in a virtual shelf This bug reappear in HEAD/3.8. When trying to display a virtual shelf (list) containing a deleted biblio, this error message is displayed: Software error: Can't call method field on an undefined value at C4/Koha.pm line 1231. This fix modify SQL query retrieving biblios, just skipping records from virtual shelf table with no linked record in biblio table: LEFT JOIN replace with JOIN. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12694|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12696 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12696action=edit Bug 1963 Problem with deleted biblio in a virtual shelf This bug reappear in HEAD/3.8. When trying to display a virtual shelf (list) containing a deleted biblio, this error message is displayed: Software error: Can't call method field on an undefined value at C4/Koha.pm line 1231. This fix modify SQL query retrieving biblios, just skipping records from virtual shelf table with no linked record in biblio table: LEFT JOIN replace with JOIN. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
